Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9944/?format=api
{ "id": 9944, "url": "https://patches.dpdk.org/api/patches/9944/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1453120248-28274-11-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1453120248-28274-11-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1453120248-28274-11-git-send-email-david.marchand@6wind.com", "date": "2016-01-18T12:30:48", "name": "[dpdk-dev,v2,10/10] pci: place all uio pci device ids in a dedicated section", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "69ae00e179014ac601b5c486af1a368773022c60", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1453120248-28274-11-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9944/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9944/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2B3DC8E96;\n\tMon, 18 Jan 2016 13:31:13 +0100 (CET)", "from mail-wm0-f43.google.com (mail-wm0-f43.google.com\n\t[74.125.82.43]) by dpdk.org (Postfix) with ESMTP id AF938919D\n\tfor <dev@dpdk.org>; Mon, 18 Jan 2016 13:31:07 +0100 (CET)", "by mail-wm0-f43.google.com with SMTP id r129so49350498wmr.0\n\tfor <dev@dpdk.org>; Mon, 18 Jan 2016 04:31:07 -0800 (PST)", "from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net.\n\t[78.126.77.144]) by smtp.gmail.com with ESMTPSA id\n\tu191sm15606572wmd.4.2016.01.18.04.31.05\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tMon, 18 Jan 2016 04:31:05 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-type:content-transfer-encoding;\n\tbh=7JUIBbqKG0Hjn70ARZuuUzhH+s62p6PyzekE3XqQDnM=;\n\tb=ezLg19TiAbZTawybPkskZqv2naDAicz3MU9s3ByUHI8hkve/ctXZDC3hg5tVSwG2dY\n\tXz5VIvCm+vkQPt/PPjBvpXrGSnTtmmPxQl3WTjeM2yo72LvNX26Vl3ybVVOKXi92HaoV\n\tc/BhWptGima4D2IR98DT1eaJ7jtIHxnJJlKP/iGGioUtvj0A3Y2757Jd7vst40j+W7w/\n\t5wJ2ODsV1GLe2KZW/XQeJ/J0wHjMEqFm1wcvaLaHOcMV6SMh8Ybiwdjl6aeilLIJak8Z\n\txVULyKaVRw5W9pPQUk8gvYiS/RsdGbxJ+JwZIybie8eRF6dhHJbjoXiOkpUauyr0mntI\n\t2N4g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\tbh=7JUIBbqKG0Hjn70ARZuuUzhH+s62p6PyzekE3XqQDnM=;\n\tb=MsvRMK3Fac25EF49Kw6+zEAAz6mBng2p9wPgu/c4zYt6lvWz2frGh/1R7XAUwUXPT4\n\thj9WRD/vNhkL2d85j1tpJpIz8NKkcfICdL+8f0beZDG1qhu5q3MqZNyRK61E59Oyz0y5\n\tReapgqNYUZBQK8lwWSXfL1sZr5NjpNcYS7Dqsh+Ia+pbOzrQd5lrns7yRhoOEBJE1sXj\n\tta0bmaZpXw5PT/bkWc7AeiRSZMmS042s2zM9vDkvSGi7xqtctUGz+Zmzz51r0cfXJLqe\n\to5xqvHKeTePDy3jdaTrvXWEVNn4dPcDD2ytjV5uoJ8Yi9iNYaggSP8aqKbCAcXL0VMmF\n\tu4/A==", "X-Gm-Message-State": "AG10YOSzK+sXIRSPhCXCiZSfUL05jZmQCDQp0Y/apldPUes6Zq5LQzTshgLVaomD+jp2PPC6", "X-Received": "by 10.28.111.194 with SMTP id c63mr13428414wmi.90.1453120266551; \n\tMon, 18 Jan 2016 04:31:06 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 18 Jan 2016 13:30:48 +0100", "Message-Id": "<1453120248-28274-11-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1453120248-28274-1-git-send-email-david.marchand@6wind.com>", "References": "<1452430254-30390-1-git-send-email-david.marchand@6wind.com>\n\t<1453120248-28274-1-git-send-email-david.marchand@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 10/10] pci: place all uio pci device ids in a\n\tdedicated section", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We could do something à la modinfo, but let's keep it simple for now.\n\nWith this, you can extract the devices that need to be bound to uio / vfio\nwith tools like objdump :\n\n$ objdump -j rte_pci_id_uio -s build/lib/librte_pmd_fm10k.so\n\nContents of section rte_pci_id_uio:\n 15760 8680a415 ffffffff 8680d015 ffffffff ................\n 15770 8680a515 ffffffff 00000000 00000000 ................\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-\n drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++--\n drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-\n drivers/net/e1000/em_ethdev.c | 2 +-\n drivers/net/e1000/igb_ethdev.c | 4 ++--\n drivers/net/enic/enic_ethdev.c | 2 +-\n drivers/net/fm10k/fm10k_ethdev.c | 2 +-\n drivers/net/i40e/i40e_ethdev.c | 2 +-\n drivers/net/i40e/i40e_ethdev_vf.c | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--\n drivers/net/nfp/nfp_net.c | 2 +-\n drivers/net/virtio/virtio_ethdev.c | 2 +-\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-\n lib/librte_eal/common/include/rte_pci.h | 2 ++\n 14 files changed, 18 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c\nindex e500c1e..c9f5790 100644\n--- a/drivers/crypto/qat/rte_qat_cryptodev.c\n+++ b/drivers/crypto/qat/rte_qat_cryptodev.c\n@@ -67,7 +67,7 @@ static struct rte_cryptodev_ops crypto_qat_ops = {\n * The set of PCI devices this driver supports\n */\n \n-static struct rte_pci_id pci_id_qat_map[] = {\n+static struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_qat_map[] = {\n \t\t{\n \t\t\t.vendor_id = 0x8086,\n \t\t\t.device_id = 0x0443,\ndiff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex 7655124..72546bd 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -17,7 +17,7 @@\n * The set of PCI devices this driver supports\n */\n #define PCI_VENDOR_ID_BROADCOM 0x14E4\n-static struct rte_pci_id pci_id_bnx2x_map[] = {\n+static struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_bnx2x_map[] = {\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, CHIP_NUM_57800) },\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, CHIP_NUM_57711) },\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, CHIP_NUM_57810) },\n@@ -33,7 +33,7 @@ static struct rte_pci_id pci_id_bnx2x_map[] = {\n \t{ .vendor_id = 0, }\n };\n \n-static struct rte_pci_id pci_id_bnx2xvf_map[] = {\n+static struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_bnx2xvf_map[] = {\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, CHIP_NUM_57800_VF) },\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, CHIP_NUM_57810_VF) },\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, CHIP_NUM_57811_VF) },\ndiff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex 97ef152..2620130 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -68,7 +68,7 @@\n * Macros needed to support the PCI Device ID Table ...\n */\n #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \\\n-\tstatic struct rte_pci_id cxgb4_pci_tbl[] = {\n+\tstatic struct rte_pci_id RTE_PCI_ID_UIO_SECTION cxgb4_pci_tbl[] = {\n #define CH_PCI_DEVICE_ID_FUNCTION 0x4\n \n #define PCI_VENDOR_ID_CHELSIO 0x1425\ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 4cf9217..fb71686 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -136,7 +136,7 @@ static enum e1000_fc_mode em_fc_setting = e1000_fc_full;\n /*\n * The set of PCI devices this driver supports\n */\n-static const struct rte_pci_id pci_id_em_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_em_map[] = {\n \n #define RTE_PCI_DEV_ID_DECL_EM(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"em_pci_dev_ids.h\"\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 3f85a2c..f71bcd1 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -273,7 +273,7 @@ static enum e1000_fc_mode igb_fc_setting = e1000_fc_full;\n /*\n * The set of PCI devices this driver supports\n */\n-static const struct rte_pci_id pci_id_igb_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_igb_map[] = {\n \n #define RTE_PCI_DEV_ID_DECL_IGB(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"igb_pci_dev_ids.h\"\n@@ -284,7 +284,7 @@ static const struct rte_pci_id pci_id_igb_map[] = {\n /*\n * The set of PCI devices this driver supports (for 82576&I350 VF)\n */\n-static const struct rte_pci_id pci_id_igbvf_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_igbvf_map[] = {\n \n #define RTE_PCI_DEV_ID_DECL_IGBVF(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"igb_pci_dev_ids.h\"\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex a70c364..493b154 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -58,7 +58,7 @@\n * The set of PCI devices this driver supports\n */\n #define PCI_VENDOR_ID_CISCO 0x1137\n-static const struct rte_pci_id pci_id_enic_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_enic_map[] = {\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_CISCO_VIC_ENET) },\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_CISCO_VIC_ENET_VF) },\n \t{.vendor_id = 0, /* sentinel */},\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 2c4905c..4e5748c 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2740,7 +2740,7 @@ eth_fm10k_dev_uninit(struct rte_eth_dev *dev)\n * The set of PCI devices this driver supports. This driver will enable both PF\n * and SRIOV-VF devices.\n */\n-static const struct rte_pci_id pci_id_fm10k_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_fm10k_map[] = {\n \t{ RTE_PCI_DEVICE(FM10K_INTEL_VENDOR_ID, FM10K_DEV_ID_PF) },\n \t{ RTE_PCI_DEVICE(FM10K_INTEL_VENDOR_ID, FM10K_DEV_ID_SDI_FM10420_QDA2) },\n \t{ RTE_PCI_DEVICE(FM10K_INTEL_VENDOR_ID, FM10K_DEV_ID_VF) },\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex e9f6587..6801b9f 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -415,7 +415,7 @@ static int i40e_dev_rx_queue_intr_disable(struct rte_eth_dev *dev,\n \t\t\t\t\t uint16_t queue_id);\n \n \n-static const struct rte_pci_id pci_id_i40e_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_i40e_map[] = {\n \t{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_SFP_XL710) },\n \t{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_QEMU) },\n \t{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_A) },\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 9302f27..f925265 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1116,7 +1116,7 @@ i40evf_get_link_status(struct rte_eth_dev *dev, struct rte_eth_link *link)\n \treturn 0;\n }\n \n-static const struct rte_pci_id pci_id_i40evf_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_i40evf_map[] = {\n \t{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_VF) },\n \t{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_VF_HV) },\n \t{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_X722_VF) },\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex b31f52e..f970ca9 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -378,7 +378,7 @@ static int ixgbe_timesync_write_time(struct rte_eth_dev *dev,\n /*\n * The set of PCI devices this driver supports\n */\n-static const struct rte_pci_id pci_id_ixgbe_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_ixgbe_map[] = {\n \n #define RTE_PCI_DEV_ID_DECL_IXGBE(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"ixgbe_pci_dev_ids.h\"\n@@ -390,7 +390,7 @@ static const struct rte_pci_id pci_id_ixgbe_map[] = {\n /*\n * The set of PCI devices this driver supports (for 82599 VF)\n */\n-static const struct rte_pci_id pci_id_ixgbevf_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_ixgbevf_map[] = {\n \n #define RTE_PCI_DEV_ID_DECL_IXGBEVF(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"ixgbe_pci_dev_ids.h\"\ndiff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex bc2089f..32bcec1 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -2444,7 +2444,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n-static struct rte_pci_id pci_id_nfp_net_map[] = {\n+static struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_nfp_net_map[] = {\n \t{\n \t\t.vendor_id = PCI_VENDOR_ID_NETRONOME,\n \t\t.device_id = PCI_DEVICE_ID_NFP6000_PF_NIC,\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 94486e6..9cbb5dd 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -105,7 +105,7 @@ static int virtio_dev_queue_stats_mapping_set(\n /*\n * The set of PCI devices this driver supports\n */\n-static const struct rte_pci_id pci_id_virtio_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_virtio_map[] = {\n \t{ RTE_PCI_DEVICE(VIRTIO_PCI_VENDORID, VIRTIO_PCI_DEVICEID_MIN) },\n \t{ .vendor_id = 0, /* sentinel */ },\n };\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 304f076..6d03695 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -100,7 +100,7 @@ static void vmxnet3_process_events(struct vmxnet3_hw *);\n */\n #define PCI_VENDOR_ID_VMWARE 0x15AD\n #define VMWARE_DEV_ID_VMXNET3 0x07B0\n-static const struct rte_pci_id pci_id_vmxnet3_map[] = {\n+static const struct rte_pci_id RTE_PCI_ID_UIO_SECTION pci_id_vmxnet3_map[] = {\n \t{ RTE_PCI_DEVICE(PCI_VENDOR_ID_VMWARE, VMWARE_DEV_ID_VMXNET3) },\n \t{ .vendor_id = 0, /* sentinel */ },\n };\ndiff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h\nindex 334c12e..094b1c0 100644\n--- a/lib/librte_eal/common/include/rte_pci.h\n+++ b/lib/librte_eal/common/include/rte_pci.h\n@@ -131,6 +131,8 @@ struct rte_pci_id {\n \tuint16_t subsystem_device_id; /**< Subsystem device ID or PCI_ANY_ID. */\n };\n \n+#define RTE_PCI_ID_UIO_SECTION __attribute__((section(\"rte_pci_id_uio\")))\n+\n /**\n * A structure describing the location of a PCI device.\n */\n", "prefixes": [ "dpdk-dev", "v2", "10/10" ] }