Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99382/?format=api
{ "id": 99382, "url": "https://patches.dpdk.org/api/patches/99382/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210922034152.50196-2-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210922034152.50196-2-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210922034152.50196-2-humin29@huawei.com", "date": "2021-09-22T03:41:51", "name": "[1/2] net/hns3: fix residual old MAC after setting default MAC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "abc486b35dbed94a375c03328309a1d280deb5b6", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210922034152.50196-2-humin29@huawei.com/mbox/", "series": [ { "id": 19065, "url": "https://patches.dpdk.org/api/series/19065/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19065", "date": "2021-09-22T03:41:50", "name": "Bugfix for hns3 MAC", "version": 1, "mbox": "https://patches.dpdk.org/series/19065/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99382/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/99382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 01FD9A0C45;\n\tWed, 22 Sep 2021 05:43:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 08EA941184;\n\tWed, 22 Sep 2021 05:43:27 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 617DF4003F\n for <dev@dpdk.org>; Wed, 22 Sep 2021 05:43:24 +0200 (CEST)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HDkd10gQGzWMQn;\n Wed, 22 Sep 2021 11:42:13 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.8; Wed, 22 Sep 2021 11:43:22 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Wed, 22 Sep 2021 11:41:51 +0800", "Message-ID": "<20210922034152.50196-2-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20210922034152.50196-1-humin29@huawei.com>", "References": "<20210922034152.50196-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] net/hns3: fix residual old MAC after setting\n default MAC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThis problem occurs in the following scenarios:\n1) reset is encountered when the adapter is running.\n2) set a new default MAC address\n\nAfter the above two steps, the old default MAC address should be not take\neffect. But the current behavior is contrary to that. This is due to the\nchange of the \"default_addr_setted\" in hw->mac from 'true' to 'false' after\nthe reset. As a result, the old MAC address is not removed when the new\ndefault MAC address is set. This variable controls whether to delete the\nold default MAC address when setting the default MAC address. It is only\nused when the mac_addr_set API is called for the first time. In fact, when\na unicast MAC address is deleted, if the address isn't in the MAC address\ntable, the driver doesn't return failure. So this patch remove the\nredundant and troublesome variables to resolve this problem.\n\nFixes: 7d7f9f80bbfb (\"net/hns3: support MAC address related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 38 ++++++++++------------------------\n drivers/net/hns3/hns3_ethdev.h | 1 -\n 2 files changed, 11 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 7d37004972..5c8ac5754f 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -1651,7 +1651,7 @@ hns3_remove_mc_addr_common(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)\n \n static int\n hns3_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,\n-\t\t uint32_t idx, __rte_unused uint32_t pool)\n+\t\t __rte_unused uint32_t idx, __rte_unused uint32_t pool)\n {\n \tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n@@ -1682,8 +1682,6 @@ hns3_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,\n \t\treturn ret;\n \t}\n \n-\tif (idx == 0)\n-\t\thw->mac.default_addr_setted = true;\n \trte_spinlock_unlock(&hw->lock);\n \n \treturn ret;\n@@ -1748,30 +1746,19 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev,\n \tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct rte_ether_addr *oaddr;\n \tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n-\tbool default_addr_setted;\n \tint ret, ret_val;\n \n-\t/*\n-\t * It has been guaranteed that input parameter named mac_addr is valid\n-\t * address in the rte layer of DPDK framework.\n-\t */\n-\toaddr = (struct rte_ether_addr *)hw->mac.mac_addr;\n-\tdefault_addr_setted = hw->mac.default_addr_setted;\n-\tif (default_addr_setted && !!rte_is_same_ether_addr(mac_addr, oaddr))\n-\t\treturn 0;\n-\n \trte_spinlock_lock(&hw->lock);\n-\tif (default_addr_setted) {\n-\t\tret = hns3_remove_uc_addr_common(hw, oaddr);\n-\t\tif (ret) {\n-\t\t\thns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,\n-\t\t\t\t\t oaddr);\n-\t\t\thns3_warn(hw, \"Remove old uc mac address(%s) fail: %d\",\n-\t\t\t\t mac_str, ret);\n+\toaddr = (struct rte_ether_addr *)hw->mac.mac_addr;\n+\tret = hns3_remove_uc_addr_common(hw, oaddr);\n+\tif (ret) {\n+\t\thns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,\n+\t\t\t\t oaddr);\n+\t\thns3_warn(hw, \"Remove old uc mac address(%s) fail: %d\",\n+\t\t\t mac_str, ret);\n \n-\t\t\trte_spinlock_unlock(&hw->lock);\n-\t\t\treturn ret;\n-\t\t}\n+\t\trte_spinlock_unlock(&hw->lock);\n+\t\treturn ret;\n \t}\n \n \tret = hns3_add_uc_addr_common(hw, mac_addr);\n@@ -1790,7 +1777,6 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev,\n \n \trte_ether_addr_copy(mac_addr,\n \t\t\t (struct rte_ether_addr *)hw->mac.mac_addr);\n-\thw->mac.default_addr_setted = true;\n \trte_spinlock_unlock(&hw->lock);\n \n \treturn 0;\n@@ -1811,7 +1797,6 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev,\n \t\thns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, oaddr);\n \t\thns3_warn(hw, \"Failed to restore old uc mac addr(%s): %d\",\n \t\t\t\t mac_str, ret_val);\n-\t\thw->mac.default_addr_setted = false;\n \t}\n \trte_spinlock_unlock(&hw->lock);\n \n@@ -3473,7 +3458,6 @@ hns3_get_board_configuration(struct hns3_hw *hw)\n \thw->rss_dis_flag = false;\n \tmemcpy(hw->mac.mac_addr, cfg.mac_addr, RTE_ETHER_ADDR_LEN);\n \thw->mac.phy_addr = cfg.phy_addr;\n-\thw->mac.default_addr_setted = false;\n \thw->num_tx_desc = cfg.tqp_desc_num;\n \thw->num_rx_desc = cfg.tqp_desc_num;\n \thw->dcb_info.num_pg = 1;\n@@ -5931,7 +5915,7 @@ hns3_do_stop(struct hns3_adapter *hns)\n \t\t\treturn ret;\n \t\t}\n \t}\n-\thw->mac.default_addr_setted = false;\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 0e4e4269a1..243a4046ae 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -188,7 +188,6 @@ enum hns3_media_type {\n \n struct hns3_mac {\n \tuint8_t mac_addr[RTE_ETHER_ADDR_LEN];\n-\tbool default_addr_setted; /* whether default addr(mac_addr) is set */\n \tuint8_t media_type;\n \tuint8_t phy_addr;\n \tuint8_t link_duplex : 1; /* ETH_LINK_[HALF/FULL]_DUPLEX */\n", "prefixes": [ "1/2" ] }