Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99324/?format=api
{ "id": 99324, "url": "https://patches.dpdk.org/api/patches/99324/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210920150133.84928-3-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210920150133.84928-3-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210920150133.84928-3-cristian.dumitrescu@intel.com", "date": "2021-09-20T15:01:32", "name": "[V5,3/4] examples/pipeline: add support for learner tables", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ee098d0ccc22113ecaf1ffceba977e57dee34c0a", "submitter": { "id": 19, "url": "https://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210920150133.84928-3-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 19048, "url": "https://patches.dpdk.org/api/series/19048/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19048", "date": "2021-09-20T15:01:30", "name": "[V5,1/4] table: add support learner tables", "version": 5, "mbox": "https://patches.dpdk.org/series/19048/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99324/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99324/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D5408A0548;\n\tMon, 20 Sep 2021 17:01:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 41A33410F5;\n\tMon, 20 Sep 2021 17:01:41 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id CE5EE40DF7\n for <dev@dpdk.org>; Mon, 20 Sep 2021 17:01:38 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Sep 2021 08:01:38 -0700", "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com) ([10.237.223.107])\n by orsmga003.jf.intel.com with ESMTP; 20 Sep 2021 08:01:37 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10113\"; a=\"245557187\"", "E=Sophos;i=\"5.85,308,1624345200\"; d=\"scan'208\";a=\"245557187\"", "E=Sophos;i=\"5.85,308,1624345200\"; d=\"scan'208\";a=\"435552186\"" ], "X-ExtLoop1": "1", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 20 Sep 2021 16:01:32 +0100", "Message-Id": "<20210920150133.84928-3-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210920150133.84928-1-cristian.dumitrescu@intel.com>", "References": "<20210816122257.84651-1-cristian.dumitrescu@intel.com>\n <20210920150133.84928-1-cristian.dumitrescu@intel.com>", "Subject": "[dpdk-dev] [PATCH V5 3/4] examples/pipeline: add support for\n learner tables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add application-level support for learner tables.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\n examples/pipeline/cli.c | 174 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 174 insertions(+)", "diff": "diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c\nindex 1e2dd9d704..39b1e7a41b 100644\n--- a/examples/pipeline/cli.c\n+++ b/examples/pipeline/cli.c\n@@ -1829,6 +1829,104 @@ cmd_pipeline_selector_show(char **tokens,\n \t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"selector_name\");\n }\n \n+static int\n+pipeline_learner_default_entry_add(struct rte_swx_ctl_pipeline *p,\n+\t\t\t\t const char *learner_name,\n+\t\t\t\t FILE *file,\n+\t\t\t\t uint32_t *file_line_number)\n+{\n+\tchar *line = NULL;\n+\tuint32_t line_id = 0;\n+\tint status = 0;\n+\n+\t/* Buffer allocation. */\n+\tline = malloc(MAX_LINE_SIZE);\n+\tif (!line)\n+\t\treturn -ENOMEM;\n+\n+\t/* File read. */\n+\tfor (line_id = 1; ; line_id++) {\n+\t\tstruct rte_swx_table_entry *entry;\n+\t\tint is_blank_or_comment;\n+\n+\t\tif (fgets(line, MAX_LINE_SIZE, file) == NULL)\n+\t\t\tbreak;\n+\n+\t\tentry = rte_swx_ctl_pipeline_learner_default_entry_read(p,\n+\t\t\t\t\t\t\t\t\tlearner_name,\n+\t\t\t\t\t\t\t\t\tline,\n+\t\t\t\t\t\t\t\t\t&is_blank_or_comment);\n+\t\tif (!entry) {\n+\t\t\tif (is_blank_or_comment)\n+\t\t\t\tcontinue;\n+\n+\t\t\tstatus = -EINVAL;\n+\t\t\tgoto error;\n+\t\t}\n+\n+\t\tstatus = rte_swx_ctl_pipeline_learner_default_entry_add(p,\n+\t\t\t\t\t\t\t\t\tlearner_name,\n+\t\t\t\t\t\t\t\t\tentry);\n+\t\ttable_entry_free(entry);\n+\t\tif (status)\n+\t\t\tgoto error;\n+\t}\n+\n+error:\n+\t*file_line_number = line_id;\n+\tfree(line);\n+\treturn status;\n+}\n+\n+static const char cmd_pipeline_learner_default_help[] =\n+\"pipeline <pipeline_name> learner <learner_name> default <file_name>\\n\";\n+\n+static void\n+cmd_pipeline_learner_default(char **tokens,\n+\t\t\t uint32_t n_tokens,\n+\t\t\t char *out,\n+\t\t\t size_t out_size,\n+\t\t\t void *obj)\n+{\n+\tstruct pipeline *p;\n+\tchar *pipeline_name, *learner_name, *file_name;\n+\tFILE *file = NULL;\n+\tuint32_t file_line_number = 0;\n+\tint status;\n+\n+\tif (n_tokens != 6) {\n+\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n+\t\treturn;\n+\t}\n+\n+\tpipeline_name = tokens[1];\n+\tp = pipeline_find(obj, pipeline_name);\n+\tif (!p || !p->ctl) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"pipeline_name\");\n+\t\treturn;\n+\t}\n+\n+\tlearner_name = tokens[3];\n+\n+\tfile_name = tokens[5];\n+\tfile = fopen(file_name, \"r\");\n+\tif (!file) {\n+\t\tsnprintf(out, out_size, \"Cannot open file %s.\\n\", file_name);\n+\t\treturn;\n+\t}\n+\n+\tstatus = pipeline_learner_default_entry_add(p->ctl,\n+\t\t\t\t\t\t learner_name,\n+\t\t\t\t\t\t file,\n+\t\t\t\t\t\t &file_line_number);\n+\tif (status)\n+\t\tsnprintf(out, out_size, \"Invalid entry in file %s at line %u\\n\",\n+\t\t\t file_name,\n+\t\t\t file_line_number);\n+\n+\tfclose(file);\n+}\n+\n static const char cmd_pipeline_commit_help[] =\n \"pipeline <pipeline_name> commit\\n\";\n \n@@ -2503,6 +2601,64 @@ cmd_pipeline_stats(char **tokens,\n \t\t\tout += strlen(out);\n \t\t}\n \t}\n+\n+\tsnprintf(out, out_size, \"\\nLearner tables:\\n\");\n+\tout_size -= strlen(out);\n+\tout += strlen(out);\n+\n+\tfor (i = 0; i < info.n_learners; i++) {\n+\t\tstruct rte_swx_ctl_learner_info learner_info;\n+\t\tuint64_t n_pkts_action[info.n_actions];\n+\t\tstruct rte_swx_learner_stats stats = {\n+\t\t\t.n_pkts_hit = 0,\n+\t\t\t.n_pkts_miss = 0,\n+\t\t\t.n_pkts_action = n_pkts_action,\n+\t\t};\n+\t\tuint32_t j;\n+\n+\t\tstatus = rte_swx_ctl_learner_info_get(p->p, i, &learner_info);\n+\t\tif (status) {\n+\t\t\tsnprintf(out, out_size, \"Learner table info get error.\");\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tstatus = rte_swx_ctl_pipeline_learner_stats_read(p->p, learner_info.name, &stats);\n+\t\tif (status) {\n+\t\t\tsnprintf(out, out_size, \"Learner table stats read error.\");\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tsnprintf(out, out_size, \"\\tLearner table %s:\\n\"\n+\t\t\t\"\\t\\tHit (packets): %\" PRIu64 \"\\n\"\n+\t\t\t\"\\t\\tMiss (packets): %\" PRIu64 \"\\n\"\n+\t\t\t\"\\t\\tLearn OK (packets): %\" PRIu64 \"\\n\"\n+\t\t\t\"\\t\\tLearn error (packets): %\" PRIu64 \"\\n\"\n+\t\t\t\"\\t\\tForget (packets): %\" PRIu64 \"\\n\",\n+\t\t\tlearner_info.name,\n+\t\t\tstats.n_pkts_hit,\n+\t\t\tstats.n_pkts_miss,\n+\t\t\tstats.n_pkts_learn_ok,\n+\t\t\tstats.n_pkts_learn_err,\n+\t\t\tstats.n_pkts_forget);\n+\t\tout_size -= strlen(out);\n+\t\tout += strlen(out);\n+\n+\t\tfor (j = 0; j < info.n_actions; j++) {\n+\t\t\tstruct rte_swx_ctl_action_info action_info;\n+\n+\t\t\tstatus = rte_swx_ctl_action_info_get(p->p, j, &action_info);\n+\t\t\tif (status) {\n+\t\t\t\tsnprintf(out, out_size, \"Action info get error.\");\n+\t\t\t\treturn;\n+\t\t\t}\n+\n+\t\t\tsnprintf(out, out_size, \"\\t\\tAction %s (packets): %\" PRIu64 \"\\n\",\n+\t\t\t\taction_info.name,\n+\t\t\t\tstats.n_pkts_action[j]);\n+\t\t\tout_size -= strlen(out);\n+\t\t\tout += strlen(out);\n+\t\t}\n+\t}\n }\n \n static const char cmd_thread_pipeline_enable_help[] =\n@@ -2634,6 +2790,7 @@ cmd_help(char **tokens,\n \t\t\t\"\\tpipeline selector group member add\\n\"\n \t\t\t\"\\tpipeline selector group member delete\\n\"\n \t\t\t\"\\tpipeline selector show\\n\"\n+\t\t\t\"\\tpipeline learner default\\n\"\n \t\t\t\"\\tpipeline commit\\n\"\n \t\t\t\"\\tpipeline abort\\n\"\n \t\t\t\"\\tpipeline regrd\\n\"\n@@ -2783,6 +2940,15 @@ cmd_help(char **tokens,\n \t\treturn;\n \t}\n \n+\tif ((strcmp(tokens[0], \"pipeline\") == 0) &&\n+\t\t(n_tokens == 3) &&\n+\t\t(strcmp(tokens[1], \"learner\") == 0) &&\n+\t\t(strcmp(tokens[2], \"default\") == 0)) {\n+\t\tsnprintf(out, out_size, \"\\n%s\\n\",\n+\t\t\tcmd_pipeline_learner_default_help);\n+\t\treturn;\n+\t}\n+\n \tif ((strcmp(tokens[0], \"pipeline\") == 0) &&\n \t\t(n_tokens == 2) &&\n \t\t(strcmp(tokens[1], \"commit\") == 0)) {\n@@ -3031,6 +3197,14 @@ cli_process(char *in, char *out, size_t out_size, void *obj)\n \t\t\treturn;\n \t\t}\n \n+\t\tif ((n_tokens >= 5) &&\n+\t\t\t(strcmp(tokens[2], \"learner\") == 0) &&\n+\t\t\t(strcmp(tokens[4], \"default\") == 0)) {\n+\t\t\tcmd_pipeline_learner_default(tokens, n_tokens, out,\n+\t\t\t\tout_size, obj);\n+\t\t\treturn;\n+\t\t}\n+\n \t\tif ((n_tokens >= 3) &&\n \t\t\t(strcmp(tokens[2], \"commit\") == 0)) {\n \t\t\tcmd_pipeline_commit(tokens, n_tokens, out,\n", "prefixes": [ "V5", "3/4" ] }