Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99209/?format=api
https://patches.dpdk.org/api/patches/99209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210917150917.90892-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210917150917.90892-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210917150917.90892-1-bruce.richardson@intel.com", "date": "2021-09-17T15:09:17", "name": "app/test: fix memory autotests on FreeBSD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "40d5dc8753b8c4e8057795093b7f4b36bdc65c10", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210917150917.90892-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 19021, "url": "https://patches.dpdk.org/api/series/19021/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19021", "date": "2021-09-17T15:09:17", "name": "app/test: fix memory autotests on FreeBSD", "version": 1, "mbox": "https://patches.dpdk.org/series/19021/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99209/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/99209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 193D9A0C43;\n\tFri, 17 Sep 2021 17:09:33 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CBFDC410EC;\n\tFri, 17 Sep 2021 17:09:32 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 20110410EC\n for <dev@dpdk.org>; Fri, 17 Sep 2021 17:09:30 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Sep 2021 08:09:30 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.29])\n by fmsmga002.fm.intel.com with ESMTP; 17 Sep 2021 08:09:28 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10110\"; a=\"286498949\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"286498949\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"554669939\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, anatoly.burakov@intel.com,\n Brandon Lo <blo@iol.unh.edu>", "Date": "Fri, 17 Sep 2021 16:09:17 +0100", "Message-Id": "<20210917150917.90892-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] app/test: fix memory autotests on FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The memory autotests were failing on FreeBSD, due to an incorrect errno\nvariable being checked for ENOTSUP. The test checked \"errno\" while the\nDPDK API sets \"rte_errno\". Changing to check the right variable makes\nthe test behave properly.\n\nFixes: c3e35a0966b8 (\"test/mem: check segment fd API\")\nCc: anatoly.burakov@intel.com\n\nReported-by: Brandon Lo <blo@iol.unh.edu>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_memory.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_memory.c b/app/test/test_memory.c\nindex 7d5ae99bab..dbf6871e71 100644\n--- a/app/test/test_memory.c\n+++ b/app/test/test_memory.c\n@@ -6,6 +6,7 @@\n #include <stdint.h>\n \n #include <rte_eal.h>\n+#include <rte_errno.h>\n #include <rte_memory.h>\n #include <rte_common.h>\n #include <rte_memzone.h>\n@@ -53,7 +54,7 @@ check_seg_fds(const struct rte_memseg_list *msl, const struct rte_memseg *ms,\n \t\t/* ENOTSUP means segment is valid, but there is not support for\n \t\t * segment fd API (e.g. on FreeBSD).\n \t\t */\n-\t\tif (errno == ENOTSUP)\n+\t\tif (rte_errno == ENOTSUP)\n \t\t\treturn 1;\n \t\t/* all other errors are treated as failures */\n \t\treturn -1;\n", "prefixes": [] }{ "id": 99209, "url": "