Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99176/?format=api
{ "id": 99176, "url": "https://patches.dpdk.org/api/patches/99176/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210917140252.2999006-8-kevin.laatz@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210917140252.2999006-8-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210917140252.2999006-8-kevin.laatz@intel.com", "date": "2021-09-17T14:02:43", "name": "[v4,07/16] dma/idxd: add configure and info_get functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "124caeb5302fec4a100275ceb6066bd771baf34a", "submitter": { "id": 921, "url": "https://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210917140252.2999006-8-kevin.laatz@intel.com/mbox/", "series": [ { "id": 19018, "url": "https://patches.dpdk.org/api/series/19018/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19018", "date": "2021-09-17T14:02:36", "name": "add dmadev driver for idxd devices", "version": 4, "mbox": "https://patches.dpdk.org/series/19018/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99176/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99176/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60309A0C46;\n\tFri, 17 Sep 2021 16:04:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AC7374116B;\n\tFri, 17 Sep 2021 16:03:35 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id CF5FE41161\n for <dev@dpdk.org>; Fri, 17 Sep 2021 16:03:31 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Sep 2021 07:03:29 -0700", "from silpixa00401122.ir.intel.com ([10.55.128.10])\n by fmsmga006.fm.intel.com with ESMTP; 17 Sep 2021 07:03:25 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10109\"; a=\"219614917\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"219614917\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"699496245\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, fengchengwen@huawei.com, jerinj@marvell.com,\n conor.walsh@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Fri, 17 Sep 2021 14:02:43 +0000", "Message-Id": "<20210917140252.2999006-8-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210917140252.2999006-1-kevin.laatz@intel.com>", "References": "<20210827172048.558704-1-kevin.laatz@intel.com>\n <20210917140252.2999006-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 07/16] dma/idxd: add configure and info_get\n functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add functions for device configuration. The info_get function is included\nhere since it can be useful for checking successful configuration.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nReviewed-by: Conor Walsh <conor.walsh@intel.com>\n\n---\nv2:\n - fix reconfigure bug in idxd_vchan_setup()\n - add literal include comment for the docs to pick up\nv3:\n - fixes needed after changes from rebasing\n---\n app/test/test_dmadev.c | 2 +\n doc/guides/dmadevs/idxd.rst | 30 +++++++++++++\n drivers/dma/idxd/idxd_bus.c | 3 ++\n drivers/dma/idxd/idxd_common.c | 72 ++++++++++++++++++++++++++++++++\n drivers/dma/idxd/idxd_internal.h | 6 +++\n drivers/dma/idxd/idxd_pci.c | 3 ++\n 6 files changed, 116 insertions(+)", "diff": "diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c\nindex 98fcab67f3..5bbe4250e0 100644\n--- a/app/test/test_dmadev.c\n+++ b/app/test/test_dmadev.c\n@@ -739,6 +739,7 @@ test_dmadev_instance(uint16_t dev_id)\n {\n #define TEST_RINGSIZE 512\n #define CHECK_ERRS true\n+\t/* Setup of the dmadev device. 8< */\n \tstruct rte_dma_stats stats;\n \tstruct rte_dma_info info;\n \tconst struct rte_dma_conf conf = { .nb_vchans = 1};\n@@ -759,6 +760,7 @@ test_dmadev_instance(uint16_t dev_id)\n \n \tif (rte_dma_vchan_setup(dev_id, vchan, &qconf) < 0)\n \t\tERR_RETURN(\"Error with queue configuration\\n\");\n+\t/* >8 End of setup of the dmadev device. */\n \n \trte_dma_info_get(dev_id, &info);\n \tif (info.nb_vchans != 1)\ndiff --git a/doc/guides/dmadevs/idxd.rst b/doc/guides/dmadevs/idxd.rst\nindex ce33e2857a..abfa5be9ea 100644\n--- a/doc/guides/dmadevs/idxd.rst\n+++ b/doc/guides/dmadevs/idxd.rst\n@@ -120,3 +120,33 @@ use a subset of configured queues.\n Once probed successfully, irrespective of kernel driver, the device will appear as a ``dmadev``,\n that is a \"DMA device type\" inside DPDK, and can be accessed using APIs from the\n ``rte_dmadev`` library.\n+\n+Using IDXD DMAdev Devices\n+--------------------------\n+\n+To use the devices from an application, the dmadev API can be used.\n+\n+Getting Device Information\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Basic information about each dmadev device can be queried using the\n+``rte_dma_info_get()`` API. This will return basic device information such as\n+the ``rte_device`` structure, device capabilities and other device specific values.\n+\n+Device Configuration\n+~~~~~~~~~~~~~~~~~~~~~\n+\n+Configuring an IDXD dmadev device is done using the ``rte_dma_configure()`` and\n+``rte_dma_vchan_setup`` APIs. The configurations are passed to these APIs using\n+the ``rte_dma_conf`` and ``rte_dma_vchan_conf`` structures, respectively. For\n+example, these can be used to configure the number of ``vchans`` per device, the\n+ring size, etc. The ring size must be a power of two, between 64 and 4096.\n+\n+The following code shows how the device is configured in\n+``test_dmadev.c``:\n+\n+.. literalinclude:: ../../../app/test/test_dmadev.c\n+ :language: c\n+ :start-after: Setup of the dmadev device. 8<\n+ :end-before: >8 End of setup of the dmadev device.\n+ :dedent: 1\ndiff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dma/idxd/idxd_bus.c\nindex 3c0837ec52..b2acdac4f9 100644\n--- a/drivers/dma/idxd/idxd_bus.c\n+++ b/drivers/dma/idxd/idxd_bus.c\n@@ -96,6 +96,9 @@ idxd_dev_close(struct rte_dma_dev *dev)\n static const struct rte_dma_dev_ops idxd_bus_ops = {\n \t\t.dev_close = idxd_dev_close,\n \t\t.dev_dump = idxd_dump,\n+\t\t.dev_configure = idxd_configure,\n+\t\t.vchan_setup = idxd_vchan_setup,\n+\t\t.dev_info_get = idxd_info_get,\n };\n \n static void *\ndiff --git a/drivers/dma/idxd/idxd_common.c b/drivers/dma/idxd/idxd_common.c\nindex 45cde78e88..2c222708cf 100644\n--- a/drivers/dma/idxd/idxd_common.c\n+++ b/drivers/dma/idxd/idxd_common.c\n@@ -39,6 +39,78 @@ idxd_dump(const struct rte_dma_dev *dev, FILE *f)\n \treturn 0;\n }\n \n+int\n+idxd_info_get(const struct rte_dma_dev *dev, struct rte_dma_info *info, uint32_t size)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\n+\tif (size < sizeof(*info))\n+\t\treturn -EINVAL;\n+\n+\t*info = (struct rte_dma_info) {\n+\t\t\t.dev_capa = RTE_DMA_CAPA_MEM_TO_MEM |\n+\t\t\t\tRTE_DMA_CAPA_OPS_COPY | RTE_DMA_CAPA_OPS_FILL,\n+\t\t\t.max_vchans = 1,\n+\t\t\t.max_desc = 4096,\n+\t\t\t.min_desc = 64,\n+\t\t\t.nb_vchans = (idxd->desc_ring != NULL), /* returns 1 or 0 */\n+\t};\n+\tif (idxd->sva_support)\n+\t\tinfo->dev_capa |= RTE_DMA_CAPA_SVA;\n+\treturn 0;\n+}\n+\n+int\n+idxd_configure(struct rte_dma_dev *dev __rte_unused, const struct rte_dma_conf *dev_conf,\n+\t\tuint32_t conf_sz)\n+{\n+\tif (sizeof(struct rte_dma_conf) != conf_sz)\n+\t\treturn -EINVAL;\n+\n+\tif (dev_conf->nb_vchans != 1)\n+\t\treturn -EINVAL;\n+\treturn 0;\n+}\n+\n+int\n+idxd_vchan_setup(struct rte_dma_dev *dev, uint16_t vchan __rte_unused,\n+\t\tconst struct rte_dma_vchan_conf *qconf, uint32_t qconf_sz)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tuint16_t max_desc = qconf->nb_desc;\n+\n+\tif (sizeof(struct rte_dma_vchan_conf) != qconf_sz)\n+\t\treturn -EINVAL;\n+\n+\tidxd->qcfg = *qconf;\n+\n+\tif (!rte_is_power_of_2(max_desc))\n+\t\tmax_desc = rte_align32pow2(max_desc);\n+\tIDXD_PMD_DEBUG(\"DMA dev %u using %u descriptors\", dev->data->dev_id, max_desc);\n+\tidxd->desc_ring_mask = max_desc - 1;\n+\tidxd->qcfg.nb_desc = max_desc;\n+\n+\t/* in case we are reconfiguring a device, free any existing memory */\n+\trte_free(idxd->desc_ring);\n+\n+\t/* allocate the descriptor ring at 2x size as batches can't wrap */\n+\tidxd->desc_ring = rte_zmalloc(NULL, sizeof(*idxd->desc_ring) * max_desc * 2, 0);\n+\tif (idxd->desc_ring == NULL)\n+\t\treturn -ENOMEM;\n+\tidxd->desc_iova = rte_mem_virt2iova(idxd->desc_ring);\n+\n+\tidxd->batch_idx_read = 0;\n+\tidxd->batch_idx_write = 0;\n+\tidxd->batch_start = 0;\n+\tidxd->batch_size = 0;\n+\tidxd->ids_returned = 0;\n+\tidxd->ids_avail = 0;\n+\n+\tmemset(idxd->batch_comp_ring, 0, sizeof(*idxd->batch_comp_ring) *\n+\t\t\t(idxd->max_batches + 1));\n+\treturn 0;\n+}\n+\n int\n idxd_dmadev_create(const char *name, struct rte_device *dev,\n \t\t const struct idxd_dmadev *base_idxd,\ndiff --git a/drivers/dma/idxd/idxd_internal.h b/drivers/dma/idxd/idxd_internal.h\nindex 99c8e04302..fdd018ca35 100644\n--- a/drivers/dma/idxd/idxd_internal.h\n+++ b/drivers/dma/idxd/idxd_internal.h\n@@ -82,5 +82,11 @@ struct idxd_dmadev {\n int idxd_dmadev_create(const char *name, struct rte_device *dev,\n \t\tconst struct idxd_dmadev *base_idxd, const struct rte_dma_dev_ops *ops);\n int idxd_dump(const struct rte_dma_dev *dev, FILE *f);\n+int idxd_configure(struct rte_dma_dev *dev, const struct rte_dma_conf *dev_conf,\n+\t\tuint32_t conf_sz);\n+int idxd_vchan_setup(struct rte_dma_dev *dev, uint16_t vchan,\n+\t\tconst struct rte_dma_vchan_conf *qconf, uint32_t qconf_sz);\n+int idxd_info_get(const struct rte_dma_dev *dev, struct rte_dma_info *dev_info,\n+\t\tuint32_t size);\n \n #endif /* _IDXD_INTERNAL_H_ */\ndiff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 33cf76adfb..0216ab80d9 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -61,6 +61,9 @@ idxd_is_wq_enabled(struct idxd_dmadev *idxd)\n \n static const struct rte_dma_dev_ops idxd_pci_ops = {\n \t.dev_dump = idxd_dump,\n+\t.dev_configure = idxd_configure,\n+\t.vchan_setup = idxd_vchan_setup,\n+\t.dev_info_get = idxd_info_get,\n };\n \n /* each portal uses 4 x 4k pages */\n", "prefixes": [ "v4", "07/16" ] }