Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99175/?format=api
{ "id": 99175, "url": "https://patches.dpdk.org/api/patches/99175/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210917140252.2999006-9-kevin.laatz@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210917140252.2999006-9-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210917140252.2999006-9-kevin.laatz@intel.com", "date": "2021-09-17T14:02:44", "name": "[v4,08/16] dma/idxd: add start and stop functions for pci devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "817352345cd8fd7097f54938dd53c57982420a64", "submitter": { "id": 921, "url": "https://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210917140252.2999006-9-kevin.laatz@intel.com/mbox/", "series": [ { "id": 19018, "url": "https://patches.dpdk.org/api/series/19018/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19018", "date": "2021-09-17T14:02:36", "name": "add dmadev driver for idxd devices", "version": 4, "mbox": "https://patches.dpdk.org/series/19018/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99175/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B2A66A0C46;\n\tFri, 17 Sep 2021 16:04:09 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4A70E41161;\n\tFri, 17 Sep 2021 16:03:33 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id E80D341163\n for <dev@dpdk.org>; Fri, 17 Sep 2021 16:03:30 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Sep 2021 07:03:29 -0700", "from silpixa00401122.ir.intel.com ([10.55.128.10])\n by fmsmga006.fm.intel.com with ESMTP; 17 Sep 2021 07:03:27 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10109\"; a=\"219614912\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"219614912\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"699496251\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, fengchengwen@huawei.com, jerinj@marvell.com,\n conor.walsh@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Fri, 17 Sep 2021 14:02:44 +0000", "Message-Id": "<20210917140252.2999006-9-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210917140252.2999006-1-kevin.laatz@intel.com>", "References": "<20210827172048.558704-1-kevin.laatz@intel.com>\n <20210917140252.2999006-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 08/16] dma/idxd: add start and stop functions\n for pci devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add device start/stop functions for DSA devices bound to vfio. For devices\nbound to the IDXD kernel driver, these are not required since the IDXD\nkernel driver takes care of this.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nReviewed-by: Conor Walsh <conor.walsh@intel.com>\n---\n doc/guides/dmadevs/idxd.rst | 3 +++\n drivers/dma/idxd/idxd_pci.c | 52 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 55 insertions(+)", "diff": "diff --git a/doc/guides/dmadevs/idxd.rst b/doc/guides/dmadevs/idxd.rst\nindex abfa5be9ea..a603c5dd22 100644\n--- a/doc/guides/dmadevs/idxd.rst\n+++ b/doc/guides/dmadevs/idxd.rst\n@@ -150,3 +150,6 @@ The following code shows how the device is configured in\n :start-after: Setup of the dmadev device. 8<\n :end-before: >8 End of setup of the dmadev device.\n :dedent: 1\n+\n+Once configured, the device can then be made ready for use by calling the\n+``rte_dma_start()`` API.\ndiff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 0216ab80d9..cfb64ce220 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -59,11 +59,63 @@ idxd_is_wq_enabled(struct idxd_dmadev *idxd)\n \treturn ((state >> WQ_STATE_SHIFT) & WQ_STATE_MASK) == 0x1;\n }\n \n+static int\n+idxd_pci_dev_stop(struct rte_dma_dev *dev)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tuint8_t err_code;\n+\n+\tif (!idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_ERR(\"Work queue %d already disabled\", idxd->qid);\n+\t\treturn -EALREADY;\n+\t}\n+\n+\terr_code = idxd_pci_dev_command(idxd, idxd_disable_wq);\n+\tif (err_code || idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_ERR(\"Failed disabling work queue %d, error code: %#x\",\n+\t\t\t\tidxd->qid, err_code);\n+\t\treturn -err_code;\n+\t}\n+\tIDXD_PMD_DEBUG(\"Work queue %d disabled OK\", idxd->qid);\n+\n+\treturn 0;\n+}\n+\n+static int\n+idxd_pci_dev_start(struct rte_dma_dev *dev)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tuint8_t err_code;\n+\n+\tif (idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_WARN(\"WQ %d already enabled\", idxd->qid);\n+\t\treturn 0;\n+\t}\n+\n+\tif (idxd->desc_ring == NULL) {\n+\t\tIDXD_PMD_ERR(\"WQ %d has not been fully configured\", idxd->qid);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\terr_code = idxd_pci_dev_command(idxd, idxd_enable_wq);\n+\tif (err_code || !idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_ERR(\"Failed enabling work queue %d, error code: %#x\",\n+\t\t\t\tidxd->qid, err_code);\n+\t\treturn err_code == 0 ? -1 : err_code;\n+\t}\n+\n+\tIDXD_PMD_DEBUG(\"Work queue %d enabled OK\", idxd->qid);\n+\n+\treturn 0;\n+}\n+\n static const struct rte_dma_dev_ops idxd_pci_ops = {\n \t.dev_dump = idxd_dump,\n \t.dev_configure = idxd_configure,\n \t.vchan_setup = idxd_vchan_setup,\n \t.dev_info_get = idxd_info_get,\n+\t.dev_start = idxd_pci_dev_start,\n+\t.dev_stop = idxd_pci_dev_stop,\n };\n \n /* each portal uses 4 x 4k pages */\n", "prefixes": [ "v4", "08/16" ] }