Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99169/?format=api
{ "id": 99169, "url": "https://patches.dpdk.org/api/patches/99169/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210917140252.2999006-2-kevin.laatz@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210917140252.2999006-2-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210917140252.2999006-2-kevin.laatz@intel.com", "date": "2021-09-17T14:02:37", "name": "[v4,01/16] raw/ioat: only build if dmadev not present", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f647b6e77da23b2472f5f1d9d508c555a6e2b579", "submitter": { "id": 921, "url": "https://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210917140252.2999006-2-kevin.laatz@intel.com/mbox/", "series": [ { "id": 19018, "url": "https://patches.dpdk.org/api/series/19018/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19018", "date": "2021-09-17T14:02:36", "name": "add dmadev driver for idxd devices", "version": 4, "mbox": "https://patches.dpdk.org/series/19018/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99169/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE8ECA0C46;\n\tFri, 17 Sep 2021 16:03:26 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5800941120;\n\tFri, 17 Sep 2021 16:03:20 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 2D3FB407FF\n for <dev@dpdk.org>; Fri, 17 Sep 2021 16:03:17 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Sep 2021 07:03:17 -0700", "from silpixa00401122.ir.intel.com ([10.55.128.10])\n by fmsmga006.fm.intel.com with ESMTP; 17 Sep 2021 07:03:15 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10109\"; a=\"219614819\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"219614819\"", "E=Sophos;i=\"5.85,301,1624345200\"; d=\"scan'208\";a=\"699496200\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, fengchengwen@huawei.com, jerinj@marvell.com,\n conor.walsh@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Fri, 17 Sep 2021 14:02:37 +0000", "Message-Id": "<20210917140252.2999006-2-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210917140252.2999006-1-kevin.laatz@intel.com>", "References": "<20210827172048.558704-1-kevin.laatz@intel.com>\n <20210917140252.2999006-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 01/16] raw/ioat: only build if dmadev not\n present", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nOnly build the rawdev IDXD/IOAT drivers if the dmadev drivers are not\npresent.\n\nA not is also added to the documentation to inform users of this change.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nReviewed-by: Conor Walsh <conor.walsh@intel.com>\n\n---\nv4:\n - Fix build issue\n - Add note in raw documentation to outline this change\n---\n doc/guides/rawdevs/ioat.rst | 7 +++++++\n drivers/meson.build | 2 +-\n drivers/raw/ioat/meson.build | 23 ++++++++++++++++++++---\n 3 files changed, 28 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst\nindex a28e909935..4fc327f1a4 100644\n--- a/doc/guides/rawdevs/ioat.rst\n+++ b/doc/guides/rawdevs/ioat.rst\n@@ -34,6 +34,13 @@ Compilation\n For builds using ``meson`` and ``ninja``, the driver will be built when the target platform is x86-based.\n No additional compilation steps are necessary.\n \n+.. note::\n+ Since the addition of the DMAdev library, the ``ioat`` and ``idxd`` parts of this driver\n+ will only be built if their ``DMAdev`` counterparts are not built. The following can be used\n+ to disable the ``DMAdev`` drivers, if the raw drivers are to be used instead::\n+\n+ $ meson -Ddisable_drivers=dma/* <build_dir>\n+\n Device Setup\n -------------\n \ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex b7d680868a..27ff10a9fc 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -10,6 +10,7 @@ subdirs = [\n 'common/qat', # depends on bus.\n 'common/sfc_efx', # depends on bus.\n 'mempool', # depends on common and bus.\n+ 'dma', # depends on common and bus.\n 'net', # depends on common, bus, mempool\n 'raw', # depends on common, bus and net.\n 'crypto', # depends on common, bus and mempool (net in future).\n@@ -18,7 +19,6 @@ subdirs = [\n 'vdpa', # depends on common, bus and mempool.\n 'event', # depends on common, bus, mempool and net.\n 'baseband', # depends on common and bus.\n- 'dma', # depends on common and bus.\n ]\n \n if meson.is_cross_build()\ndiff --git a/drivers/raw/ioat/meson.build b/drivers/raw/ioat/meson.build\nindex 0e81cb5951..9be9d8cc65 100644\n--- a/drivers/raw/ioat/meson.build\n+++ b/drivers/raw/ioat/meson.build\n@@ -2,14 +2,31 @@\n # Copyright 2019 Intel Corporation\n \n build = dpdk_conf.has('RTE_ARCH_X86')\n+# only use ioat rawdev driver if we don't have the equivalent dmadev ones\n+if dpdk_conf.has('RTE_DMA_IDXD') and dpdk_conf.has('RTE_DMA_IOAT')\n+ build = false\n+ subdir_done()\n+endif\n+\n reason = 'only supported on x86'\n sources = files(\n- 'idxd_bus.c',\n- 'idxd_pci.c',\n 'ioat_common.c',\n- 'ioat_rawdev.c',\n 'ioat_rawdev_test.c',\n )\n+\n+if not dpdk_conf.has('RTE_DMA_IDXD')\n+ sources += files(\n+ 'idxd_bus.c',\n+ 'idxd_pci.c',\n+ )\n+endif\n+\n+if not dpdk_conf.has('RTE_DMA_IOAT')\n+ sources += files (\n+ 'ioat_rawdev.c',\n+ )\n+endif\n+\n deps += ['bus_pci', 'mbuf', 'rawdev']\n headers = files(\n 'rte_ioat_rawdev.h',\n", "prefixes": [ "v4", "01/16" ] }