Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99078/?format=api
{ "id": 99078, "url": "https://patches.dpdk.org/api/patches/99078/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210917082313.21934-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210917082313.21934-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210917082313.21934-2-david.marchand@redhat.com", "date": "2021-09-17T08:23:11", "name": "[1/3] bus/vmbus: fix leak on device scan", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d6d2cccae7e383ddd8d4441b0644aee86359fd4d", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210917082313.21934-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 18997, "url": "https://patches.dpdk.org/api/series/18997/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18997", "date": "2021-09-17T08:23:10", "name": "Experiment ASAN in GHA", "version": 1, "mbox": "https://patches.dpdk.org/series/18997/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99078/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0BB51A0C46;\n\tFri, 17 Sep 2021 10:23:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EBCC7410EA;\n\tFri, 17 Sep 2021 10:23:35 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id B16C540689\n for <dev@dpdk.org>; Fri, 17 Sep 2021 10:23:34 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-340-vfbh-I6kOXe24Aabw21cjw-1; Fri, 17 Sep 2021 04:23:31 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D5B0801B3D;\n Fri, 17 Sep 2021 08:23:30 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.147])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 6EDEF60C9F;\n Fri, 17 Sep 2021 08:23:28 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1631867014;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=z/j6TCIJoRrEZSdba11MJ+yi7uqX1wgSiOz78FEsToA=;\n b=MDayo6nzqgjqY8XrVAA4XWqkNkaShnmiuk7IjROw5fDYw82Q18qJtNWdQ/YR7GO/hOe4z4\n SrSminU+jSrVbJddWKAzsyZwVZ16SJM8SL56wNJbnr2JIN/2ocOW0pa62/Fe9IB67Q3DIm\n E/JDe5wORMhVn3OVYQsvt36nMKJNRC0=", "X-MC-Unique": "vfbh-I6kOXe24Aabw21cjw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "aconole@redhat.com, zhihongx.peng@intel.com, stable@dpdk.org,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Date": "Fri, 17 Sep 2021 10:23:11 +0200", "Message-Id": "<20210917082313.21934-2-david.marchand@redhat.com>", "In-Reply-To": "<20210917082313.21934-1-david.marchand@redhat.com>", "References": "<20210917082313.21934-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Caught running ASAN.\n\nThe device name is leaked on scan.\nrte_device name field being a const, use the private vmbus struct to\nstore the device name and point at it.\n\nFixes: 831dba47bd36 (\"bus/vmbus: add Hyper-V virtual bus support\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/bus/vmbus/linux/vmbus_bus.c | 5 ++++-\n drivers/bus/vmbus/rte_bus_vmbus.h | 1 +\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c b/drivers/bus/vmbus/linux/vmbus_bus.c\nindex 3c924eee14..d8eb07d398 100644\n--- a/drivers/bus/vmbus/linux/vmbus_bus.c\n+++ b/drivers/bus/vmbus/linux/vmbus_bus.c\n@@ -242,7 +242,7 @@ vmbus_scan_one(const char *name)\n \t\treturn -1;\n \n \tdev->device.bus = &rte_vmbus_bus.bus;\n-\tdev->device.name = strdup(name);\n+\tdev->device.name = dev->name = strdup(name);\n \tif (!dev->device.name)\n \t\tgoto error;\n \n@@ -261,6 +261,7 @@ vmbus_scan_one(const char *name)\n \n \t/* skip non-network devices */\n \tif (rte_uuid_compare(dev->class_id, vmbus_nic_uuid) != 0) {\n+\t\tfree(dev->name);\n \t\tfree(dev);\n \t\treturn 0;\n \t}\n@@ -312,6 +313,7 @@ vmbus_scan_one(const char *name)\n \t\t} else { /* already registered */\n \t\t\tVMBUS_LOG(NOTICE,\n \t\t\t\t\"%s already registered\", name);\n+\t\t\tfree(dev->name);\n \t\t\tfree(dev);\n \t\t}\n \t\treturn 0;\n@@ -322,6 +324,7 @@ vmbus_scan_one(const char *name)\n error:\n \tVMBUS_LOG(DEBUG, \"failed\");\n \n+\tfree(dev->name);\n \tfree(dev);\n \treturn -1;\n }\ndiff --git a/drivers/bus/vmbus/rte_bus_vmbus.h b/drivers/bus/vmbus/rte_bus_vmbus.h\nindex 4cf73ce815..438eb481fc 100644\n--- a/drivers/bus/vmbus/rte_bus_vmbus.h\n+++ b/drivers/bus/vmbus/rte_bus_vmbus.h\n@@ -65,6 +65,7 @@ struct rte_vmbus_device {\n \tTAILQ_ENTRY(rte_vmbus_device) next; /**< Next probed VMBUS device */\n \tconst struct rte_vmbus_driver *driver; /**< Associated driver */\n \tstruct rte_device device; /**< Inherit core device */\n+\tchar *name; /**< Device name */\n \trte_uuid_t device_id;\t\t /**< VMBUS device id */\n \trte_uuid_t class_id;\t\t /**< VMBUS device type */\n \tuint32_t relid;\t\t\t /**< id for primary */\n", "prefixes": [ "1/3" ] }