Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98937/?format=api
{ "id": 98937, "url": "https://patches.dpdk.org/api/patches/98937/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210915145447.28481-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210915145447.28481-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210915145447.28481-1-david.marchand@redhat.com", "date": "2021-09-15T14:54:47", "name": "vhost: rework RARP packet injection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9521f8fe938f09b8c47422e14b9dc2d5e13c03d2", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210915145447.28481-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 18939, "url": "https://patches.dpdk.org/api/series/18939/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18939", "date": "2021-09-15T14:54:47", "name": "vhost: rework RARP packet injection", "version": 1, "mbox": "https://patches.dpdk.org/series/18939/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/98937/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/98937/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B568A0C41;\n\tWed, 15 Sep 2021 16:55:05 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 21E2D4068F;\n\tWed, 15 Sep 2021 16:55:05 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id E15794014F\n for <dev@dpdk.org>; Wed, 15 Sep 2021 16:55:03 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-545-aeyCedoFMky3bp673PiC8A-1; Wed, 15 Sep 2021 10:55:01 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6CEF10168C0;\n Wed, 15 Sep 2021 14:55:00 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.147])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B6B45781EE;\n Wed, 15 Sep 2021 14:54:56 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1631717703;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=YVGRISWxMJzO8qQJkmqY6EuGOy1v9B/le76ngZyXxyc=;\n b=Qn/hMt4BIVS8S+iVQwAr5+3zQbTLCBy5QRWK3u09BMKgsWYO/CoCyvGK7kBNEtIta5O+uN\n R/jVO9/s1xRzm/iyhGjpiU4DsrX9zTZ1QrjNZhlY/s+N8KR3eqKkpc4N1rOlPlNU+jjJ3B\n 3eicES73mlbEQn7734F/LDTGqenPcWA=", "X-MC-Unique": "aeyCedoFMky3bp673PiC8A-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Date": "Wed, 15 Sep 2021 16:54:47 +0200", "Message-Id": "<20210915145447.28481-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH] vhost: rework RARP packet injection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Caught by code review, this copy is unnecessary.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/vhost/virtio_net.c | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex 8549afbbe1..1d30ad0fd9 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -3364,6 +3364,8 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \t\t\tcount = 0;\n \t\t\tgoto out;\n \t\t}\n+\t\tpkts[0] = rarp_mbuf;\n+\t\tpkts++;\n \t\tcount -= 1;\n \t}\n \n@@ -3386,15 +3388,8 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n out_access_unlock:\n \trte_spinlock_unlock(&vq->access_lock);\n \n-\tif (unlikely(rarp_mbuf != NULL)) {\n-\t\t/*\n-\t\t * Inject it to the head of \"pkts\" array, so that switch's mac\n-\t\t * learning table will get updated first.\n-\t\t */\n-\t\tmemmove(&pkts[1], pkts, count * sizeof(struct rte_mbuf *));\n-\t\tpkts[0] = rarp_mbuf;\n+\tif (unlikely(rarp_mbuf != NULL))\n \t\tcount += 1;\n-\t}\n \n \treturn count;\n }\n", "prefixes": [] }