Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9873/?format=api
{ "id": 9873, "url": "https://patches.dpdk.org/api/patches/9873/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1452825653-623-6-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1452825653-623-6-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1452825653-623-6-git-send-email-helin.zhang@intel.com", "date": "2016-01-15T02:40:29", "name": "[dpdk-dev,05/29] i40e/base: Limit DCB FW version checks to XL710/X710 devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "05717b18880d00297cccc1c0613b6e6fe1783320", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1452825653-623-6-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9873/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9873/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E5D7B9190;\n\tFri, 15 Jan 2016 03:41:15 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id A713F8E8F\n\tfor <dev@dpdk.org>; Fri, 15 Jan 2016 03:41:13 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 14 Jan 2016 18:41:12 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 14 Jan 2016 18:41:11 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u0F2f9pW002204;\n\tFri, 15 Jan 2016 10:41:09 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u0F2f6Ew000694; Fri, 15 Jan 2016 10:41:08 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u0F2f6Hm000690; \n\tFri, 15 Jan 2016 10:41:06 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,297,1449561600\"; d=\"scan'208\";a=\"727383294\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 15 Jan 2016 10:40:29 +0800", "Message-Id": "<1452825653-623-6-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1452825653-623-1-git-send-email-helin.zhang@intel.com>", "References": "<1452825653-623-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 05/29] i40e/base: Limit DCB FW version checks to\n\tXL710/X710 devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "XL710/X710 devices requires FW version checks to properly handle\nDCB configurations from the FW while other devices (e.g. X722)\ndo not, so limit these checks to XL710/X710 only.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_dcb.c | 34 +++++++++++++++++++++-------------\n 1 file changed, 21 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_dcb.c b/drivers/net/i40e/base/i40e_dcb.c\nindex d71387f..26c344f 100644\n--- a/drivers/net/i40e/base/i40e_dcb.c\n+++ b/drivers/net/i40e/base/i40e_dcb.c\n@@ -387,32 +387,40 @@ static void i40e_parse_cee_app_tlv(struct i40e_cee_feat_tlv *tlv,\n {\n \tu16 length, typelength, offset = 0;\n \tstruct i40e_cee_app_prio *app;\n-\tu8 i, up, selector;\n+\tu8 i;\n \n \ttypelength = I40E_NTOHS(tlv->hdr.typelen);\n \tlength = (u16)((typelength & I40E_LLDP_TLV_LEN_MASK) >>\n \t\t I40E_LLDP_TLV_LEN_SHIFT);\n \n-\tdcbcfg->numapps = length/sizeof(*app);\n+\tdcbcfg->numapps = length / sizeof(*app);\n \tif (!dcbcfg->numapps)\n \t\treturn;\n \n \tfor (i = 0; i < dcbcfg->numapps; i++) {\n+\t\tu8 up, selector;\n+\n \t\tapp = (struct i40e_cee_app_prio *)(tlv->tlvinfo + offset);\n \t\tfor (up = 0; up < I40E_MAX_USER_PRIORITY; up++) {\n \t\t\tif (app->prio_map & BIT(up))\n \t\t\t\tbreak;\n \t\t}\n \t\tdcbcfg->app[i].priority = up;\n+\n \t\t/* Get Selector from lower 2 bits, and convert to IEEE */\n \t\tselector = (app->upper_oui_sel & I40E_CEE_APP_SELECTOR_MASK);\n-\t\tif (selector == I40E_CEE_APP_SEL_ETHTYPE)\n+\t\tswitch (selector) {\n+\t\tcase I40E_CEE_APP_SEL_ETHTYPE:\n \t\t\tdcbcfg->app[i].selector = I40E_APP_SEL_ETHTYPE;\n-\t\telse if (selector == I40E_CEE_APP_SEL_TCPIP)\n+\t\t\tbreak;\n+\t\tcase I40E_CEE_APP_SEL_TCPIP:\n \t\t\tdcbcfg->app[i].selector = I40E_APP_SEL_TCPIP;\n-\t\telse\n+\t\t\tbreak;\n+\t\tdefault:\n \t\t\t/* Keep selector as it is for unknown types */\n \t\t\tdcbcfg->app[i].selector = selector;\n+\t\t}\n+\n \t\tdcbcfg->app[i].protocolid = I40E_NTOHS(app->protocol);\n \t\t/* Move to next app */\n \t\toffset += sizeof(*app);\n@@ -822,13 +830,15 @@ enum i40e_status_code i40e_get_dcb_config(struct i40e_hw *hw)\n \tstruct i40e_aqc_get_cee_dcb_cfg_resp cee_cfg;\n \tstruct i40e_aqc_get_cee_dcb_cfg_v1_resp cee_v1_cfg;\n \n-\t/* If Firmware version < v4.33 IEEE only */\n-\tif (((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver < 33)) ||\n-\t (hw->aq.fw_maj_ver < 4))\n+\t/* If Firmware version < v4.33 on X710/XL710, IEEE only */\n+\tif ((hw->mac.type == I40E_MAC_XL710) &&\n+\t (((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver < 33)) ||\n+\t (hw->aq.fw_maj_ver < 4)))\n \t\treturn i40e_get_ieee_dcb_config(hw);\n \n-\t/* If Firmware version == v4.33 use old CEE struct */\n-\tif ((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver == 33)) {\n+\t/* If Firmware version == v4.33 on X710/XL710, use old CEE struct */\n+\tif ((hw->mac.type == I40E_MAC_XL710) &&\n+\t ((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver == 33))) {\n \t\tret = i40e_aq_get_cee_dcb_config(hw, &cee_v1_cfg,\n \t\t\t\t\t\t sizeof(cee_v1_cfg), NULL);\n \t\tif (ret == I40E_SUCCESS) {\n@@ -1240,14 +1250,12 @@ enum i40e_status_code i40e_dcb_config_to_lldp(u8 *lldpmib, u16 *miblen,\n \tu16 length, offset = 0, tlvid = I40E_TLV_ID_START;\n \tenum i40e_status_code ret = I40E_SUCCESS;\n \tstruct i40e_lldp_org_tlv *tlv;\n-\tu16 type, typelength;\n+\tu16 typelength;\n \n \ttlv = (struct i40e_lldp_org_tlv *)lldpmib;\n \twhile (1) {\n \t\ti40e_add_dcb_tlv(tlv, dcbcfg, tlvid++);\n \t\ttypelength = I40E_NTOHS(tlv->typelength);\n-\t\ttype = (u16)((typelength & I40E_LLDP_TLV_TYPE_MASK) >>\n-\t\t\t\tI40E_LLDP_TLV_TYPE_SHIFT);\n \t\tlength = (u16)((typelength & I40E_LLDP_TLV_LEN_MASK) >>\n \t\t\t\tI40E_LLDP_TLV_LEN_SHIFT);\n \t\tif (length)\n", "prefixes": [ "dpdk-dev", "05/29" ] }