Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98147/?format=api
{ "id": 98147, "url": "https://patches.dpdk.org/api/patches/98147/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210907083953.8948-7-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210907083953.8948-7-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210907083953.8948-7-hemant.agrawal@nxp.com", "date": "2021-09-07T08:39:50", "name": "[v3,07/10] common/dpaax: enhance caamflib with inline keys", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5de1e33a3036de582398fbd5fb0706b0ff45aa9e", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210907083953.8948-7-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 18728, "url": "https://patches.dpdk.org/api/series/18728/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18728", "date": "2021-09-07T08:39:44", "name": "[v3,01/10] crypto/dpaa_sec: support DES-CBC", "version": 3, "mbox": "https://patches.dpdk.org/series/18728/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/98147/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/98147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0CB81A0C46;\n\tTue, 7 Sep 2021 10:45:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1E6D941150;\n\tTue, 7 Sep 2021 10:44:46 +0200 (CEST)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr70089.outbound.protection.outlook.com [40.107.7.89])\n by mails.dpdk.org (Postfix) with ESMTP id 0A1DC41150\n for <dev@dpdk.org>; Tue, 7 Sep 2021 10:44:43 +0200 (CEST)", "from DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15)\n by DU2PR04MB8949.eurprd04.prod.outlook.com (2603:10a6:10:2e0::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep\n 2021 08:44:43 +0000", "from DU2PR04MB8630.eurprd04.prod.outlook.com\n ([fe80::945d:e362:712d:1b80]) by DU2PR04MB8630.eurprd04.prod.outlook.com\n ([fe80::945d:e362:712d:1b80%4]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021\n 08:44:43 +0000", "from dpdk-xeon.ap.freescale.net (92.120.0.67) by\n SGBP274CA0024.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::36) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4478.20 via Frontend Transport; Tue, 7 Sep 2021 08:44:41 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=b4A9lNIds7hsS7HO7K1AVmQ4quSA7OdTERFW97TbNyMM8sL7hWFoTfF47PBy3IX3IQLt1tgUmdo+aaL0aH9vbG62YJ+iMFPT15w0t2xq2V0pInakKfdXN3WFoR3pgTrzN8OrWgIDbi5FHYQEyLTWyemE14/ipHcEBeuHjM4hfUjlHU1Bw6krz+6xsx1IFSgp3rX3PxIJBh4Q0gXU8v8PzbBCMdYnXm4h+WukyuXkq30BSKJw+/JurAa0zkU58H0oqfRW4Ba9YcAt4UtALnGt4fF1xEdH4Zdz8aOB4Qjv4We8ytyFpMxwyNUD+aGT6434tRNoKSeoeGmKOP/RJkbAdQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n bh=Yl1I/8ZX3chRpyMeMXT10jeAlhOt6BgA+SkvQ5QWsXA=;\n b=gLptQ9p+x+nVmdw1R9p0qkqGatwi8FvXobfDcDrYHbcZGnP6cMJpWk7OHqjBoMxl+n2vkm2Q2x9WQLz8dQVgXAKRIN9kCH+o5Zc1/FqeruUrcVzyEabf/O5AaA3X7EdFU6PWirGTak24T0bO+DWXh1ac0uqgV6JGS7pS5YeGWno3Uw1HcqdfkmodIJPHinnw1PRn43w4dTsRHKp3wceZNCkGYl1b6HyfpKPA/PKUBVGOsB3oIQsRfAsm6caE7tycctekHBKPmVnHdaziDy9kmCfksIpFFe06vSxZDV7bYZkmOyKKaMkEfBUbTLor/l5WkpTp4EQEqSbugZx3/roPMA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Yl1I/8ZX3chRpyMeMXT10jeAlhOt6BgA+SkvQ5QWsXA=;\n b=q+eAYeVPMkfjpORORri/0VuAuTXThjIv76KlZAXHq+4fz+KwGe6iNgM4LBG5/NN4+ZfJVB541UUowcYOUCbFIt9N+1yUy87SnaLIpLWzCUIYJX6oUAm0jXlewiYhtia8zl0VcBGYXOrAaoMHA5j0eg4SaIo5cL5O5gIsGxsHKHQ=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=nxp.com;", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\tgakhil@marvell.com", "Cc": "Franck LENORMAND <franck.lenormand@nxp.com>", "Date": "Tue, 7 Sep 2021 14:09:50 +0530", "Message-Id": "<20210907083953.8948-7-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210907083953.8948-1-hemant.agrawal@nxp.com>", "References": "<20210825081837.23830-1-hemant.agrawal@nxp.com>\n <20210907083953.8948-1-hemant.agrawal@nxp.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "SGBP274CA0024.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::36)\n To DU2PR04MB8630.eurprd04.prod.outlook.com\n (2603:10a6:10:2dd::15)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2d604fae-4594-4462-4dc0-08d971dbbcb8", "X-MS-TrafficTypeDiagnostic": "DU2PR04MB8949:", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DU2PR04MB894996781623E26EAE47466F89D39@DU2PR04MB8949.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:9508;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n XuecXE1xjAvWfOAF3Hm5dnb4WrC3uY41tJd0MAEl72tgIaUnTsY+Z9cxGXFiLYvvyDR3yCsXRPMb4jh4WSRo6ziaw4iapHsgyYlHdAnh9762MCeZe5pYawmLFlIC/9JZ/m1EhVBtPs3RymGWNIlpL9c/5zuX9+m3wSRGFZi1Vouym4PEon7oym7JjWI/VVorXvKSlwEuqDegK5xb+6iE9kKjVdho4HzlEZL5LpZmq5H8/k1ht8aXUs3TaJwujijzed3ONeXZN3nItYEeaNDF85wdUUnyM3eiUC3jpMqXFco5TrPtS518B0Pjl++tlYCrHblZC4tKa4YtwWTgvgqu0rPz3Tnu3BzRSRQpkp5bFY+gAF5HgCpbUUo1ECeTheyo6/WgOGDs8hPOBQ7us6nF/mtU9bum4ifKr2heO57pUS+bfEYRarb2IiHwlEtVsI3WE/cdei2Fzvn6ntr2Zg0cMM5KE+47VVU4x0aVfB4HOknn9I61pXuH6Dkj0AQjde27A+Yp6SO81X44eyTAIAtRdPMV7zgwt3St5waNTDPnAEJOkUWfhZWfeWpBetVXTfuXUR7H2rO29YQD1QE82qCVSH8b8LVhcno3AWGufxjzb4OHN6a9PGFp9iX3IAuMf3NridgVRWiTcl+Mqch3u6srKsphC1EzmQGDdKsoOpEjO0+oCD9gIWQwaFn2tHlp+12KFDEBOenUpZMJbGqYi+QEeA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DU2PR04MB8630.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(86362001)(36756003)(38100700002)(38350700002)(316002)(44832011)(52116002)(6506007)(6512007)(186003)(2906002)(956004)(6666004)(5660300002)(8936002)(8676002)(6486002)(2616005)(26005)(1076003)(83380400001)(4326008)(66946007)(478600001)(66556008)(66476007);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n rtx28NNxFBTfhDa0FIdL6+xAzphys0MZ2DoG4Hw86CXey2I0OPteLbhjN7aKPAmfOaXUXH6auM99F1Yk5BHBPYqt99mne2zUK1lFYZCgN1euMJ2aNIt0e9RrQn4HltX7yg9wvQPzCZ95tVrh0E4uEWJ3bY4/HHwtHgfbmKmoJINsOkp1Xk9HyM75JsmJkZrsf809J13uG99/yjFygwtSGSWf6fOde0HAI1/D9WWm5Gjg0RvTmdq9vmFtByp8NPnhkTQMOS+tXheBAKfTEnnE9ZfLaniZHPZVhGldUQ68r5kGoiwH8y/5EMI2JDX5JD7UGKQhRL0AAFyKx4mAlpQujqaiEo2ff8tVjVSVYK73j4qXTsZhjIw0iJ/lla/YQEtQNcsfqnHJqVDfNFVZnIaGZ2dhT+qn0y3+bxMAelTE/8StUX5PNfIP6xink7FWQf4IMQt8uPb1w8/wGuymkkqv7Ox+a/pnwrkD6BCC5lbvnCWQsj4d3l3kX4oh4biC2Le50214oqaPjHW1nb7Z3eIe4SQTRmyDBOC+gCpT9llghX56N14CYIMYm1iJND7rZFGEXAf8ntI9tsddOM+ZoVHs0rdz1qoREQrJ67ffXj5zpLM5PVLE4uejsonKL4CoRE/GV6fypdsPh5ADxEJDSkdXry4ONbRjuMERKpCA4Qoyc3dYFEwWEliMe73MFCk4UxzcZ+bwteqPPzBRdUEMxS8gPY6htAZBLNeJjK/nlPLPuFZKtBhL8MYxlrlDIJCP82d8cz+8J9PQyZQP+MT36DFlHQsOvOLoLf0bpbfAxMtES5ud13iNdO0eVLDNbbb6PItiVvvLwY9af5YF5RshpljsPfrjVB3hQheZoJaMedbY5U5t8ST1pjQR1GsyJNDaaATlRdtW1fPHULQZ6GZRvT5jVgrakoG3MO0kCk+gvln1uVWQVuFBQDG5bapXCjA4M0CJ3EdqsM7f6fWQQP981ltiiR+6qxd7mjw5Hypwfv6wXkChACJldVRRyc6c4x0EFGwNoGmcKt/1Dt6tHY1T7+U5aZ2ktoLss3LPe79b+PRfi/8MCS7LwmnwXVtEa2eSrc9fMLsYmhlyLk3xr0CnJYwBUEyaFQeYXpGl17bw58rmkNgD+REU3OanxSUWxpTuYKA+5sahmumpWDgUH+vFFg/on81L+kosIWmFhAT8xHFRJ4fdZ0aNAzC/g9V1fXjO4KEZdzOMvIMKjDeC96POm+35h8XY449e0goYUB8Js0uZxLAiAa2v6l3sMqmuEv/kdDQRhnYon57dk/1bmT7DJ4gI56bQjw0FBrYNdNKmsdl73kDl8nQmn4Ig6xjTxnsRGrc6", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2d604fae-4594-4462-4dc0-08d971dbbcb8", "X-MS-Exchange-CrossTenant-AuthSource": "DU2PR04MB8630.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Sep 2021 08:44:42.9310 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n KmiGK3owuX3OdApn89W9gFQlRykw0vYoXlgOvPeckAq9DslH56D7iG/Jud89aAe5JVIWW/ZG/NljrYgOJHfKvQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU2PR04MB8949", "Subject": "[dpdk-dev] [PATCH v3 07/10] common/dpaax: enhance caamflib with\n inline keys", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Franck LENORMAND <franck.lenormand@nxp.com>\n\nThe space in descriptor buffer is scarce as it is limited to\n64 words for platforms except ERA10 (which has 128).\n\nAs the descriptors are processed with QI, it adds some words\nto the descriptor which is passed.\n\nSome descriptors used for SDAP were using too much words reaching\nthe limit.\n\nThis patch reduces the number of words used by removing the inlining\nof some keys (done for performance) in order to have working\ndescriptors.\n\nSigned-off-by: Franck LENORMAND <franck.lenormand@nxp.com>\n---\n drivers/common/dpaax/caamflib/desc/sdap.h | 61 ++++++++++++++++++++-\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 28 ++++++++--\n 2 files changed, 81 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/common/dpaax/caamflib/desc/sdap.h b/drivers/common/dpaax/caamflib/desc/sdap.h\nindex d5d5850b4f..b2497a5424 100644\n--- a/drivers/common/dpaax/caamflib/desc/sdap.h\n+++ b/drivers/common/dpaax/caamflib/desc/sdap.h\n@@ -20,6 +20,63 @@\n #define SDAP_BITS_SIZE (SDAP_BYTE_SIZE * 8)\n #endif\n \n+/**\n+ * rta_inline_pdcp_query() - Provide indications if a key can be passed as\n+ * immediate data or shall be referenced in a\n+ * shared descriptor.\n+ * Return: 0 if data can be inlined or 1 if referenced.\n+ */\n+static inline int\n+rta_inline_pdcp_sdap_query(enum auth_type_pdcp auth_alg,\n+\t\t enum cipher_type_pdcp cipher_alg,\n+\t\t enum pdcp_sn_size sn_size,\n+\t\t int8_t hfn_ovd)\n+{\n+\tint nb_key_to_inline = 0;\n+\n+\tif ((cipher_alg != PDCP_CIPHER_TYPE_NULL) &&\n+\t\t\t(auth_alg != PDCP_AUTH_TYPE_NULL))\n+\t\treturn 2;\n+\telse\n+\t\treturn 0;\n+\n+\t/**\n+\t * Shared Descriptors for some of the cases does not fit in the\n+\t * MAX_DESC_SIZE of the descriptor\n+\t * The cases which exceed are for RTA_SEC_ERA=8 and HFN override\n+\t * enabled and 12/18 bit uplane and either of following Algo combo.\n+\t * - AES-SNOW\n+\t * - AES-ZUC\n+\t * - SNOW-SNOW\n+\t * - SNOW-ZUC\n+\t * - ZUC-SNOW\n+\t * - ZUC-SNOW\n+\t *\n+\t * We cannot make inline for all cases, as this will impact performance\n+\t * due to extra memory accesses for the keys.\n+\t */\n+\n+\t/* Inline only the cipher key */\n+\tif ((rta_sec_era == RTA_SEC_ERA_8) && hfn_ovd &&\n+\t\t((sn_size == PDCP_SN_SIZE_12) ||\n+\t\t (sn_size == PDCP_SN_SIZE_18)) &&\n+\t\t(cipher_alg != PDCP_CIPHER_TYPE_NULL) &&\n+\t\t((auth_alg == PDCP_AUTH_TYPE_SNOW) ||\n+\t\t (auth_alg == PDCP_AUTH_TYPE_ZUC))) {\n+\n+\t\tnb_key_to_inline++;\n+\n+\t\t/* Sub case where inlining another key is required */\n+\t\tif ((cipher_alg == PDCP_CIPHER_TYPE_AES) &&\n+\t\t\t(auth_alg == PDCP_AUTH_TYPE_SNOW))\n+\t\t\tnb_key_to_inline++;\n+\t}\n+\n+\t/* Inline both keys */\n+\n+\treturn nb_key_to_inline;\n+}\n+\n static inline void key_loading_opti(struct program *p,\n \t\t\t\t struct alginfo *cipherdata,\n \t\t\t\t struct alginfo *authdata)\n@@ -788,8 +845,8 @@ pdcp_sdap_insert_cplane_null_op(struct program *p,\n \t\t\t unsigned char era_2_sw_hfn_ovrd,\n \t\t\t enum pdb_type_e pdb_type __maybe_unused)\n {\n-\treturn pdcp_insert_cplane_int_only_op(p, swap, cipherdata, authdata,\n-\t\t\t\t\tdir, sn_size, era_2_sw_hfn_ovrd);\n+\treturn pdcp_insert_cplane_null_op(p, swap, cipherdata, authdata, dir,\n+\t\t\t\t\t sn_size, era_2_sw_hfn_ovrd);\n }\n \n static inline int\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex fe90d9d2d8..cca1963da9 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -3254,12 +3254,28 @@ dpaa2_sec_set_pdcp_session(struct rte_cryptodev *dev,\n \t\tgoto out;\n \t}\n \n-\tif (rta_inline_pdcp_query(authdata.algtype,\n-\t\t\t\tcipherdata.algtype,\n-\t\t\t\tsession->pdcp.sn_size,\n-\t\t\t\tsession->pdcp.hfn_ovd)) {\n-\t\tcipherdata.key = DPAA2_VADDR_TO_IOVA(cipherdata.key);\n-\t\tcipherdata.key_type = RTA_DATA_PTR;\n+\tif (pdcp_xform->sdap_enabled) {\n+\t\tint nb_keys_to_inline =\n+\t\t\trta_inline_pdcp_sdap_query(authdata.algtype,\n+\t\t\t\t\tcipherdata.algtype,\n+\t\t\t\t\tsession->pdcp.sn_size,\n+\t\t\t\t\tsession->pdcp.hfn_ovd);\n+\t\tif (nb_keys_to_inline >= 1) {\n+\t\t\tcipherdata.key = DPAA2_VADDR_TO_IOVA(cipherdata.key);\n+\t\t\tcipherdata.key_type = RTA_DATA_PTR;\n+\t\t}\n+\t\tif (nb_keys_to_inline >= 2) {\n+\t\t\tauthdata.key = DPAA2_VADDR_TO_IOVA(authdata.key);\n+\t\t\tauthdata.key_type = RTA_DATA_PTR;\n+\t\t}\n+\t} else {\n+\t\tif (rta_inline_pdcp_query(authdata.algtype,\n+\t\t\t\t\tcipherdata.algtype,\n+\t\t\t\t\tsession->pdcp.sn_size,\n+\t\t\t\t\tsession->pdcp.hfn_ovd)) {\n+\t\t\tcipherdata.key = DPAA2_VADDR_TO_IOVA(cipherdata.key);\n+\t\t\tcipherdata.key_type = RTA_DATA_PTR;\n+\t\t}\n \t}\n \n \tif (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) {\n", "prefixes": [ "v3", "07/10" ] }