Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97876/?format=api
https://patches.dpdk.org/api/patches/97876/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210903075637.2201185-1-fengli@smartx.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210903075637.2201185-1-fengli@smartx.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210903075637.2201185-1-fengli@smartx.com", "date": "2021-09-03T07:56:37", "name": "vhost: call destroy_device always in vhost_destroy_device_notify", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7728e080000a768ccbd660dc153b177ea72c7de9", "submitter": { "id": 1528, "url": "https://patches.dpdk.org/api/people/1528/?format=api", "name": "Li Feng", "email": "fengli@smartx.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210903075637.2201185-1-fengli@smartx.com/mbox/", "series": [ { "id": 18653, "url": "https://patches.dpdk.org/api/series/18653/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18653", "date": "2021-09-03T07:56:37", "name": "vhost: call destroy_device always in vhost_destroy_device_notify", "version": 1, "mbox": "https://patches.dpdk.org/series/18653/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/97876/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/97876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 613A1A0C53;\n\tFri, 3 Sep 2021 09:56:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D6D9340DDE;\n\tFri, 3 Sep 2021 09:56:56 +0200 (CEST)", "from mail-pj1-f41.google.com (mail-pj1-f41.google.com\n [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id AC080406B4\n for <dev@dpdk.org>; Fri, 3 Sep 2021 09:56:54 +0200 (CEST)", "by mail-pj1-f41.google.com with SMTP id\n f11-20020a17090aa78b00b0018e98a7cddaso3364935pjq.4\n for <dev@dpdk.org>; Fri, 03 Sep 2021 00:56:54 -0700 (PDT)", "from 64-217.smartx.com ([103.97.201.35])\n by smtp.gmail.com with ESMTPSA id r15sm4657278pfh.45.2021.09.03.00.56.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Sep 2021 00:56:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=smartx-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=JeJDlOhtbDzZLOVt0CWldBRm1JgFrEUu17qttgi70Zs=;\n b=jc44aQBPwaSCi7T5GDDsWSnZQEN9KhUp7YhZWs+CMpukcv7vo/I/SJgg2VobNjA4vc\n onIfs9hXce5i//8lj612W4dSxZ2fFq5y53ESEr2t3kHoWFwdh0E1H/jSvEfp1QpxPfLT\n TdNtI0plEITEvRx//Mt7rih5kkEwsAnJsC1CUobsM6J6VBMqYL3aJyNalTln+Pl6BHWG\n LfioJv5G46oaEMkWARfyb+FdxS9zht/ejm9ca7K+X12AzWDqErilYL7VVZ/EaYKv2WGx\n /gYR5tWU8L3xphXA3I8VGi44bLt5thh5zALXyHtZbjxDxgUcpudyWsejd0M7yY+Cb74W\n 0XMA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=JeJDlOhtbDzZLOVt0CWldBRm1JgFrEUu17qttgi70Zs=;\n b=FnEG0gSM1N1qdDoHYz1/YO1qHxWw/sBRktX38+sncU3eQWIr5R3R3JcHrdn968C4EH\n 9QgU6emu9GRjvF8+I/KG3MgXel1c/gWcvt7MQf7R/SYL3sp017W6S9pP5Wo73x6PF3S2\n rH/AreQtAYX5btuTNwe+hGQ4H3AnvEXGHDXiqj9XKswI0uabUxbzTXg3zzNVPVAAQG+o\n WevWDtxudi3+fGHHjxb1cJgQA6L2RgIYPmSIv4ggfaaoEJXDU+9sUKtZpsywh8cG0gXZ\n wZ6iW0jxHQsmvpx7+2Dj3w4JbXrMWxtZqf6vK4Py8tmYAt+s55pDMNWeM2A9iWQhBISu\n o0Ag==", "X-Gm-Message-State": "AOAM532KV/xE12ZL7o3wqzh8LZc1sFp4ft6gVNsQBtuaGYGdGiApUL+U\n KaiApKhYjHnxpg3TplQCV9VvAA==", "X-Google-Smtp-Source": "\n ABdhPJy3xNEGeeSLq59+bbHe3rMcaGYJTfwToDh2w04rTWrN3P8GuWs4G/06lPwqxIvvTEvzcgnU4g==", "X-Received": "by 2002:a17:90a:c7d0:: with SMTP id\n gf16mr8588422pjb.17.1630655813616;\n Fri, 03 Sep 2021 00:56:53 -0700 (PDT)", "From": "Li Feng <fengli@smartx.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Cc": "dev@dpdk.org,\n\tLi Feng <fengli@smartx.com>", "Date": "Fri, 3 Sep 2021 15:56:37 +0800", "Message-Id": "<20210903075637.2201185-1-fengli@smartx.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: call destroy_device always in\n vhost_destroy_device_notify", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Vhost-user client must send the mem table, kick fd, call fd on all vas,\nthen the device will be VIRTIO_DEV_RUNNING.\n\nIf the vhost-user communication is initialized partly, e.g.\n- When initializing the vhost-user, try to restart the vhost-user\n backend;\n- Seabios only initialized the vhost-scsi req vq.\nThe device is not with flags VIRTIO_DEV_RUNNING..\n\nRoot Cause:\nThe vhost session has been created, and added the scsi/blk requestq\npoller into reactor, but when destroying the device, the requestq is not\nunregistered.\n\nReproduce the crash on spdk vhost-user backend:\n1. Create a VM;\n2. Mount a ISO to a VM, start the VM, don't install the OS;\n3. Restart the spdk_tgt;\n\nAnother discusstion is in seabiso:\nhttps://patchew.org/Seabios/20210831122339.2591585-1-fengli@smartx.com/\n\nSigned-off-by: Li Feng <fengli@smartx.com>\n---\n lib/vhost/vhost.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex 355ff37651..191ba82c41 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -710,8 +710,8 @@ vhost_destroy_device_notify(struct virtio_net *dev)\n \t\tif (vdpa_dev)\n \t\t\tvdpa_dev->ops->dev_close(dev->vid);\n \t\tdev->flags &= ~VIRTIO_DEV_RUNNING;\n-\t\tdev->notify_ops->destroy_device(dev->vid);\n \t}\n+\tdev->notify_ops->destroy_device(dev->vid);\n }\n \n /*\n", "prefixes": [] }{ "id": 97876, "url": "