Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9786/?format=api
{ "id": 9786, "url": "https://patches.dpdk.org/api/patches/9786/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1452430254-30390-5-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1452430254-30390-5-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1452430254-30390-5-git-send-email-david.marchand@6wind.com", "date": "2016-01-10T12:50:47", "name": "[dpdk-dev,04/11] fm10k: move pci device ids to driver", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4bd83e1cf815f656f798c253d1586c1afb0f8956", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1452430254-30390-5-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9786/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9786/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 160B78E72;\n\tSun, 10 Jan 2016 13:51:13 +0100 (CET)", "from mail-wm0-f54.google.com (mail-wm0-f54.google.com\n\t[74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 1FABD8D3C\n\tfor <dev@dpdk.org>; Sun, 10 Jan 2016 13:51:10 +0100 (CET)", "by mail-wm0-f54.google.com with SMTP id u188so185043289wmu.1\n\tfor <dev@dpdk.org>; Sun, 10 Jan 2016 04:51:10 -0800 (PST)", "from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net.\n\t[78.126.77.144]) by smtp.gmail.com with ESMTPSA id\n\tu12sm8088011wmu.10.2016.01.10.04.51.08\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tSun, 10 Jan 2016 04:51:09 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=P7c1h4IpkiPsEOP26KlhevV1hLih9ZVNKVHT+eqSTZY=;\n\tb=Wa3z/lV04bGs8BAKC1K4A4hXZkmj5Z6eYG1jYlO5cyLez6Y387qnWTeGp5Y5gu7NJ+\n\tNosyG6Q1X7SXQx7rjPPk1ufaGoGt67ko5fIp/TGDd7v118NtwLsjXDfaYLPUHWV+lfTB\n\teX0XGHrUZO7WWeEobXXQvvq/cyiPhUNpKqmqk7BGXJ1WlAmKg3nb3A6saNJdvSpaeU6M\n\tv45+3l9rk3rFLSu16H+oltiPw5AyZurl8hvj566LIPZpt7GO+x+VULT/K4cbk+/kX3z2\n\tk8TJcpDCpUP4NN60hm4pnaZuwabC1fFsdmwEy84QyxDQYH+0tU5GdRTkcn7DECit+xDo\n\tTRAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=P7c1h4IpkiPsEOP26KlhevV1hLih9ZVNKVHT+eqSTZY=;\n\tb=Ah1iGAhsaLWRzKpX5G/2EJuS7fu+ThKB39OKxKAvw4jOIxDI9w58NfPSwme/ficW8y\n\t1F6FnDEml1nI4l9RpjBoIefenCyIBtgfwxDv6fCwE3QRX9LYhubBKw7pJ6fKwCFWjyfo\n\tWnlfCIoGG5TK+9sHSFe4jPesgwsIfbySk0GrJRfsQnoUZ5b6I21s0SCE21/WH/6wv4df\n\tGy8XJLrim0Ws8JaZbjzSDGVl+F9ga3atV4qmqsnqFXjMKSH6rmNNI+xW5WCdEp9VrdLA\n\tboKKXUbQsJFzfk9GA42lBpt8Ks/qTpXS/T85udq0k0lF9RS28eiynoVWsmSX8UBUav/r\n\tEYCA==", "X-Gm-Message-State": "ALoCoQm+aUY8q8mKVGpu6GzPYZG9h7jNfHRqPBnhPfPXLIlrj6yOm5GyOj0l/Zk5bnsrAcZdKstzOf4vbtuwcduaWEEeOgMi0A==", "X-Received": "by 10.28.6.213 with SMTP id 204mr8144118wmg.47.1452430269932;\n\tSun, 10 Jan 2016 04:51:09 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Sun, 10 Jan 2016 13:50:47 +0100", "Message-Id": "<1452430254-30390-5-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1452430254-30390-1-git-send-email-david.marchand@6wind.com>", "References": "<CALwxeUt49PB2TKy_V-9GoQYdDHP3GeBb5LK6jBxdLEYVnRY-vw@mail.gmail.com>\n\t<1452430254-30390-1-git-send-email-david.marchand@6wind.com>", "Cc": "thomas.monjalon@dpdk.org", "Subject": "[dpdk-dev] [PATCH 04/11] fm10k: move pci device ids to driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since the base driver already defines all pci device ids, no need to\nredefine them, let's just drop the previous RTE_PCI_DEV_ID_DECL* stuff.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 8 +++----\n lib/librte_eal/common/include/rte_pci_dev_ids.h | 29 -------------------------\n 2 files changed, 4 insertions(+), 33 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex e4aed94..3ab744a 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2741,10 +2741,10 @@ eth_fm10k_dev_uninit(struct rte_eth_dev *dev)\n * and SRIOV-VF devices.\n */\n static const struct rte_pci_id pci_id_fm10k_map[] = {\n-#define RTE_PCI_DEV_ID_DECL_FM10K(vend, dev) { RTE_PCI_DEVICE(vend, dev) },\n-#define RTE_PCI_DEV_ID_DECL_FM10KVF(vend, dev) { RTE_PCI_DEVICE(vend, dev) },\n-#include \"rte_pci_dev_ids.h\"\n-\t{ .vendor_id = 0, /* sentinel */ },\n+{ RTE_PCI_DEVICE(FM10K_INTEL_VENDOR_ID, FM10K_DEV_ID_PF) },\n+{ RTE_PCI_DEVICE(FM10K_INTEL_VENDOR_ID, FM10K_DEV_ID_SDI_FM10420_QDA2) },\n+{ RTE_PCI_DEVICE(FM10K_INTEL_VENDOR_ID, FM10K_DEV_ID_VF) },\n+{ .vendor_id = 0, /* sentinel */ },\n };\n \n static struct eth_driver rte_pmd_fm10k = {\ndiff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h\nindex f1f3e13..a19fdfa 100644\n--- a/lib/librte_eal/common/include/rte_pci_dev_ids.h\n+++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h\n@@ -97,14 +97,6 @@\n #define RTE_PCI_DEV_ID_DECL_VMXNET3(vend, dev)\n #endif\n \n-#ifndef RTE_PCI_DEV_ID_DECL_FM10K\n-#define RTE_PCI_DEV_ID_DECL_FM10K(vend, dev)\n-#endif\n-\n-#ifndef RTE_PCI_DEV_ID_DECL_FM10KVF\n-#define RTE_PCI_DEV_ID_DECL_FM10KVF(vend, dev)\n-#endif\n-\n #ifndef RTE_PCI_DEV_ID_DECL_ENIC\n #define RTE_PCI_DEV_ID_DECL_ENIC(vend, dev)\n #endif\n@@ -117,11 +109,6 @@\n #define RTE_PCI_DEV_ID_DECL_BNX2XVF(vend, dev)\n #endif\n \n-#ifndef PCI_VENDOR_ID_INTEL\n-/** Vendor ID used by Intel devices */\n-#define PCI_VENDOR_ID_INTEL 0x8086\n-#endif\n-\n #ifndef PCI_VENDOR_ID_QUMRANET\n /** Vendor ID used by virtio devices */\n #define PCI_VENDOR_ID_QUMRANET 0x1AF4\n@@ -142,14 +129,6 @@\n #define PCI_VENDOR_ID_BROADCOM 0x14E4\n #endif\n \n-/*************** Physical FM10K devices from fm10k_type.h ***************/\n-\n-#define FM10K_DEV_ID_PF 0x15A4\n-#define FM10K_DEV_ID_SDI_FM10420_QDA2 0x15D0\n-\n-RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_PF)\n-RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_QDA2)\n-\n /****************** Virtio devices from virtio.h ******************/\n \n #define QUMRANET_DEV_ID_VIRTIO 0x1000\n@@ -162,12 +141,6 @@ RTE_PCI_DEV_ID_DECL_VIRTIO(PCI_VENDOR_ID_QUMRANET, QUMRANET_DEV_ID_VIRTIO)\n \n RTE_PCI_DEV_ID_DECL_VMXNET3(PCI_VENDOR_ID_VMWARE, VMWARE_DEV_ID_VMXNET3)\n \n-/*************** Virtual FM10K devices from fm10k_type.h ***************/\n-\n-#define FM10K_DEV_ID_VF 0x15A5\n-\n-RTE_PCI_DEV_ID_DECL_FM10KVF(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_VF)\n-\n /****************** Cisco VIC devices ******************/\n \n #define PCI_DEVICE_ID_CISCO_VIC_ENET 0x0043 /* ethernet vnic */\n@@ -228,5 +201,3 @@ RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57840_MF)\n #undef RTE_PCI_DEV_ID_DECL_BNX2XVF\n #undef RTE_PCI_DEV_ID_DECL_VIRTIO\n #undef RTE_PCI_DEV_ID_DECL_VMXNET3\n-#undef RTE_PCI_DEV_ID_DECL_FM10K\n-#undef RTE_PCI_DEV_ID_DECL_FM10KVF\n", "prefixes": [ "dpdk-dev", "04/11" ] }