Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97797/?format=api
{ "id": 97797, "url": "https://patches.dpdk.org/api/patches/97797/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1630585354-1136-5-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1630585354-1136-5-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1630585354-1136-5-git-send-email-anoobj@marvell.com", "date": "2021-09-02T12:22:31", "name": "[4/7] crypto/cnxk: remove redundant memcpy of IV for ZUC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ddb95c6e3c26edb5d6f11f2ea64c51172f229743", "submitter": { "id": 1205, "url": "https://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1630585354-1136-5-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 18628, "url": "https://patches.dpdk.org/api/series/18628/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18628", "date": "2021-09-02T12:22:27", "name": "Improvements and fixes in crypto/cnxk PMDs", "version": 1, "mbox": "https://patches.dpdk.org/series/18628/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/97797/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/97797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD85BA0C47;\n\tThu, 2 Sep 2021 14:23:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E232940E09;\n\tThu, 2 Sep 2021 14:23:13 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 6E15A40DF7\n for <dev@dpdk.org>; Thu, 2 Sep 2021 14:23:12 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18280wTo011170\n for <dev@dpdk.org>; Thu, 2 Sep 2021 05:23:11 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3attqmgusr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 02 Sep 2021 05:23:11 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Thu, 2 Sep 2021 05:23:09 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Thu, 2 Sep 2021 05:23:09 -0700", "from HY-LT1002.marvell.com (HY-LT1002.marvell.com [10.28.176.218])\n by maili.marvell.com (Postfix) with ESMTP id EC8033F705E;\n Thu, 2 Sep 2021 05:23:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=K8i511aBLx5AwbFEXHQZjjCGxrjQartKepGDPJM767Y=;\n b=LiOYwIKOi58w5+k7haJxGNIshfSwJcIWHx+otr6Pz0ET+tbuX0NeZSaecS3pWL8TW7gu\n MWsBGJJQdIahRj80cAyAxvtMbrZcfEU896kEQsiEWY0pDeYCAAe/erR07lsnz0mI40Ev\n aPHnAB/LjGMO8Qbu8ttQM70K+AjCsHBAwBQ3ICqD+KO0/suSPWY/wkLPkNDHoFw9nAWH\n 9tB4p27lzHJEa9avKsM4jdLqGkHHp5bSq4mGGhyoV/Vf2FOzZevgU+PQuPlChaYvt65E\n CD0pq/h+/aAs93mr7wQKRHHoR1QS1ILO2eCNE4U1eWX+y9QlAOrjkusZ33kPYRTZUjRT aw==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Archana Muniganti\n <marchana@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, <dev@dpdk.org>", "Date": "Thu, 2 Sep 2021 17:52:31 +0530", "Message-ID": "<1630585354-1136-5-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1630585354-1136-1-git-send-email-anoobj@marvell.com>", "References": "<1630585354-1136-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "zUiPiaGoo-RRy_6ka9GPNmc1sjoGBkCY", "X-Proofpoint-ORIG-GUID": "zUiPiaGoo-RRy_6ka9GPNmc1sjoGBkCY", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475\n definitions=2021-09-02_04,2021-09-02_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH 4/7] crypto/cnxk: remove redundant memcpy of IV\n for ZUC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Swap is not required for ZUC. Update IV updation sequence to remove the\nredundant swap in case of ZUC.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 55 +++++++++++++++++++++++--------------------\n 1 file changed, 30 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex 9d1ce09..bbad289 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -36,6 +36,29 @@ struct cnxk_se_sess {\n \tstruct roc_se_ctx roc_se_ctx;\n } __rte_cache_aligned;\n \n+static inline void\n+pdcp_iv_copy(uint8_t *iv_d, uint8_t *iv_s, const uint8_t pdcp_alg_type)\n+{\n+\tuint32_t *iv_s_temp, iv_temp[4];\n+\tint j;\n+\n+\tif (pdcp_alg_type == ROC_SE_PDCP_ALG_TYPE_SNOW3G) {\n+\t\t/*\n+\t\t * DPDK seems to provide it in form of IV3 IV2 IV1 IV0\n+\t\t * and BigEndian, MC needs it as IV0 IV1 IV2 IV3\n+\t\t */\n+\n+\t\tiv_s_temp = (uint32_t *)iv_s;\n+\n+\t\tfor (j = 0; j < 4; j++)\n+\t\t\tiv_temp[j] = iv_s_temp[3 - j];\n+\t\tmemcpy(iv_d, iv_temp, 16);\n+\t} else {\n+\t\t/* ZUC doesn't need a swap */\n+\t\tmemcpy(iv_d, iv_s, 16);\n+\t}\n+}\n+\n static __rte_always_inline int\n cpt_mac_len_verify(struct rte_crypto_auth_xform *auth)\n {\n@@ -954,13 +977,13 @@ cpt_zuc_snow3g_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \tint32_t inputlen, outputlen;\n \tstruct roc_se_ctx *se_ctx;\n \tuint32_t mac_len = 0;\n-\tuint8_t pdcp_alg_type, j;\n+\tuint8_t pdcp_alg_type;\n \tuint32_t encr_offset, auth_offset;\n \tuint32_t encr_data_len, auth_data_len;\n \tint flags, iv_len = 16;\n \tuint64_t offset_ctrl;\n \tuint64_t *offset_vaddr;\n-\tuint32_t *iv_s, iv[4];\n+\tuint8_t *iv_s;\n \tunion cpt_inst_w4 cpt_inst_w4;\n \n \tse_ctx = params->ctx_buf.vaddr;\n@@ -1030,20 +1053,6 @@ cpt_zuc_snow3g_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \t\treturn -1;\n \t}\n \n-\tif (pdcp_alg_type == ROC_SE_PDCP_ALG_TYPE_SNOW3G) {\n-\t\t/*\n-\t\t * DPDK seems to provide it in form of IV3 IV2 IV1 IV0\n-\t\t * and BigEndian, MC needs it as IV0 IV1 IV2 IV3\n-\t\t */\n-\n-\t\tfor (j = 0; j < 4; j++)\n-\t\t\tiv[j] = iv_s[3 - j];\n-\t} else {\n-\t\t/* ZUC doesn't need a swap */\n-\t\tfor (j = 0; j < 4; j++)\n-\t\t\tiv[j] = iv_s[j];\n-\t}\n-\n \t/*\n \t * GP op header, lengths are expected in bits.\n \t */\n@@ -1072,11 +1081,8 @@ cpt_zuc_snow3g_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \n \t\tcpt_inst_w4.s.dlen = inputlen + ROC_SE_OFF_CTRL_LEN;\n \n-\t\tif (likely(iv_len)) {\n-\t\t\tuint32_t *iv_d = (uint32_t *)((uint8_t *)offset_vaddr +\n-\t\t\t\t\t\t ROC_SE_OFF_CTRL_LEN);\n-\t\t\tmemcpy(iv_d, iv, 16);\n-\t\t}\n+\t\tuint8_t *iv_d = ((uint8_t *)offset_vaddr + ROC_SE_OFF_CTRL_LEN);\n+\t\tpdcp_iv_copy(iv_d, iv_s, pdcp_alg_type);\n \n \t\t*offset_vaddr = offset_ctrl;\n \t} else {\n@@ -1085,7 +1091,7 @@ cpt_zuc_snow3g_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \t\tstruct roc_se_sglist_comp *gather_comp;\n \t\tstruct roc_se_sglist_comp *scatter_comp;\n \t\tuint8_t *in_buffer;\n-\t\tuint32_t *iv_d;\n+\t\tuint8_t *iv_d;\n \n \t\t/* save space for iv */\n \t\toffset_vaddr = m_vaddr;\n@@ -1117,9 +1123,8 @@ cpt_zuc_snow3g_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \t\t/* iv offset is 0 */\n \t\t*offset_vaddr = offset_ctrl;\n \n-\t\tiv_d = (uint32_t *)((uint8_t *)offset_vaddr +\n-\t\t\t\t ROC_SE_OFF_CTRL_LEN);\n-\t\tmemcpy(iv_d, iv, 16);\n+\t\tiv_d = ((uint8_t *)offset_vaddr + ROC_SE_OFF_CTRL_LEN);\n+\t\tpdcp_iv_copy(iv_d, iv_s, pdcp_alg_type);\n \n \t\t/* input data */\n \t\tsize = inputlen - iv_len;\n", "prefixes": [ "4/7" ] }