Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97709/?format=api
{ "id": 97709, "url": "https://patches.dpdk.org/api/patches/97709/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210901163216.120087-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210901163216.120087-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210901163216.120087-5-bruce.richardson@intel.com", "date": "2021-09-01T16:32:14", "name": "[v2,4/6] app/test: add more comprehensive dmadev copy tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8db89ebafa995096fe9389f02761375ac0d18fa0", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210901163216.120087-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 18607, "url": "https://patches.dpdk.org/api/series/18607/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18607", "date": "2021-09-01T16:32:10", "name": "add test suite for DMA drivers", "version": 2, "mbox": "https://patches.dpdk.org/series/18607/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/97709/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/97709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 380A9A0C47;\n\tWed, 1 Sep 2021 18:32:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A9F04116F;\n\tWed, 1 Sep 2021 18:32:41 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 0BA694116F\n for <dev@dpdk.org>; Wed, 1 Sep 2021 18:32:39 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Sep 2021 09:32:39 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.29])\n by orsmga005.jf.intel.com with ESMTP; 01 Sep 2021 09:32:38 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10094\"; a=\"198359900\"", "E=Sophos;i=\"5.84,369,1620716400\"; d=\"scan'208\";a=\"198359900\"", "E=Sophos;i=\"5.84,369,1620716400\"; d=\"scan'208\";a=\"645812868\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "conor.walsh@intel.com, kevin.laatz@intel.com, fengchengwen@huawei.com,\n jerinj@marvell.com, Bruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 1 Sep 2021 17:32:14 +0100", "Message-Id": "<20210901163216.120087-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210901163216.120087-1-bruce.richardson@intel.com>", "References": "<20210826183301.333442-1-bruce.richardson@intel.com>\n <20210901163216.120087-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 4/6] app/test: add more comprehensive dmadev\n copy tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for various combinations of use for dmadev, copying\nbursts of packets in various formats, e.g.\n\n1. enqueuing two smaller bursts and completing them as one burst\n2. enqueuing one burst and gathering completions in smaller bursts\n3. using completed_status() function to gather completions rather than\n just completed()\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_dmadev.c | 142 ++++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 140 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c\nindex 261f45db71..7a808a9cba 100644\n--- a/app/test/test_dmadev.c\n+++ b/app/test/test_dmadev.c\n@@ -39,6 +39,20 @@ print_err(const char *func, int lineno, const char *format, ...)\n \treturn ret;\n }\n \n+static inline int\n+check_stats(struct rte_dmadev_stats *stats, bool check_errors)\n+{\n+\tif (stats->completed != stats->submitted) {\n+\t\tPRINT_ERR(\"Error, not all submitted jobs are reported as completed\\n\");\n+\t\treturn -1;\n+\t}\n+\tif (check_errors && stats->errors != 0) {\n+\t\tPRINT_ERR(\"Errors reported during copy processing, aborting tests\\n\");\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n static inline void\n await_hw(int dev_id, uint16_t vchan)\n {\n@@ -57,6 +71,120 @@ await_hw(int dev_id, uint16_t vchan)\n \t}\n }\n \n+/* run a series of copy tests just using some different options for enqueues and completions */\n+static int\n+do_multi_copies(int dev_id, uint16_t vchan,\n+\t\tint split_batches, /* submit 2 x 16 or 1 x 32 burst */\n+\t\tint split_completions, /* gather 2 x 16 or 1 x 32 completions */\n+\t\tint use_completed_status) /* use completed or completed_status function */\n+{\n+\tstruct rte_mbuf *srcs[32], *dsts[32];\n+\tenum rte_dma_status_code sc[32];\n+\tunsigned int i, j;\n+\tbool dma_err = false;\n+\n+\t/* Enqueue burst of copies and hit doorbell */\n+\tfor (i = 0; i < RTE_DIM(srcs); i++) {\n+\t\tuint64_t *src_data;\n+\n+\t\tif (split_batches && i == RTE_DIM(srcs) / 2)\n+\t\t\trte_dmadev_submit(dev_id, vchan);\n+\n+\t\tsrcs[i] = rte_pktmbuf_alloc(pool);\n+\t\tdsts[i] = rte_pktmbuf_alloc(pool);\n+\t\tif (srcs[i] == NULL || dsts[i] == NULL) {\n+\t\t\tPRINT_ERR(\"Error allocating buffers\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tsrc_data = rte_pktmbuf_mtod(srcs[i], uint64_t *);\n+\n+\t\tfor (j = 0; j < COPY_LEN/sizeof(uint64_t); j++)\n+\t\t\tsrc_data[j] = rte_rand();\n+\n+\t\tif (rte_dmadev_copy(dev_id, vchan, srcs[i]->buf_iova + srcs[i]->data_off,\n+\t\t\t\tdsts[i]->buf_iova + dsts[i]->data_off, COPY_LEN, 0) != id_count++) {\n+\t\t\tPRINT_ERR(\"Error with rte_dmadev_copy for buffer %u\\n\", i);\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n+\trte_dmadev_submit(dev_id, vchan);\n+\n+\tawait_hw(dev_id, vchan);\n+\n+\tif (split_completions) {\n+\t\t/* gather completions in two halves */\n+\t\tuint16_t half_len = RTE_DIM(srcs) / 2;\n+\t\tint ret = rte_dmadev_completed(dev_id, vchan, half_len, NULL, &dma_err);\n+\t\tif (ret != half_len || dma_err) {\n+\t\t\tPRINT_ERR(\"Error with rte_dmadev_completed - first half. ret = %d, expected ret = %u, dma_err = %d\\n\",\n+\t\t\t\t\tret, half_len, dma_err);\n+\t\t\trte_dmadev_dump(dev_id, stdout);\n+\t\t\treturn -1;\n+\t\t}\n+\t\tret = rte_dmadev_completed(dev_id, vchan, half_len, NULL, &dma_err);\n+\t\tif (ret != half_len || dma_err) {\n+\t\t\tPRINT_ERR(\"Error with rte_dmadev_completed - second half. ret = %d, expected ret = %u, dma_err = %d\\n\",\n+\t\t\t\t\tret, half_len, dma_err);\n+\t\t\trte_dmadev_dump(dev_id, stdout);\n+\t\t\treturn -1;\n+\t\t}\n+\t} else {\n+\t\t/* gather all completions in one go, using either\n+\t\t * completed or completed_status fns\n+\t\t */\n+\t\tif (!use_completed_status) {\n+\t\t\tint n = rte_dmadev_completed(dev_id, vchan, RTE_DIM(srcs), NULL, &dma_err);\n+\t\t\tif (n != RTE_DIM(srcs) || dma_err) {\n+\t\t\t\tPRINT_ERR(\"Error with rte_dmadev_completed, %u [expected: %zu], dma_err = %d\\n\",\n+\t\t\t\t\t\tn, RTE_DIM(srcs), dma_err);\n+\t\t\t\trte_dmadev_dump(dev_id, stdout);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tint n = rte_dmadev_completed_status(dev_id, vchan, RTE_DIM(srcs), NULL, sc);\n+\t\t\tif (n != RTE_DIM(srcs)) {\n+\t\t\t\tPRINT_ERR(\"Error with rte_dmadev_completed_status, %u [expected: %zu]\\n\",\n+\t\t\t\t\t\tn, RTE_DIM(srcs));\n+\t\t\t\trte_dmadev_dump(dev_id, stdout);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tfor (j = 0; j < (uint16_t)n; j++) {\n+\t\t\t\tif (sc[j] != RTE_DMA_STATUS_SUCCESSFUL) {\n+\t\t\t\t\tPRINT_ERR(\"Error with rte_dmadev_completed_status, job %u reports failure [code %u]\\n\",\n+\t\t\t\t\t\t\tj, sc[j]);\n+\t\t\t\t\trte_dmadev_dump(dev_id, stdout);\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\t/* check for empty */\n+\tint ret = use_completed_status ?\n+\t\t\trte_dmadev_completed_status(dev_id, vchan, RTE_DIM(srcs), NULL, sc) :\n+\t\t\trte_dmadev_completed(dev_id, vchan, RTE_DIM(srcs), NULL, &dma_err);\n+\tif (ret != 0) {\n+\t\tPRINT_ERR(\"Error with completion check - ops unexpectedly returned\\n\");\n+\t\trte_dmadev_dump(dev_id, stdout);\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < RTE_DIM(srcs); i++) {\n+\t\tchar *src_data, *dst_data;\n+\n+\t\tsrc_data = rte_pktmbuf_mtod(srcs[i], char *);\n+\t\tdst_data = rte_pktmbuf_mtod(dsts[i], char *);\n+\t\tfor (j = 0; j < COPY_LEN; j++)\n+\t\t\tif (src_data[j] != dst_data[j]) {\n+\t\t\t\tPRINT_ERR(\"Error with copy of packet %u, byte %u\\n\", i, j);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\trte_pktmbuf_free(srcs[i]);\n+\t\trte_pktmbuf_free(dsts[i]);\n+\t}\n+\treturn 0;\n+}\n+\n static int\n test_enqueue_copies(int dev_id, uint16_t vchan)\n {\n@@ -164,7 +292,14 @@ test_enqueue_copies(int dev_id, uint16_t vchan)\n \t\trte_pktmbuf_free(dst);\n \t} while (0);\n \n-\treturn 0;\n+\t/* test doing multiple copies */\n+\treturn do_multi_copies(dev_id, vchan, 0, 0, 0) /* enqueue and complete 1 batch at a time */\n+\t\t\t/* enqueue 2 batches and then complete both */\n+\t\t\t|| do_multi_copies(dev_id, vchan, 1, 0, 0)\n+\t\t\t/* enqueue 1 batch, then complete in two halves */\n+\t\t\t|| do_multi_copies(dev_id, vchan, 0, 1, 0)\n+\t\t\t/* test using completed_status in place of regular completed API */\n+\t\t\t|| do_multi_copies(dev_id, vchan, 0, 0, 1);\n }\n \n static int\n@@ -216,6 +351,8 @@ test_dmadev_instance(uint16_t dev_id)\n \t\t\t\tstats.completed, stats.submitted, stats.errors);\n \t\treturn -1;\n \t}\n+\n+\trte_dmadev_stats_reset(dev_id, vchan);\n \tid_count = 0;\n \n \t/* create a mempool for running tests */\n@@ -246,7 +383,8 @@ test_dmadev_instance(uint16_t dev_id)\n \t\tprintf(\"Errors: %\"PRIu64\"\\r\", stats.errors);\n \t}\n \tprintf(\"\\n\");\n-\n+\tif (check_stats(&stats, true) < 0)\n+\t\tgoto err;\n \n \trte_mempool_free(pool);\n \trte_dmadev_stop(dev_id);\n", "prefixes": [ "v2", "4/6" ] }