Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97452/?format=api
{ "id": 97452, "url": "https://patches.dpdk.org/api/patches/97452/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-34-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210827065717.1838258-34-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-34-andrew.rybchenko@oktetlabs.ru", "date": "2021-08-27T06:57:12", "name": "[33/38] net/sfc: store PCI address for represented entities", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6ad6862cc976dcaab4093977e7b27484af857d5d", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-34-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 18492, "url": "https://patches.dpdk.org/api/series/18492/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18492", "date": "2021-08-27T06:56:39", "name": "net/sfc: support port representors", "version": 1, "mbox": "https://patches.dpdk.org/series/18492/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/97452/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/97452/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 99413A0C41;\n\tFri, 27 Aug 2021 09:01:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8C21441293;\n\tFri, 27 Aug 2021 08:59:14 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id EB94241269\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:59:11 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id C1AEC7F6E7; Fri, 27 Aug 2021 09:59:11 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 769167F6F4;\n Fri, 27 Aug 2021 09:57:36 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 769167F6F4", "Authentication-Results": "shelob.oktetlabs.ru/769167F6F4; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Fri, 27 Aug 2021 09:57:12 +0300", "Message-Id": "<20210827065717.1838258-34-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 33/38] net/sfc: store PCI address for represented\n entities", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>\n\nThis information will be useful when representor info API is implemented.\n\nSigned-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 11 +++++++++--\n drivers/net/sfc/sfc_repr.c | 20 +++++++++++++++-----\n drivers/net/sfc/sfc_repr.h | 10 +++++++++-\n drivers/net/sfc/sfc_switch.c | 14 ++++++++++++++\n drivers/net/sfc/sfc_switch.h | 11 +++++++++++\n 5 files changed, 58 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 8536a2b111..49ba820501 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -2680,6 +2680,7 @@ sfc_eth_dev_create_representors(struct rte_eth_dev *dev,\n \n \tfor (i = 0; i < eth_da->nb_representor_ports; ++i) {\n \t\tconst efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);\n+\t\tstruct sfc_repr_entity_info entity;\n \t\tefx_mport_sel_t mport_sel;\n \n \t\trc = efx_mae_mport_by_pcie_function(encp->enc_pf,\n@@ -2692,8 +2693,14 @@ sfc_eth_dev_create_representors(struct rte_eth_dev *dev,\n \t\t\tcontinue;\n \t\t}\n \n-\t\trc = sfc_repr_create(dev, eth_da->representor_ports[i],\n-\t\t\t\t sa->mae.switch_domain_id, &mport_sel);\n+\t\tmemset(&entity, 0, sizeof(entity));\n+\t\tentity.type = eth_da->type;\n+\t\tentity.intf = encp->enc_intf;\n+\t\tentity.pf = encp->enc_pf;\n+\t\tentity.vf = eth_da->representor_ports[i];\n+\n+\t\trc = sfc_repr_create(dev, &entity, sa->mae.switch_domain_id,\n+\t\t\t\t &mport_sel);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"cannot create representor %u: %s - ignore\",\n \t\t\t\teth_da->representor_ports[i],\ndiff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c\nindex 4fd81c3f6b..a42e70c92c 100644\n--- a/drivers/net/sfc/sfc_repr.c\n+++ b/drivers/net/sfc/sfc_repr.c\n@@ -924,6 +924,9 @@ struct sfc_repr_init_data {\n \tuint16_t\t\trepr_id;\n \tuint16_t\t\tswitch_domain_id;\n \tefx_mport_sel_t\t\tmport_sel;\n+\tefx_pcie_interface_t\tintf;\n+\tuint16_t\t\tpf;\n+\tuint16_t\t\tvf;\n };\n \n static int\n@@ -961,6 +964,9 @@ sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)\n \tswitch_port_request.ethdev_mportp = ðdev_mport_sel;\n \tswitch_port_request.entity_mportp = &repr_data->mport_sel;\n \tswitch_port_request.ethdev_port_id = dev->data->port_id;\n+\tswitch_port_request.port_data.repr.intf = repr_data->intf;\n+\tswitch_port_request.port_data.repr.pf = repr_data->pf;\n+\tswitch_port_request.port_data.repr.vf = repr_data->vf;\n \n \tret = sfc_repr_assign_mae_switch_port(repr_data->switch_domain_id,\n \t\t\t\t\t &switch_port_request,\n@@ -1037,8 +1043,10 @@ sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)\n }\n \n int\n-sfc_repr_create(struct rte_eth_dev *parent, uint16_t representor_id,\n-\t\tuint16_t switch_domain_id, const efx_mport_sel_t *mport_sel)\n+sfc_repr_create(struct rte_eth_dev *parent,\n+\t\tstruct sfc_repr_entity_info *entity,\n+\t\tuint16_t switch_domain_id,\n+\t\tconst efx_mport_sel_t *mport_sel)\n {\n \tstruct sfc_repr_init_data repr_data;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n@@ -1046,8 +1054,7 @@ sfc_repr_create(struct rte_eth_dev *parent, uint16_t representor_id,\n \tstruct rte_eth_dev *dev;\n \n \tif (snprintf(name, sizeof(name), \"net_%s_representor_%u\",\n-\t\t parent->device->name, representor_id) >=\n-\t\t\t(int)sizeof(name)) {\n+\t\t parent->device->name, entity->vf) >= (int)sizeof(name)) {\n \t\tSFC_GENERIC_LOG(ERR, \"%s() failed name too long\", __func__);\n \t\treturn -ENAMETOOLONG;\n \t}\n@@ -1056,9 +1063,12 @@ sfc_repr_create(struct rte_eth_dev *parent, uint16_t representor_id,\n \tif (dev == NULL) {\n \t\tmemset(&repr_data, 0, sizeof(repr_data));\n \t\trepr_data.pf_port_id = parent->data->port_id;\n-\t\trepr_data.repr_id = representor_id;\n+\t\trepr_data.repr_id = entity->vf;\n \t\trepr_data.switch_domain_id = switch_domain_id;\n \t\trepr_data.mport_sel = *mport_sel;\n+\t\trepr_data.intf = entity->intf;\n+\t\trepr_data.pf = entity->pf;\n+\t\trepr_data.vf = entity->vf;\n \n \t\tret = rte_eth_dev_create(parent->device, name,\n \t\t\t\t\t sizeof(struct sfc_repr_shared),\ndiff --git a/drivers/net/sfc/sfc_repr.h b/drivers/net/sfc/sfc_repr.h\nindex 1347206006..2093973761 100644\n--- a/drivers/net/sfc/sfc_repr.h\n+++ b/drivers/net/sfc/sfc_repr.h\n@@ -26,7 +26,15 @@ extern \"C\" {\n /** Max count of the representor Tx queues */\n #define SFC_REPR_TXQ_MAX\t1\n \n-int sfc_repr_create(struct rte_eth_dev *parent, uint16_t representor_id,\n+struct sfc_repr_entity_info {\n+\tenum rte_eth_representor_type type;\n+\tefx_pcie_interface_t intf;\n+\tuint16_t pf;\n+\tuint16_t vf;\n+};\n+\n+int sfc_repr_create(struct rte_eth_dev *parent,\n+\t\t struct sfc_repr_entity_info *entity,\n \t\t uint16_t switch_domain_id,\n \t\t const efx_mport_sel_t *mport_sel);\n \ndiff --git a/drivers/net/sfc/sfc_switch.c b/drivers/net/sfc/sfc_switch.c\nindex f72f6648b8..7a0b332f33 100644\n--- a/drivers/net/sfc/sfc_switch.c\n+++ b/drivers/net/sfc/sfc_switch.c\n@@ -63,6 +63,8 @@ struct sfc_mae_switch_port {\n \tenum sfc_mae_switch_port_type\t\ttype;\n \t/** RTE switch port ID */\n \tuint16_t\t\t\t\tid;\n+\n+\tunion sfc_mae_switch_port_data\t\tdata;\n };\n \n TAILQ_HEAD(sfc_mae_switch_ports, sfc_mae_switch_port);\n@@ -335,6 +337,18 @@ sfc_mae_assign_switch_port(uint16_t switch_domain_id,\n \tport->ethdev_mport = *req->ethdev_mportp;\n \tport->ethdev_port_id = req->ethdev_port_id;\n \n+\tswitch (req->type) {\n+\tcase SFC_MAE_SWITCH_PORT_INDEPENDENT:\n+\t\t/* No data */\n+\t\tbreak;\n+\tcase SFC_MAE_SWITCH_PORT_REPRESENTOR:\n+\t\tmemcpy(&port->data.repr, &req->port_data,\n+\t\t sizeof(port->data.repr));\n+\t\tbreak;\n+\tdefault:\n+\t\tSFC_ASSERT(B_FALSE);\n+\t}\n+\n \t*switch_port_id = port->id;\n \n \trte_spinlock_unlock(&sfc_mae_switch.lock);\ndiff --git a/drivers/net/sfc/sfc_switch.h b/drivers/net/sfc/sfc_switch.h\nindex 1eee5fc0b6..a072507375 100644\n--- a/drivers/net/sfc/sfc_switch.h\n+++ b/drivers/net/sfc/sfc_switch.h\n@@ -34,11 +34,22 @@ enum sfc_mae_switch_port_type {\n \tSFC_MAE_SWITCH_PORT_REPRESENTOR,\n };\n \n+struct sfc_mae_switch_port_repr_data {\n+\tefx_pcie_interface_t\t\t\tintf;\n+\tuint16_t\t\t\t\tpf;\n+\tuint16_t\t\t\t\tvf;\n+};\n+\n+union sfc_mae_switch_port_data {\n+\tstruct sfc_mae_switch_port_repr_data\trepr;\n+};\n+\n struct sfc_mae_switch_port_request {\n \tenum sfc_mae_switch_port_type\t\ttype;\n \tconst efx_mport_sel_t\t\t\t*entity_mportp;\n \tconst efx_mport_sel_t\t\t\t*ethdev_mportp;\n \tuint16_t\t\t\t\tethdev_port_id;\n+\tunion sfc_mae_switch_port_data\t\tport_data;\n };\n \n int sfc_mae_assign_switch_domain(struct sfc_adapter *sa,\n", "prefixes": [ "33/38" ] }