Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 97437,
    "url": "https://patches.dpdk.org/api/patches/97437/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-18-andrew.rybchenko@oktetlabs.ru/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210827065717.1838258-18-andrew.rybchenko@oktetlabs.ru>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-18-andrew.rybchenko@oktetlabs.ru",
    "date": "2021-08-27T06:56:56",
    "name": "[17/38] net/sfc: implement representor RxQ start/stop",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "666bc97dcc4006da0cc299dd8d668038043db7f7",
    "submitter": {
        "id": 2013,
        "url": "https://patches.dpdk.org/api/people/2013/?format=api",
        "name": "Andrew Rybchenko",
        "email": "Andrew.Rybchenko@oktetlabs.ru"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-18-andrew.rybchenko@oktetlabs.ru/mbox/",
    "series": [
        {
            "id": 18492,
            "url": "https://patches.dpdk.org/api/series/18492/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18492",
            "date": "2021-08-27T06:56:39",
            "name": "net/sfc: support port representors",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/18492/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/97437/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/97437/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6BD9A0C43;\n\tFri, 27 Aug 2021 08:59:45 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6716441287;\n\tFri, 27 Aug 2021 08:58:43 +0200 (CEST)",
            "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 06FB941251\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:58:37 +0200 (CEST)",
            "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 6D19E7F6DE; Fri, 27 Aug 2021 09:58:36 +0300 (MSK)",
            "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id A56B87F6E2;\n Fri, 27 Aug 2021 09:57:34 +0300 (MSK)"
        ],
        "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru",
        "X-Spam-Level": "",
        "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2",
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A56B87F6E2",
        "Authentication-Results": "shelob.oktetlabs.ru/A56B87F6E2; dkim=none;\n dkim-atps=neutral",
        "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "To": "dev@dpdk.org",
        "Cc": "Igor Romanov <igor.romanov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>",
        "Date": "Fri, 27 Aug 2021 09:56:56 +0300",
        "Message-Id": "<20210827065717.1838258-18-andrew.rybchenko@oktetlabs.ru>",
        "X-Mailer": "git-send-email 2.30.2",
        "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>",
        "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 17/38] net/sfc: implement representor RxQ\n start/stop",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nAdd extra libefx flags to Rx queue information initialization\nfunction interface to be able to specify the ingress m-port\nflag for a representor RxQ. Rx prefix of packets on that queue\nwill contain ingress m-port field required for packet forwarding\nin representor proxy.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_ev.h         |   8 ++\n drivers/net/sfc/sfc_repr_proxy.c | 194 +++++++++++++++++++++++++++++++\n drivers/net/sfc/sfc_repr_proxy.h |   7 ++\n 3 files changed, 209 insertions(+)",
    "diff": "diff --git a/drivers/net/sfc/sfc_ev.h b/drivers/net/sfc/sfc_ev.h\nindex 590cfb1694..bcb7fbe466 100644\n--- a/drivers/net/sfc/sfc_ev.h\n+++ b/drivers/net/sfc/sfc_ev.h\n@@ -110,6 +110,14 @@ sfc_counters_rxq_sw_index(const struct sfc_adapter_shared *sas)\n \treturn sas->counters_rxq_allocated ? 0 : SFC_SW_INDEX_INVALID;\n }\n \n+static inline sfc_sw_index_t\n+sfc_repr_rxq_sw_index(const struct sfc_adapter_shared *sas,\n+\t\t      unsigned int repr_queue_id)\n+{\n+\treturn sfc_counters_rxq_sw_index(sas) + sfc_repr_nb_rxq(sas) +\n+\t\trepr_queue_id;\n+}\n+\n /*\n  * Functions below define event queue to transmit/receive queue and vice\n  * versa mapping.\ndiff --git a/drivers/net/sfc/sfc_repr_proxy.c b/drivers/net/sfc/sfc_repr_proxy.c\nindex 6a89cca40a..03b6421b04 100644\n--- a/drivers/net/sfc/sfc_repr_proxy.c\n+++ b/drivers/net/sfc/sfc_repr_proxy.c\n@@ -15,6 +15,8 @@\n #include \"sfc_repr_proxy.h\"\n #include \"sfc_repr_proxy_api.h\"\n #include \"sfc.h\"\n+#include \"sfc_ev.h\"\n+#include \"sfc_rx.h\"\n \n /**\n  * Amount of time to wait for the representor proxy routine (which is\n@@ -136,6 +138,181 @@ sfc_repr_proxy_routine(void *arg)\n \treturn 0;\n }\n \n+static int\n+sfc_repr_proxy_rxq_attach(struct sfc_adapter *sa)\n+{\n+\tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n+\tstruct sfc_repr_proxy *rp = &sa->repr_proxy;\n+\tunsigned int i;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tfor (i = 0; i < sfc_repr_nb_rxq(sas); i++) {\n+\t\tsfc_sw_index_t sw_index = sfc_repr_rxq_sw_index(sas, i);\n+\n+\t\trp->dp_rxq[i].sw_index = sw_index;\n+\t}\n+\n+\tsfc_log_init(sa, \"done\");\n+\n+\treturn 0;\n+}\n+\n+static void\n+sfc_repr_proxy_rxq_detach(struct sfc_adapter *sa)\n+{\n+\tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n+\tstruct sfc_repr_proxy *rp = &sa->repr_proxy;\n+\tunsigned int i;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tfor (i = 0; i < sfc_repr_nb_rxq(sas); i++)\n+\t\trp->dp_rxq[i].sw_index = 0;\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n+static int\n+sfc_repr_proxy_rxq_init(struct sfc_adapter *sa,\n+\t\t\tstruct sfc_repr_proxy_dp_rxq *rxq)\n+{\n+\tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n+\tuint16_t nb_rx_desc = SFC_REPR_PROXY_RX_DESC_COUNT;\n+\tstruct sfc_rxq_info *rxq_info;\n+\tstruct rte_eth_rxconf rxconf = {\n+\t\t.rx_free_thresh = SFC_REPR_PROXY_RXQ_REFILL_LEVEL,\n+\t\t.rx_drop_en = 1,\n+\t};\n+\tint rc;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\trxq_info = &sas->rxq_info[rxq->sw_index];\n+\tif (rxq_info->state & SFC_RXQ_INITIALIZED) {\n+\t\tsfc_log_init(sa, \"RxQ is already initialized - skip\");\n+\t\treturn 0;\n+\t}\n+\n+\tnb_rx_desc = RTE_MIN(nb_rx_desc, sa->rxq_max_entries);\n+\tnb_rx_desc = RTE_MAX(nb_rx_desc, sa->rxq_min_entries);\n+\n+\trc = sfc_rx_qinit_info(sa, rxq->sw_index, EFX_RXQ_FLAG_INGRESS_MPORT);\n+\tif (rc != 0) {\n+\t\tsfc_err(sa, \"failed to init representor proxy RxQ info\");\n+\t\tgoto fail_repr_rxq_init_info;\n+\t}\n+\n+\trc = sfc_rx_qinit(sa, rxq->sw_index, nb_rx_desc, sa->socket_id, &rxconf,\n+\t\t\t  rxq->mp);\n+\tif (rc != 0) {\n+\t\tsfc_err(sa, \"failed to init representor proxy RxQ\");\n+\t\tgoto fail_repr_rxq_init;\n+\t}\n+\n+\tsfc_log_init(sa, \"done\");\n+\n+\treturn 0;\n+\n+fail_repr_rxq_init:\n+fail_repr_rxq_init_info:\n+\tsfc_log_init(sa, \"failed: %s\", rte_strerror(rc));\n+\n+\treturn rc;\n+}\n+\n+static void\n+sfc_repr_proxy_rxq_fini(struct sfc_adapter *sa)\n+{\n+\tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n+\tstruct sfc_repr_proxy *rp = &sa->repr_proxy;\n+\tstruct sfc_rxq_info *rxq_info;\n+\tunsigned int i;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tif (!sfc_repr_available(sas)) {\n+\t\tsfc_log_init(sa, \"representors not supported - skip\");\n+\t\treturn;\n+\t}\n+\n+\tfor (i = 0; i < sfc_repr_nb_rxq(sas); i++) {\n+\t\tstruct sfc_repr_proxy_dp_rxq *rxq = &rp->dp_rxq[i];\n+\n+\t\trxq_info = &sas->rxq_info[rxq->sw_index];\n+\t\tif (rxq_info->state != SFC_RXQ_INITIALIZED) {\n+\t\t\tsfc_log_init(sa,\n+\t\t\t\t\"representor RxQ %u is already finalized - skip\",\n+\t\t\t\ti);\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tsfc_rx_qfini(sa, rxq->sw_index);\n+\t}\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n+static void\n+sfc_repr_proxy_rxq_stop(struct sfc_adapter *sa)\n+{\n+\tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n+\tunsigned int i;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tfor (i = 0; i < sfc_repr_nb_rxq(sas); i++)\n+\t\tsfc_rx_qstop(sa, sa->repr_proxy.dp_rxq[i].sw_index);\n+\n+\tsfc_repr_proxy_rxq_fini(sa);\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n+static int\n+sfc_repr_proxy_rxq_start(struct sfc_adapter *sa)\n+{\n+\tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n+\tstruct sfc_repr_proxy *rp = &sa->repr_proxy;\n+\tunsigned int i;\n+\tint rc;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tif (!sfc_repr_available(sas)) {\n+\t\tsfc_log_init(sa, \"representors not supported - skip\");\n+\t\treturn 0;\n+\t}\n+\n+\tfor (i = 0; i < sfc_repr_nb_rxq(sas); i++) {\n+\t\tstruct sfc_repr_proxy_dp_rxq *rxq = &rp->dp_rxq[i];\n+\n+\t\trc = sfc_repr_proxy_rxq_init(sa, rxq);\n+\t\tif (rc != 0) {\n+\t\t\tsfc_err(sa, \"failed to init representor proxy RxQ %u\",\n+\t\t\t\ti);\n+\t\t\tgoto fail_init;\n+\t\t}\n+\n+\t\trc = sfc_rx_qstart(sa, rxq->sw_index);\n+\t\tif (rc != 0) {\n+\t\t\tsfc_err(sa, \"failed to start representor proxy RxQ %u\",\n+\t\t\t\ti);\n+\t\t\tgoto fail_start;\n+\t\t}\n+\t}\n+\n+\tsfc_log_init(sa, \"done\");\n+\n+\treturn 0;\n+\n+fail_start:\n+fail_init:\n+\tsfc_repr_proxy_rxq_stop(sa);\n+\tsfc_log_init(sa, \"failed: %s\", rte_strerror(rc));\n+\treturn rc;\n+}\n+\n static int\n sfc_repr_proxy_ports_init(struct sfc_adapter *sa)\n {\n@@ -217,6 +394,10 @@ sfc_repr_proxy_attach(struct sfc_adapter *sa)\n \t\treturn 0;\n \t}\n \n+\trc = sfc_repr_proxy_rxq_attach(sa);\n+\tif (rc != 0)\n+\t\tgoto fail_rxq_attach;\n+\n \trc = sfc_repr_proxy_ports_init(sa);\n \tif (rc != 0)\n \t\tgoto fail_ports_init;\n@@ -277,6 +458,9 @@ sfc_repr_proxy_attach(struct sfc_adapter *sa)\n \tsfc_repr_proxy_ports_fini(sa);\n \n fail_ports_init:\n+\tsfc_repr_proxy_rxq_detach(sa);\n+\n+fail_rxq_attach:\n \tsfc_log_init(sa, \"failed: %s\", rte_strerror(rc));\n \treturn rc;\n }\n@@ -297,6 +481,7 @@ sfc_repr_proxy_detach(struct sfc_adapter *sa)\n \trte_service_map_lcore_set(rp->service_id, rp->service_core_id, 0);\n \trte_service_component_unregister(rp->service_id);\n \tsfc_repr_proxy_ports_fini(sa);\n+\tsfc_repr_proxy_rxq_detach(sa);\n \n \tsfc_log_init(sa, \"done\");\n }\n@@ -319,6 +504,10 @@ sfc_repr_proxy_start(struct sfc_adapter *sa)\n \t\treturn 0;\n \t}\n \n+\trc = sfc_repr_proxy_rxq_start(sa);\n+\tif (rc != 0)\n+\t\tgoto fail_rxq_start;\n+\n \t/* Service core may be in \"stopped\" state, start it */\n \trc = rte_service_lcore_start(rp->service_core_id);\n \tif (rc != 0 && rc != -EALREADY) {\n@@ -360,6 +549,9 @@ sfc_repr_proxy_start(struct sfc_adapter *sa)\n \t/* Service lcore may be shared and we never stop it */\n \n fail_start_core:\n+\tsfc_repr_proxy_rxq_stop(sa);\n+\n+fail_rxq_start:\n \tsfc_log_init(sa, \"failed: %s\", rte_strerror(rc));\n \treturn rc;\n }\n@@ -394,6 +586,8 @@ sfc_repr_proxy_stop(struct sfc_adapter *sa)\n \n \t/* Service lcore may be shared and we never stop it */\n \n+\tsfc_repr_proxy_rxq_stop(sa);\n+\n \trp->started = false;\n \n \tsfc_log_init(sa, \"done\");\ndiff --git a/drivers/net/sfc/sfc_repr_proxy.h b/drivers/net/sfc/sfc_repr_proxy.h\nindex bd7ad7148a..dca3fca2b9 100644\n--- a/drivers/net/sfc/sfc_repr_proxy.h\n+++ b/drivers/net/sfc/sfc_repr_proxy.h\n@@ -18,6 +18,7 @@\n #include \"efx.h\"\n \n #include \"sfc_repr.h\"\n+#include \"sfc_dp.h\"\n \n #ifdef __cplusplus\n extern \"C\" {\n@@ -31,6 +32,10 @@ extern \"C\" {\n #define SFC_REPR_PROXY_NB_TXQ_MIN\t(1)\n #define SFC_REPR_PROXY_NB_TXQ_MAX\t(1)\n \n+#define SFC_REPR_PROXY_RX_DESC_COUNT\t256\n+#define SFC_REPR_PROXY_RXQ_REFILL_LEVEL\t(SFC_REPR_PROXY_RX_DESC_COUNT / 4)\n+#define SFC_REPR_PROXY_RX_BURST\t\t32\n+\n struct sfc_repr_proxy_rxq {\n \tstruct rte_ring\t\t\t*ring;\n \tstruct rte_mempool\t\t*mb_pool;\n@@ -52,6 +57,8 @@ struct sfc_repr_proxy_port {\n struct sfc_repr_proxy_dp_rxq {\n \tstruct rte_mempool\t\t*mp;\n \tunsigned int\t\t\tref_count;\n+\n+\tsfc_sw_index_t\t\t\tsw_index;\n };\n \n enum sfc_repr_proxy_mbox_op {\n",
    "prefixes": [
        "17/38"
    ]
}