Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97424/?format=api
{ "id": 97424, "url": "https://patches.dpdk.org/api/patches/97424/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-7-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210827065717.1838258-7-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-7-andrew.rybchenko@oktetlabs.ru", "date": "2021-08-27T06:56:45", "name": "[06/38] net/sfc: support EF100 Tx override prefix", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9e067968e4bd278bbe61dd4e4cfb7a3383236a4f", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-7-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 18492, "url": "https://patches.dpdk.org/api/series/18492/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18492", "date": "2021-08-27T06:56:39", "name": "net/sfc: support port representors", "version": 1, "mbox": "https://patches.dpdk.org/series/18492/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/97424/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/97424/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4EB8CA0C43;\n\tFri, 27 Aug 2021 08:58:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5B04941271;\n\tFri, 27 Aug 2021 08:58:00 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 1E59D410E9\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:57:57 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id DE1DA7F6FC; Fri, 27 Aug 2021 09:57:56 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 6B2887F6D6;\n Fri, 27 Aug 2021 09:57:33 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6B2887F6D6", "Authentication-Results": "shelob.oktetlabs.ru/6B2887F6D6; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Igor Romanov <igor.romanov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Fri, 27 Aug 2021 09:56:45 +0300", "Message-Id": "<20210827065717.1838258-7-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/38] net/sfc: support EF100 Tx override prefix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nAdd internal mbuf dynamic flag and field to request EF100 native\nTx datapath to use Tx prefix descriptor to override egress m-port.\nOverriding egress m-port is necessary on representor Tx burst\nso that the packet will reach corresponding VF.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_dp.c | 46 ++++++++++++++++++++++++++++++++++\n drivers/net/sfc/sfc_dp.h | 25 ++++++++++++++++++\n drivers/net/sfc/sfc_ef100_tx.c | 25 ++++++++++++++++++\n drivers/net/sfc/sfc_ethdev.c | 4 +++\n 4 files changed, 100 insertions(+)", "diff": "diff --git a/drivers/net/sfc/sfc_dp.c b/drivers/net/sfc/sfc_dp.c\nindex 24ed0898c8..66a84c99c8 100644\n--- a/drivers/net/sfc/sfc_dp.c\n+++ b/drivers/net/sfc/sfc_dp.c\n@@ -12,6 +12,9 @@\n #include <errno.h>\n \n #include <rte_log.h>\n+#include <rte_mbuf_dyn.h>\n+\n+#include \"efx.h\"\n \n #include \"sfc_dp.h\"\n #include \"sfc_log.h\"\n@@ -77,3 +80,46 @@ sfc_dp_register(struct sfc_dp_list *head, struct sfc_dp *entry)\n \n \treturn 0;\n }\n+\n+uint64_t sfc_dp_mport_override;\n+int sfc_dp_mport_offset = -1;\n+\n+int\n+sfc_dp_mport_register(void)\n+{\n+\tstatic const struct rte_mbuf_dynfield mport = {\n+\t\t.name = \"rte_net_sfc_dynfield_mport\",\n+\t\t.size = sizeof(efx_mport_id_t),\n+\t\t.align = __alignof__(efx_mport_id_t),\n+\t};\n+\tstatic const struct rte_mbuf_dynflag mport_override = {\n+\t\t.name = \"rte_net_sfc_dynflag_mport_override\",\n+\t};\n+\n+\tint field_offset;\n+\tint flag;\n+\n+\tif (sfc_dp_mport_override != 0) {\n+\t\tSFC_GENERIC_LOG(INFO, \"%s() already registered\", __func__);\n+\t\treturn 0;\n+\t}\n+\n+\tfield_offset = rte_mbuf_dynfield_register(&mport);\n+\tif (field_offset < 0) {\n+\t\tSFC_GENERIC_LOG(ERR, \"%s() failed to register mport dynfield\",\n+\t\t\t\t__func__);\n+\t\treturn -1;\n+\t}\n+\n+\tflag = rte_mbuf_dynflag_register(&mport_override);\n+\tif (flag < 0) {\n+\t\tSFC_GENERIC_LOG(ERR, \"%s() failed to register mport dynflag\",\n+\t\t\t\t__func__);\n+\t\treturn -1;\n+\t}\n+\n+\tsfc_dp_mport_offset = field_offset;\n+\tsfc_dp_mport_override = UINT64_C(1) << flag;\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/net/sfc/sfc_dp.h b/drivers/net/sfc/sfc_dp.h\nindex 7fd8f34b0f..f3c6892426 100644\n--- a/drivers/net/sfc/sfc_dp.h\n+++ b/drivers/net/sfc/sfc_dp.h\n@@ -126,6 +126,31 @@ struct sfc_dp *sfc_dp_find_by_caps(struct sfc_dp_list *head,\n \t\t\t\t unsigned int avail_caps);\n int sfc_dp_register(struct sfc_dp_list *head, struct sfc_dp *entry);\n \n+/**\n+ * Dynamically registered mbuf flag \"mport_override\" (as a bitmask).\n+ *\n+ * If this flag is set in an mbuf then the dynamically registered\n+ * mbuf field \"mport\" holds a valid value. This is used to direct\n+ * port representor transmit traffic to the correct target port.\n+ */\n+extern uint64_t sfc_dp_mport_override;\n+\n+/**\n+ * Dynamically registered mbuf field \"mport\" (mbuf byte offset).\n+ *\n+ * If the dynamically registered \"mport_override\" flag is set in\n+ * an mbuf then the mbuf \"mport\" field holds a valid value. This\n+ * is used to direct port representor transmit traffic to the\n+ * correct target port.\n+ */\n+extern int sfc_dp_mport_offset;\n+\n+/**\n+ * Register dynamic mbuf flag and field which can be used to require Tx override\n+ * prefix descriptor with egress mport set.\n+ */\n+int sfc_dp_mport_register(void);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c\nindex 522e9a0d34..51eecbe832 100644\n--- a/drivers/net/sfc/sfc_ef100_tx.c\n+++ b/drivers/net/sfc/sfc_ef100_tx.c\n@@ -10,6 +10,7 @@\n #include <stdbool.h>\n \n #include <rte_mbuf.h>\n+#include <rte_mbuf_dyn.h>\n #include <rte_io.h>\n #include <rte_net.h>\n \n@@ -309,6 +310,19 @@ sfc_ef100_tx_reap(struct sfc_ef100_txq *txq)\n \tsfc_ef100_tx_reap_num_descs(txq, sfc_ef100_tx_process_events(txq));\n }\n \n+static void\n+sfc_ef100_tx_qdesc_prefix_create(const struct rte_mbuf *m, efx_oword_t *tx_desc)\n+{\n+\tefx_mport_id_t *mport_id =\n+\t\tRTE_MBUF_DYNFIELD(m, sfc_dp_mport_offset, efx_mport_id_t *);\n+\n+\tEFX_POPULATE_OWORD_3(*tx_desc,\n+\t\t\tESF_GZ_TX_PREFIX_EGRESS_MPORT,\n+\t\t\tmport_id->id,\n+\t\t\tESF_GZ_TX_PREFIX_EGRESS_MPORT_EN, 1,\n+\t\t\tESF_GZ_TX_DESC_TYPE, ESE_GZ_TX_DESC_TYPE_PREFIX);\n+}\n+\n static uint8_t\n sfc_ef100_tx_qdesc_cso_inner_l3(uint64_t tx_tunnel)\n {\n@@ -525,6 +539,11 @@ sfc_ef100_tx_pkt_descs_max(const struct rte_mbuf *m)\n \t\t\t\t SFC_MBUF_SEG_LEN_MAX));\n \t}\n \n+\tif (m->ol_flags & sfc_dp_mport_override) {\n+\t\t/* Tx override prefix descriptor will be used */\n+\t\textra_descs++;\n+\t}\n+\n \t/*\n \t * Any segment of scattered packet cannot be bigger than maximum\n \t * segment length. Make sure that subsequent segments do not need\n@@ -671,6 +690,12 @@ sfc_ef100_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\tbreak;\n \t\t}\n \n+\t\tif (m_seg->ol_flags & sfc_dp_mport_override) {\n+\t\t\tid = added++ & txq->ptr_mask;\n+\t\t\tsfc_ef100_tx_qdesc_prefix_create(m_seg,\n+\t\t\t\t\t\t\t &txq->txq_hw_ring[id]);\n+\t\t}\n+\n \t\tif (m_seg->ol_flags & PKT_TX_TCP_SEG) {\n \t\t\tm_seg = sfc_ef100_xmit_tso_pkt(txq, m_seg, &added);\n \t\t} else {\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 41add341a0..8e17189875 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -2245,6 +2245,10 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)\n \t\treturn 1;\n \t}\n \n+\trc = sfc_dp_mport_register();\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n \tsfc_register_dp();\n \n \tlogtype_main = sfc_register_logtype(&pci_dev->addr,\n", "prefixes": [ "06/38" ] }