Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97209/?format=api
{ "id": 97209, "url": "https://patches.dpdk.org/api/patches/97209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210823081214.9725-3-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210823081214.9725-3-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210823081214.9725-3-kalesh-anakkur.purayil@broadcom.com", "date": "2021-08-23T08:12:13", "name": "[2/3] net/bnxt: check FW capability for VLAN offloads", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "afb425e5dfccbd28f23fd5efc94fa94dfaf50252", "submitter": { "id": 1479, "url": "https://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210823081214.9725-3-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 18399, "url": "https://patches.dpdk.org/api/series/18399/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18399", "date": "2021-08-23T08:12:11", "name": "bnxt fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/18399/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/97209/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/97209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8FEAEA0C56;\n\tMon, 23 Aug 2021 09:51:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A33034114C;\n\tMon, 23 Aug 2021 09:51:43 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id BF0D541148\n for <dev@dpdk.org>; Mon, 23 Aug 2021 09:51:41 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 7E4972477B\n for <dev@dpdk.org>; Mon, 23 Aug 2021 00:51:40 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 7E4972477B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1629705101;\n bh=+MTJOXFI0fLSpFjeu5rDwJxl+zPPH+ICBou3U7AG/1g=;\n h=From:To:Subject:Date:In-Reply-To:References:From;\n b=ujRRUXNNIathI2MwK9oH5edBCBJhfALeXTCDoWIMS1DLPh2P7nYMrRo6NgWohC2Zw\n XofcBgjOiMIsgi6VLdLagZ/xO/Z2DGq5iBP3yQowUF5vMfkJ68wRS/fVwh9N7JyAXy\n H2ZGSG2Xjf4lm+7QeupMvII9fp0SgIhU9DbVRrEg=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Date": "Mon, 23 Aug 2021 13:42:13 +0530", "Message-Id": "<20210823081214.9725-3-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20210823081214.9725-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20210823081214.9725-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 2/3] net/bnxt: check FW capability for VLAN\n offloads", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nVLAN offload capability may be disabled in the FW. The driver\nshould not attempt to override or utilize this feature in such\nscenarios since it will not work as expected.\n\nFixes: 0a6d2a720078 (\"net/bnxt: get device infos\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 6 +++---\n drivers/net/bnxt/bnxt_ethdev.c | 4 ++++\n drivers/net/bnxt/bnxt_hwrm.c | 9 +++++++++\n 3 files changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 494a1ef..3ccc06c 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -577,8 +577,7 @@ struct bnxt_rep_info {\n \tETH_RSS_NONFRAG_IPV6_UDP |\t\\\n \tETH_RSS_LEVEL_MASK)\n \n-#define BNXT_DEV_TX_OFFLOAD_SUPPORT (DEV_TX_OFFLOAD_VLAN_INSERT | \\\n-\t\t\t\t DEV_TX_OFFLOAD_IPV4_CKSUM | \\\n+#define BNXT_DEV_TX_OFFLOAD_SUPPORT (DEV_TX_OFFLOAD_IPV4_CKSUM | \\\n \t\t\t\t DEV_TX_OFFLOAD_TCP_CKSUM | \\\n \t\t\t\t DEV_TX_OFFLOAD_UDP_CKSUM | \\\n \t\t\t\t DEV_TX_OFFLOAD_TCP_TSO | \\\n@@ -591,7 +590,6 @@ struct bnxt_rep_info {\n \t\t\t\t DEV_TX_OFFLOAD_MULTI_SEGS)\n \n #define BNXT_DEV_RX_OFFLOAD_SUPPORT (DEV_RX_OFFLOAD_VLAN_FILTER | \\\n-\t\t\t\t DEV_RX_OFFLOAD_VLAN_STRIP | \\\n \t\t\t\t DEV_RX_OFFLOAD_IPV4_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM | \\\n@@ -737,6 +735,7 @@ struct bnxt {\n #define BNXT_FW_CAP_ADV_FLOW_COUNTERS\tBIT(6)\n #define BNXT_FW_CAP_LINK_ADMIN\t\tBIT(7)\n #define BNXT_FW_CAP_TRUFLOW_EN\t\tBIT(8)\n+#define BNXT_FW_CAP_VLAN_TX_INSERT\tBIT(9)\n #define BNXT_TRUFLOW_EN(bp)\t((bp)->fw_cap & BNXT_FW_CAP_TRUFLOW_EN)\n \n \tpthread_mutex_t flow_lock;\n@@ -745,6 +744,7 @@ struct bnxt {\n #define BNXT_VNIC_CAP_COS_CLASSIFY\tBIT(0)\n #define BNXT_VNIC_CAP_OUTER_RSS\t\tBIT(1)\n #define BNXT_VNIC_CAP_RX_CMPL_V2\tBIT(2)\n+#define BNXT_VNIC_CAP_VLAN_RX_STRIP\tBIT(3)\n \tunsigned int\t\trx_nr_rings;\n \tunsigned int\t\trx_cp_nr_rings;\n \tunsigned int\t\trx_num_qs_per_vnic;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex de34a2f..e072771 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -981,9 +981,13 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,\n \tdev_info->rx_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT;\n \tif (bp->flags & BNXT_FLAG_PTP_SUPPORTED)\n \t\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TIMESTAMP;\n+\tif (bp->vnic_cap_flags & BNXT_VNIC_CAP_VLAN_RX_STRIP)\n+\t\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_VLAN_STRIP;\n \tdev_info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;\n \tdev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT |\n \t\t\t\t dev_info->tx_queue_offload_capa;\n+\tif (bp->fw_cap & BNXT_FW_CAP_VLAN_TX_INSERT)\n+\t\tdev_info->tx_offload_capa |= DEV_TX_OFFLOAD_VLAN_INSERT;\n \tdev_info->flow_type_rss_offloads = BNXT_ETH_RSS_SUPPORT;\n \n \tdev_info->speed_capa = bnxt_get_speed_capabilities(bp);\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 73deb41..d641d70 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -941,6 +941,10 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)\n \tif (flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_LINK_ADMIN_STATUS_SUPPORTED)\n \t\tbp->fw_cap |= BNXT_FW_CAP_LINK_ADMIN;\n \n+\tif (!(flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_VLAN_ACCELERATION_TX_DISABLED)) {\n+\t\tbp->fw_cap |= BNXT_FW_CAP_VLAN_TX_INSERT;\n+\t\tPMD_DRV_LOG(DEBUG, \"VLAN acceleration for TX is enabled\\n\");\n+\t}\n unlock:\n \tHWRM_UNLOCK();\n \n@@ -1001,6 +1005,11 @@ int bnxt_hwrm_vnic_qcaps(struct bnxt *bp)\n \tif (flags & HWRM_VNIC_QCAPS_OUTPUT_FLAGS_RX_CMPL_V2_CAP)\n \t\tbp->vnic_cap_flags |= BNXT_VNIC_CAP_RX_CMPL_V2;\n \n+\tif (flags & HWRM_VNIC_QCAPS_OUTPUT_FLAGS_VLAN_STRIP_CAP) {\n+\t\tbp->vnic_cap_flags |= BNXT_VNIC_CAP_VLAN_RX_STRIP;\n+\t\tPMD_DRV_LOG(DEBUG, \"Rx VLAN strip capability enabled\\n\");\n+\t}\n+\n \tbp->max_tpa_v2 = rte_le_to_cpu_16(resp->max_aggs_supported);\n \n \tHWRM_UNLOCK();\n", "prefixes": [ "2/3" ] }