Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96720/?format=api
{ "id": 96720, "url": "https://patches.dpdk.org/api/patches/96720/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1628487855-14030-1-git-send-email-wenxu@ucloud.cn/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1628487855-14030-1-git-send-email-wenxu@ucloud.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/1628487855-14030-1-git-send-email-wenxu@ucloud.cn", "date": "2021-08-09T05:44:15", "name": "net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "fd269fb9f6339689fcf3026efa343bcba2802dc6", "submitter": { "id": 2311, "url": "https://patches.dpdk.org/api/people/2311/?format=api", "name": null, "email": "wenxu@ucloud.cn" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1628487855-14030-1-git-send-email-wenxu@ucloud.cn/mbox/", "series": [ { "id": 18228, "url": "https://patches.dpdk.org/api/series/18228/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18228", "date": "2021-08-09T05:44:15", "name": "net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate", "version": 1, "mbox": "https://patches.dpdk.org/series/18228/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/96720/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/96720/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 020CCA0C4F;\n\tMon, 9 Aug 2021 07:44:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8CAC54069D;\n\tMon, 9 Aug 2021 07:44:22 +0200 (CEST)", "from mail-m2456.qiye.163.com (mail-m2456.qiye.163.com\n [220.194.24.56]) by mails.dpdk.org (Postfix) with ESMTP id 6C4124068A\n for <dev@dpdk.org>; Mon, 9 Aug 2021 07:44:20 +0200 (CEST)", "from localhost.localdomain (unknown [117.50.0.204])\n by mail-m2456.qiye.163.com (Hmail) with ESMTPA id 4C19770010C;\n Mon, 9 Aug 2021 13:44:16 +0800 (CST)" ], "From": "wenxu@ucloud.cn", "To": "getelson@nvidia.com", "Cc": "dev@dpdk.org", "Date": "Mon, 9 Aug 2021 13:44:15 +0800", "Message-Id": "<1628487855-14030-1-git-send-email-wenxu@ucloud.cn>", "X-Mailer": "git-send-email 1.8.3.1", "X-HM-Spam-Status": "e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1\n kWDxoPAgseWUFZKDYvK1lXWShZQUlCN1dZLVlBSVdZDwkaFQgSH1lBWUJCQkJWHUJJSBlJHUMdQ0\n IeVRkRExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG", "X-HM-Sender-Digest": "e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MT46Lhw5ET0ZSQguCy8YTxk2\n Sg9PFBRVSlVKTUlDT0NMQ05NT01NVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpKTFVO\n S1VLVUlLT1lXWQgBWUFISE5CNwY+", "X-HM-Tid": "0a7b2970b0c08c15kuqt4c19770010c", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix empty err msg in\n mlx5_flow_tunnel_validate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: wenxu <wenxu@ucloud.cn>\n\nIf the mlx5_flow_tunnel_validate validate the flow tunnel\nrule failed, the err_msg is empty in the rte_flow_error.\n\nFixes: 4ec6360de37d (\"net/mlx5: implement tunnel offload\")\n\nSigned-off-by: wenxu <wenxu@ucloud.cn>\n---\n drivers/net/mlx5/mlx5_flow.c | 43 ++++++++++++++++++++-----------------------\n 1 file changed, 20 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex e63a297..3c5aca0 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -9081,30 +9081,31 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh)\n \treturn err;\n }\n \n-static inline bool\n+static inline int\n mlx5_flow_tunnel_validate(struct rte_eth_dev *dev,\n \t\t\t struct rte_flow_tunnel *tunnel,\n-\t\t\t const char *err_msg)\n+\t\t\t struct rte_flow_error *error)\n {\n-\terr_msg = NULL;\n \tif (!is_tunnel_offload_active(dev)) {\n-\t\terr_msg = \"tunnel offload was not activated\";\n-\t\tgoto out;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,\n+\t\t\t\t\t \"tunnel offload was not activated\");\n \t} else if (!tunnel) {\n-\t\terr_msg = \"no application tunnel\";\n-\t\tgoto out;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,\n+\t\t\t\t\t \"no application tunnel\");\n \t}\n \n \tswitch (tunnel->type) {\n \tdefault:\n-\t\terr_msg = \"unsupported tunnel type\";\n-\t\tgoto out;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,\n+\t\t\t\t\t \"unsupported tunnel type\");\n \tcase RTE_FLOW_ITEM_TYPE_VXLAN:\n \t\tbreak;\n \t}\n \n-out:\n-\treturn !err_msg;\n+\treturn 0;\n }\n \n static int\n@@ -9116,13 +9117,11 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh)\n {\n \tint ret;\n \tstruct mlx5_flow_tunnel *tunnel;\n-\tconst char *err_msg = NULL;\n-\tbool verdict = mlx5_flow_tunnel_validate(dev, app_tunnel, err_msg);\n \n-\tif (!verdict)\n-\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,\n-\t\t\t\t\t err_msg);\n+\tret = mlx5_flow_tunnel_validate(dev, app_tunnel, error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n \tret = mlx5_get_flow_tunnel(dev, app_tunnel, &tunnel);\n \tif (ret < 0) {\n \t\treturn rte_flow_error_set(error, ret,\n@@ -9143,13 +9142,11 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh)\n {\n \tint ret;\n \tstruct mlx5_flow_tunnel *tunnel;\n-\tconst char *err_msg = NULL;\n-\tbool verdict = mlx5_flow_tunnel_validate(dev, app_tunnel, err_msg);\n \n-\tif (!verdict)\n-\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_HANDLE, NULL,\n-\t\t\t\t\t err_msg);\n+\tret = mlx5_flow_tunnel_validate(dev, app_tunnel, error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n \tret = mlx5_get_flow_tunnel(dev, app_tunnel, &tunnel);\n \tif (ret < 0) {\n \t\treturn rte_flow_error_set(error, ret,\n", "prefixes": [] }