Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96126/?format=api
{ "id": 96126, "url": "https://patches.dpdk.org/api/patches/96126/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210721063209.9724-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210721063209.9724-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210721063209.9724-1-alvinx.zhang@intel.com", "date": "2021-07-21T06:32:09", "name": "net/iavf: fix virtual channel RSS command error handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2191a073f6114388418293fbe1424b9e683230c3", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210721063209.9724-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 17923, "url": "https://patches.dpdk.org/api/series/17923/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17923", "date": "2021-07-21T06:32:09", "name": "net/iavf: fix virtual channel RSS command error handling", "version": 1, "mbox": "https://patches.dpdk.org/series/17923/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/96126/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/96126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55A1AA0C50;\n\tWed, 21 Jul 2021 08:32:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D4F0640689;\n\tWed, 21 Jul 2021 08:32:19 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id F2F344014E;\n Wed, 21 Jul 2021 08:32:17 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2021 23:32:16 -0700", "from shwdenpg235.ccr.corp.intel.com ([10.253.106.22])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2021 23:32:14 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10051\"; a=\"296942219\"", "E=Sophos;i=\"5.84,257,1620716400\"; d=\"scan'208\";a=\"296942219\"", "E=Sophos;i=\"5.84,257,1620716400\"; d=\"scan'208\";a=\"496508424\"" ], "From": "Alvin Zhang <alvinx.zhang@intel.com>", "To": "beilei.xing@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Wed, 21 Jul 2021 14:32:09 +0800", "Message-Id": "<20210721063209.9724-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/iavf: fix virtual channel RSS command error\n handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Kernel PF may not respond to virtual channel commands\nVIRTCHNL_OP_GET_RSS_HENA_CAPS and VIRTCHNL_OP_SET_RSS_HENA, which\nwill cause VF to fail to start.\n\nRSS offload type configuration is not a necessary feature for VF,\nso in order to improve VF compatibility, in this patch the PMD will\nignore the error result of above two commands and will print warnings\ninstead.\n\nFixes: 5a038d19962d (\"net/iavf: fix RSS configuration on i40e VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 26 ++++++++++++++------------\n 1 file changed, 14 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 41382c6..162f55d 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -259,7 +259,7 @@ struct rte_iavf_xstats_name_off {\n \treturn err;\n }\n \n-static int\n+static void\n iavf_config_rss_hf(struct iavf_adapter *adapter, uint64_t rss_hf)\n {\n \tstatic const uint64_t map_hena_rss[] = {\n@@ -319,8 +319,12 @@ struct rte_iavf_xstats_name_off {\n \tint ret;\n \n \tret = iavf_get_hena_caps(adapter, &caps);\n-\tif (ret)\n-\t\treturn ret;\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t \"fail to get supported RSS caps, lack PF support\");\n+\t\treturn;\n+\t}\n+\n \t/**\n \t * ETH_RSS_IPV4 and ETH_RSS_IPV6 can be considered as 2\n \t * generalizations of all other IPv4 and IPv6 RSS types.\n@@ -343,8 +347,11 @@ struct rte_iavf_xstats_name_off {\n \t}\n \n \tret = iavf_set_hena(adapter, hena);\n-\tif (ret)\n-\t\treturn ret;\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t \"fail to clean existing RSS, lack PF support\");\n+\t\treturn;\n+\t}\n \n \tif (valid_rss_hf & ipv4_rss)\n \t\tvalid_rss_hf |= rss_hf & ETH_RSS_IPV4;\n@@ -357,7 +364,6 @@ struct rte_iavf_xstats_name_off {\n \t\t\t rss_hf & ~valid_rss_hf);\n \n \tvf->rss_hf = valid_rss_hf;\n-\treturn 0;\n }\n \n static int\n@@ -409,9 +415,7 @@ struct rte_iavf_xstats_name_off {\n \t\t\treturn ret;\n \t\t}\n \t} else {\n-\t\tret = iavf_config_rss_hf(adapter, rss_conf->rss_hf);\n-\t\tif (ret != -ENOTSUP)\n-\t\t\treturn ret;\n+\t\tiavf_config_rss_hf(adapter, rss_conf->rss_hf);\n \t}\n \n \treturn 0;\n@@ -1400,9 +1404,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,\n \t\t\treturn ret;\n \t\t}\n \t} else {\n-\t\tret = iavf_config_rss_hf(adapter, rss_conf->rss_hf);\n-\t\tif (ret != -ENOTSUP)\n-\t\t\treturn ret;\n+\t\tiavf_config_rss_hf(adapter, rss_conf->rss_hf);\n \t}\n \n \treturn 0;\n", "prefixes": [] }