Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96078,
    "url": "https://patches.dpdk.org/api/patches/96078/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210720035125.14214-7-joyce.kong@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210720035125.14214-7-joyce.kong@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210720035125.14214-7-joyce.kong@arm.com",
    "date": "2021-07-20T03:51:23",
    "name": "[v3,6/8] test/mempool_perf: use compiler atomics for lcores sync",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4417035b3239122e58c4caf6244b4394f4a61fb1",
    "submitter": {
        "id": 970,
        "url": "https://patches.dpdk.org/api/people/970/?format=api",
        "name": "Joyce Kong",
        "email": "joyce.kong@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210720035125.14214-7-joyce.kong@arm.com/mbox/",
    "series": [
        {
            "id": 17901,
            "url": "https://patches.dpdk.org/api/series/17901/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17901",
            "date": "2021-07-20T03:51:17",
            "name": "use compiler atomic builtins for test",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/17901/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/96078/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/96078/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B11E3A0C43;\n\tTue, 20 Jul 2021 05:52:33 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4882F4117E;\n\tTue, 20 Jul 2021 05:52:24 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 424694117E\n for <dev@dpdk.org>; Tue, 20 Jul 2021 05:52:22 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE60D1FB;\n Mon, 19 Jul 2021 20:52:21 -0700 (PDT)",
            "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 56A6D3F694;\n Mon, 19 Jul 2021 20:52:18 -0700 (PDT)"
        ],
        "From": "Joyce Kong <joyce.kong@arm.com>",
        "To": "thomas@monjalon.net, david.marchand@redhat.com,\n roretzla@linux.microsoft.com, stephen@networkplumber.org,\n olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru,\n harry.van.haaren@intel.com, honnappa.nagarahalli@arm.com,\n ruifeng.wang@arm.com",
        "Cc": "dev@dpdk.org,\n\tnd@arm.com",
        "Date": "Mon, 19 Jul 2021 22:51:23 -0500",
        "Message-Id": "<20210720035125.14214-7-joyce.kong@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20210720035125.14214-1-joyce.kong@arm.com>",
        "References": "<20210616025459.22717-1-joyce.kong@arm.com>\n <20210720035125.14214-1-joyce.kong@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v3 6/8] test/mempool_perf: use compiler atomics\n for lcores sync",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Convert rte_atomic usages to compiler atomic built-ins for lcores\nsync in mempool_perf testcases. Meanwhile, remove unnecessary\nsynchro init as it would be set to 0 when launching cores.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_mempool_perf.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/app/test/test_mempool_perf.c b/app/test/test_mempool_perf.c\nindex d7d0aaa334..8f629736e8 100644\n--- a/app/test/test_mempool_perf.c\n+++ b/app/test/test_mempool_perf.c\n@@ -20,7 +20,6 @@\n #include <rte_eal.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n-#include <rte_atomic.h>\n #include <rte_branch_prediction.h>\n #include <rte_mempool.h>\n #include <rte_spinlock.h>\n@@ -83,7 +82,7 @@\n static int use_external_cache;\n static unsigned external_cache_size = RTE_MEMPOOL_CACHE_MAX_SIZE;\n \n-static rte_atomic32_t synchro;\n+static uint32_t synchro;\n \n /* number of objects in one bulk operation (get or put) */\n static unsigned n_get_bulk;\n@@ -145,7 +144,7 @@ per_lcore_mempool_test(void *arg)\n \n \t/* wait synchro for workers */\n \tif (lcore_id != rte_get_main_lcore())\n-\t\twhile (rte_atomic32_read(&synchro) == 0);\n+\t\trte_wait_until_equal_32(&synchro, 1, __ATOMIC_RELAXED);\n \n \tstart_cycles = rte_get_timer_cycles();\n \n@@ -198,7 +197,7 @@ launch_cores(struct rte_mempool *mp, unsigned int cores)\n \tint ret;\n \tunsigned cores_save = cores;\n \n-\trte_atomic32_set(&synchro, 0);\n+\t__atomic_store_n(&synchro, 0, __ATOMIC_RELAXED);\n \n \t/* reset stats */\n \tmemset(stats, 0, sizeof(stats));\n@@ -223,7 +222,7 @@ launch_cores(struct rte_mempool *mp, unsigned int cores)\n \t}\n \n \t/* start synchro and launch test on main */\n-\trte_atomic32_set(&synchro, 1);\n+\t__atomic_store_n(&synchro, 1, __ATOMIC_RELAXED);\n \n \tret = per_lcore_mempool_test(mp);\n \n@@ -288,8 +287,6 @@ test_mempool_perf(void)\n \tconst char *default_pool_ops;\n \tint ret = -1;\n \n-\trte_atomic32_init(&synchro);\n-\n \t/* create a mempool (without cache) */\n \tmp_nocache = rte_mempool_create(\"perf_test_nocache\", MEMPOOL_SIZE,\n \t\t\t\t\tMEMPOOL_ELT_SIZE, 0, 0,\n",
    "prefixes": [
        "v3",
        "6/8"
    ]
}