Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95791/?format=api
{ "id": 95791, "url": "https://patches.dpdk.org/api/patches/95791/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210713131714.964500-1-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210713131714.964500-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210713131714.964500-1-thomas@monjalon.net", "date": "2021-07-13T13:17:13", "name": "ethdev: avoid unregistering a non-allocated callback", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "ab5d0c9160bd79b9a067be814ad46b08d3201e3d", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210713131714.964500-1-thomas@monjalon.net/mbox/", "series": [ { "id": 17803, "url": "https://patches.dpdk.org/api/series/17803/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17803", "date": "2021-07-13T13:17:13", "name": "ethdev: avoid unregistering a non-allocated callback", "version": 1, "mbox": "https://patches.dpdk.org/series/17803/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95791/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/95791/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D8F2A0C51;\n\tTue, 13 Jul 2021 15:17:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3595241285;\n\tTue, 13 Jul 2021 15:17:30 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7E7A54127F;\n Tue, 13 Jul 2021 15:17:29 +0200 (CEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id 2FC905C00E1;\n Tue, 13 Jul 2021 09:17:29 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Tue, 13 Jul 2021 09:17:29 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Tue,\n 13 Jul 2021 09:17:27 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding; s=fm1; bh=6D6RNjqDiKjnnN58kGF3iyiLeJ\n zCQVr0MS8RYKdlJWA=; b=3ef+n0Qn9pWK5C8z8cm2rzCWitVomG3+SWZzCdbgYB\n kkIxJLrI1qm4goY4ijJT+yFfHIrl3wz7WnNHpLnKcNxbO6s09ze/B3eaftM835vs\n 3d2KYZDBtk3ORZATiywrWGyCKYvNMOvhKC7MnilOBWEStAGqm/LAWvMLXCaAXofj\n jNR+LFIvRSlhmJLi0aXF7qyio7oZyGeKVSDDDuKa/tdA0Fw9hPD01k1mhrQmJtzZ\n hV4/9IXTDw9AK9BbsWlVVM7bIc6M3nWguzXDcaVVLrLwTYehR6KVN2MWv9C54ryQ\n QzmeaG5SbkXcpdZmnS8BiGzl5hyVkfnfk4D4yvG7BjIA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6D6RNjqDiKjnnN58k\n GF3iyiLeJzCQVr0MS8RYKdlJWA=; b=Whm38gmMIXzyjnnvoZsCNj7pjC5txFeJJ\n eB39dWEBxDarfU0/J9tJrR6wYG93f/5E2OdOumG4hBJ/zwsG3KSOt2F56mg1b95F\n qMkc07Wn2IZZG9JiBejYqPwF01RA6gHY0P0ZU3gFYGYNPc+CSdQRlZBTuE7nODvY\n +RqRZPhoZuG0LwTnDDQ+3m6Q3IQZGaDminhDxYWAMUbQb35VRUrypdeAa8qN7k2H\n aROXJ/+4CVAFECu9Yarz8k74ranVW9oCgF4IVcuxK6Jr9MRFI9DNU7pGu+UaMMGi\n qOxEQGIx1iQFgLbsaqQTGUXGgnxwYecbZTLFlLJMEHDGPAVcM6gsQ==" ], "X-ME-Sender": "<xms:aJLtYFm0Blwz2AWWEtnFgzX0nUUAjgOHWPoSH-qJK5y4HT99Thyghg>\n <xme:aJLtYA3c5Oxax_nqsFgndNWEqjRxHBewfs4yT6hAQQzjxMpKJO_ZUTYiEb6aPpMuo\n vYiMI1oyfSm57X7_Q>", "X-ME-Received": "\n <xmr:aJLtYLq3gZTQOSCB8lZabcYCbSbjT6AT2VxlfrVdC-QmKe7pXMzen6gBvh6DFAtMx054ZEnTnRSaYU_UtH385NhY76seGtw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvtddrudehgdehfecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfo\n ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg\n htthgvrhhnpedvledvudehvdduudevuedvveehgeduleegiefgjeehudehtddtgeduffej\n iefhgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe\n hthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:aJLtYFnCp7ZjWCjWpQBxTBtVoOs2U1-M6cZ-Bq8m69szetb8Jp4S1w>\n <xmx:aJLtYD16WRL4VOaTOwyfGKNlU2n-5WFe2wFg8hkrOFcGjuMrLI2VZg>\n <xmx:aJLtYEt2DkulJ42knnuUbesDTN7lNG80KMLvZX-T9kUg6hhxmr03lQ>\n <xmx:aZLtYEw61TudPUrcys2ESQ5rss5BnymZ42ezwu5KbN8r5X670VLDww>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Matan Azrad <matan@mellanox.com>", "Date": "Tue, 13 Jul 2021 15:17:13 +0200", "Message-Id": "<20210713131714.964500-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated\n callback", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When registering a new event callback, if allocation fails,\nthere is no need for unregistering the callback,\nbecause it is not registered.\n\nFixes: 9ec0b3869d8d (\"ethdev: allow event registration for all ports\")\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/ethdev/rte_ethdev.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 9d95cd11e1..1731854628 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -4649,8 +4649,6 @@ rte_eth_dev_callback_register(uint16_t port_id,\n \t\t\t\t\t\t user_cb, next);\n \t\t\t} else {\n \t\t\t\trte_spinlock_unlock(ð_dev_cb_lock);\n-\t\t\t\trte_eth_dev_callback_unregister(port_id, event,\n-\t\t\t\t\t\t\t\tcb_fn, cb_arg);\n \t\t\t\treturn -ENOMEM;\n \t\t\t}\n \n", "prefixes": [] }