Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95607/?format=api
https://patches.dpdk.org/api/patches/95607/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210709153725.87348-1-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210709153725.87348-1-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210709153725.87348-1-ajit.khaparde@broadcom.com", "date": "2021-07-09T15:37:25", "name": "[v2] net/bnxt: fix build failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "90cc10a2a2b92ef0576b9f6535d1df6ea7c1b4e5", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210709153725.87348-1-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 17741, "url": "https://patches.dpdk.org/api/series/17741/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17741", "date": "2021-07-09T15:37:25", "name": "[v2] net/bnxt: fix build failure", "version": 2, "mbox": "https://patches.dpdk.org/series/17741/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95607/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/95607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A308AA0548;\n\tFri, 9 Jul 2021 17:37:41 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6ED79410F9;\n\tFri, 9 Jul 2021 17:37:41 +0200 (CEST)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id CDB184014D\n for <dev@dpdk.org>; Fri, 9 Jul 2021 17:37:39 +0200 (CEST)", "by mail-pl1-f172.google.com with SMTP id u3so85475plf.5\n for <dev@dpdk.org>; Fri, 09 Jul 2021 08:37:39 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id n22sm7164098pff.57.2021.07.09.08.37.34\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 09 Jul 2021 08:37:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=G9GyILbj6z8QVhK67ZMzKci3AAW+wj5jFU9biQ8TSHc=;\n b=aQUbkDEd50YkR1yoTrHz46nfLhUgQScQ5E927D5qnRQZU2GAllMMYodSgA8Cb42RlP\n CSClkKGkXZ004BuNffK+35r7zbT4lDUYIV//AIdzi36F7UaZbECaDBKxpIBu37fg2rsY\n mrBl32CEX+OB0og+DRXpuyveBOliRPW1y0c5g=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=G9GyILbj6z8QVhK67ZMzKci3AAW+wj5jFU9biQ8TSHc=;\n b=NRowVrPDrh80uBw6PCvB415jii9BI+Dqf0gKlGeb9M7J9PmmkxTAAcC8NNznDbF5A3\n KvQ02P8BlPdBApdR0JauSCpiPJWWteO29ROMzCIKZBOcM2BBqP/a5n5g2ZWkSwcT8++o\n q6UCx1Ues6Y+LD2NOztB2L80cgdN1AkVpiTo18cbqlCkcEzLyBBltIvKYKv2sziVO7G0\n AwyKiAgb+3j1wnSn8ZB0yXksiEFq5xZPywV+KvMi6t2zFnvBmO51ESCCfi+YUETzQkBn\n d3ht/bax5XSUK6mAxG0AiTlEhazBDd41+A4p2bo6WSOBCPotzLizh0oJ2k0p6bL1Uz60\n mPcg==", "X-Gm-Message-State": "AOAM5335NF9lmvtZYufDyQf5U8wN1UC6nfbv6kbVjB9JBx0Y6HNKR90V\n 8xehTYvjEj9/p2SdTis5lTsPFsHfvA07yj0JTicA3hoAwOQZRN6PlmTrV7RVvIV1Px3i1PGnuxa\n tbgXIeR3MxF5LRy/nzSywrI+Ca5NkCS1hPRDq2wydWlYMMVvxOvbtPS7R+AQGT8Q=", "X-Google-Smtp-Source": "\n ABdhPJxQhUIV40BL/Fb7XVLg/aCvsG4PTrl0MO57KU5EQsyXQkCiDPUcYAKoUgyEXiHWKcFWEiX2Xg==", "X-Received": "by 2002:a17:902:d64d:b029:12a:cd06:45d3 with SMTP id\n y13-20020a170902d64db029012acd0645d3mr6308749plh.47.1625845058474;\n Fri, 09 Jul 2021 08:37:38 -0700 (PDT)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Kishore Padmanabha <kishore.padmanabha@broadcom.com>", "Date": "Fri, 9 Jul 2021 08:37:25 -0700", "Message-Id": "<20210709153725.87348-1-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "\n <CACZ4nht9RRVFiDLfc35G+Lpekuagw+c1-p7mH1iRa+2rcqhJBA@mail.gmail.com>", "References": "\n <CACZ4nht9RRVFiDLfc35G+Lpekuagw+c1-p7mH1iRa+2rcqhJBA@mail.gmail.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"00000000000034876a05c6b28df9\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH v2] net/bnxt: fix build failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix build failures because of uninitialized variables.\n\n../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function ‘ulp_mapper_index_tbl_process’:\n../drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:43: error: ‘*(unsigned int *)((char *)&glb_res + offsetof(struct bnxt_ulp_glb_resource_info, resource_func))’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n 2252 | struct bnxt_ulp_glb_resource_info glb_res;\n | ^~~~~~~\n../drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:43: error: ‘glb_res.resource_type’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n\n../drivers/net/bnxt/tf_core/dpool.c: In function ‘dpool_defrag’:\n../drivers/net/bnxt/tf_core/dpool.c:95:18: error: ‘index’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n 95 | uint32_t index;\n | ^~~~~\n\nFixes: 05b405d58148 (\"net/bnxt: add dpool allocator for EM allocation\")\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\nv1->v2: update commit log to show the build error encountered.\n---\n drivers/net/bnxt/tf_core/dpool.c | 1 +\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 2 +-\n 2 files changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/dpool.c b/drivers/net/bnxt/tf_core/dpool.c\nindex 0dae42b1bb..145efa486f 100644\n--- a/drivers/net/bnxt/tf_core/dpool.c\n+++ b/drivers/net/bnxt/tf_core/dpool.c\n@@ -125,6 +125,7 @@ int dpool_defrag(struct dpool *dpool,\n \t\tlargest_free_size = 0;\n \t\tlargest_free_index = 0;\n \t\tcount = 0;\n+\t\tindex = 0;\n \n \t\tfor (i = 0; i < dpool->size; i++) {\n \t\t\tif (DP_IS_FREE(dpool->entry[i].flags)) {\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex acd9f996e8..871dbad0fe 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -2249,7 +2249,7 @@ ulp_mapper_index_tbl_process(struct bnxt_ulp_mapper_parms *parms,\n \tstruct tf_free_tbl_entry_parms free_parms = { 0 };\n \tuint32_t tbl_scope_id;\n \tstruct tf *tfp;\n-\tstruct bnxt_ulp_glb_resource_info glb_res;\n+\tstruct bnxt_ulp_glb_resource_info glb_res = { 0 };\n \tuint16_t bit_size;\n \tbool alloc = false;\n \tbool write = false;\n", "prefixes": [ "v2" ] }{ "id": 95607, "url": "