Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95425/?format=api
{ "id": 95425, "url": "https://patches.dpdk.org/api/patches/95425/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210706202841.661302-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210706202841.661302-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210706202841.661302-5-bruce.richardson@intel.com", "date": "2021-07-06T20:28:36", "name": "[RFC,UPDATE,4/9] dmadev: remove xstats functions", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "8eadc1d3be8cfcbc4ae4098e326943d5ccac061f", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210706202841.661302-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 17674, "url": "https://patches.dpdk.org/api/series/17674/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17674", "date": "2021-07-06T20:28:32", "name": "dmadev rfc suggested updates", "version": 1, "mbox": "https://patches.dpdk.org/series/17674/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95425/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/95425/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6D6EA0C48;\n\tTue, 6 Jul 2021 22:29:26 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 90891413DA;\n\tTue, 6 Jul 2021 22:29:14 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 217BC4133B\n for <dev@dpdk.org>; Tue, 6 Jul 2021 22:29:11 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2021 13:29:11 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.29])\n by FMSMGA003.fm.intel.com with ESMTP; 06 Jul 2021 13:29:09 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10037\"; a=\"196470327\"", "E=Sophos;i=\"5.83,329,1616482800\"; d=\"scan'208\";a=\"196470327\"", "E=Sophos;i=\"5.83,329,1616482800\"; d=\"scan'208\";a=\"486522072\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Chengwen Feng <fengchengwen@huawei.com>,\n Jerin Jacob <jerinjacobk@gmail.com>, Jerin Jacob <jerinj@marvell.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 6 Jul 2021 21:28:36 +0100", "Message-Id": "<20210706202841.661302-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210706202841.661302-1-bruce.richardson@intel.com>", "References": "<1625231891-2963-1-git-send-email-fengchengwen@huawei.com>\n <20210706202841.661302-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC UPDATE PATCH 4/9] dmadev: remove xstats functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "remove the xstats function calls, as they are not needed for this class\nas-yet.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/dmadev/rte_dmadev.c | 63 --------------------------\n lib/dmadev/rte_dmadev.h | 89 -------------------------------------\n lib/dmadev/rte_dmadev_pmd.h | 19 --------\n lib/dmadev/version.map | 3 --\n 4 files changed, 174 deletions(-)", "diff": "diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c\nindex ffd7c5b97..fed168675 100644\n--- a/lib/dmadev/rte_dmadev.c\n+++ b/lib/dmadev/rte_dmadev.c\n@@ -282,69 +282,6 @@ rte_dmadev_stats_reset(uint16_t dev_id, int vq_id)\n \treturn (*dev->dev_ops->stats_reset)(dev, vq_id);\n }\n \n-static int\n-xstats_get_count(uint16_t dev_id)\n-{\n-\tstruct rte_dmadev *dev = &rte_dmadevices[dev_id];\n-\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->xstats_get_names, -ENOTSUP);\n-\n-\treturn (*dev->dev_ops->xstats_get_names)(dev, NULL, 0);\n-}\n-\n-int\n-rte_dmadev_xstats_names_get(uint16_t dev_id,\n-\t\t\t struct rte_dmadev_xstats_name *xstats_names,\n-\t\t\t uint32_t size)\n-{\n-\tstruct rte_dmadev *dev;\n-\tint cnt_expected_entries;\n-\n-\tRTE_DMADEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);\n-\n-\tcnt_expected_entries = xstats_get_count(dev_id);\n-\n-\tif (xstats_names == NULL || cnt_expected_entries < 0 ||\n-\t (int)size < cnt_expected_entries || size == 0)\n-\t\treturn cnt_expected_entries;\n-\n-\tdev = &rte_dmadevices[dev_id];\n-\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->xstats_get_names, -ENOTSUP);\n-\treturn (*dev->dev_ops->xstats_get_names)(dev, xstats_names, size);\n-}\n-\n-int\n-rte_dmadev_xstats_get(uint16_t dev_id, const uint32_t ids[],\n-\t\t uint64_t values[], uint32_t n)\n-{\n-\tstruct rte_dmadev *dev;\n-\n-\tRTE_DMADEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);\n-\tRTE_FUNC_PTR_OR_ERR_RET(ids, -EINVAL);\n-\tRTE_FUNC_PTR_OR_ERR_RET(values, -EINVAL);\n-\n-\tdev = &rte_dmadevices[dev_id];\n-\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->xstats_get, -ENOTSUP);\n-\n-\treturn (*dev->dev_ops->xstats_get)(dev, ids, values, n);\n-}\n-\n-int\n-rte_dmadev_xstats_reset(uint16_t dev_id, const uint32_t ids[], uint32_t nb_ids)\n-{\n-\tstruct rte_dmadev *dev;\n-\n-\tRTE_DMADEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);\n-\n-\tdev = &rte_dmadevices[dev_id];\n-\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->xstats_reset, -ENOTSUP);\n-\n-\treturn (*dev->dev_ops->xstats_reset)(dev, ids, nb_ids);\n-}\n-\n int\n rte_dmadev_dump(uint16_t dev_id, FILE *f)\n {\ndiff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h\nindex d64df17bd..2bfc0b619 100644\n--- a/lib/dmadev/rte_dmadev.h\n+++ b/lib/dmadev/rte_dmadev.h\n@@ -824,95 +824,6 @@ __rte_experimental\n int\n rte_dmadev_stats_reset(uint16_t dev_id, int vq_id);\n \n-/** Maximum name length for extended statistics counters */\n-#define RTE_DMA_DEV_XSTATS_NAME_SIZE 64\n-\n-/**\n- * A name-key lookup element for extended statistics.\n- *\n- * This structure is used to map between names and ID numbers\n- * for extended ethdev statistics.\n- */\n-struct rte_dmadev_xstats_name {\n-\tchar name[RTE_DMA_DEV_XSTATS_NAME_SIZE];\n-};\n-\n-/**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n- * Retrieve names of extended statistics of a DMA device.\n- *\n- * @param dev_id\n- * The identifier of the device.\n- * @param[out] xstats_names\n- * Block of memory to insert names into. Must be at least size in capacity.\n- * If set to NULL, function returns required capacity.\n- * @param size\n- * Capacity of xstats_names (number of names).\n- * @return\n- * - positive value lower or equal to size: success. The return value\n- * is the number of entries filled in the stats table.\n- * - positive value higher than size: error, the given statistics table\n- * is too small. The return value corresponds to the size that should\n- * be given to succeed. The entries in the table are not valid and\n- * shall not be used by the caller.\n- * - negative value on error.\n- */\n-__rte_experimental\n-int\n-rte_dmadev_xstats_names_get(uint16_t dev_id,\n-\t\t\t struct rte_dmadev_xstats_name *xstats_names,\n-\t\t\t uint32_t size);\n-\n-/**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n- * Retrieve extended statistics of a DMA device.\n- *\n- * @param dev_id\n- * The identifier of the device.\n- * @param ids\n- * The id numbers of the stats to get. The ids can be got from the stat\n- * position in the stat list from rte_dmadev_get_xstats_names().\n- * @param[out] values\n- * The values for each stats request by ID.\n- * @param n\n- * The number of stats requested.\n- *\n- * @return\n- * - positive value: number of stat entries filled into the values array.\n- * - negative value on error.\n- */\n-__rte_experimental\n-int\n-rte_dmadev_xstats_get(uint16_t dev_id, const uint32_t ids[],\n-\t\t uint64_t values[], uint32_t n);\n-\n-/**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n- * Reset the values of the xstats of the selected component in the device.\n- *\n- * @param dev_id\n- * The identifier of the device.\n- * @param ids\n- * Selects specific statistics to be reset. When NULL, all statistics\n- * will be reset. If non-NULL, must point to array of at least\n- * *nb_ids* size.\n- * @param nb_ids\n- * The number of ids available from the *ids* array. Ignored when ids is NULL.\n- *\n- * @return\n- * - zero: successfully reset the statistics to zero.\n- * - negative value on error.\n- */\n-__rte_experimental\n-int\n-rte_dmadev_xstats_reset(uint16_t dev_id, const uint32_t ids[], uint32_t nb_ids);\n-\n /**\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice.\ndiff --git a/lib/dmadev/rte_dmadev_pmd.h b/lib/dmadev/rte_dmadev_pmd.h\nindex 428ddc943..d0ec43af6 100644\n--- a/lib/dmadev/rte_dmadev_pmd.h\n+++ b/lib/dmadev/rte_dmadev_pmd.h\n@@ -120,19 +120,6 @@ typedef int (*dmadev_stats_get_t)(struct rte_dmadev *dev, int vq_id,\n typedef int (*dmadev_stats_reset_t)(struct rte_dmadev *dev, int vq_id);\n /**< @internal Function used to reset basic statistics. */\n \n-typedef int (*dmadev_xstats_get_names_t)(const struct rte_dmadev *dev,\n-\t\tstruct rte_dmadev_xstats_name *xstats_names,\n-\t\tuint32_t size);\n-/**< @internal Function used to get names of extended stats. */\n-\n-typedef int (*dmadev_xstats_get_t)(const struct rte_dmadev *dev,\n-\t\tconst uint32_t ids[], uint64_t values[], uint32_t n);\n-/**< @internal Function used to retrieve extended stats. */\n-\n-typedef int (*dmadev_xstats_reset_t)(struct rte_dmadev *dev,\n-\t\t\t\t const uint32_t ids[], uint32_t nb_ids);\n-/**< @internal Function used to reset extended stats. */\n-\n typedef int (*dmadev_selftest_t)(uint16_t dev_id);\n /**< @internal Function used to start dmadev selftest. */\n \n@@ -164,12 +151,6 @@ struct rte_dmadev_ops {\n \tdmadev_stats_get_t stats_get;\n \t/**< Reset basic statistics. */\n \tdmadev_stats_reset_t stats_reset;\n-\t/**< Get names of extended stats. */\n-\tdmadev_xstats_get_names_t xstats_get_names;\n-\t/**< Get extended statistics. */\n-\tdmadev_xstats_get_t xstats_get;\n-\t/**< Reset extended statistics values. */\n-\tdmadev_xstats_reset_t xstats_reset;\n \n \t/**< Device selftest function */\n \tdmadev_selftest_t dev_selftest;\ndiff --git a/lib/dmadev/version.map b/lib/dmadev/version.map\nindex ed051d54f..a4d6b539a 100644\n--- a/lib/dmadev/version.map\n+++ b/lib/dmadev/version.map\n@@ -27,9 +27,6 @@ EXPERIMENTAL {\n \trte_dmadev_completed_fails;\n \trte_dmadev_stats_get;\n \trte_dmadev_stats_reset;\n-\trte_dmadev_xstats_names_get;\n-\trte_dmadev_xstats_get;\n-\trte_dmadev_xstats_reset;\n \trte_dmadev_selftest;\n \n \tlocal: *;\n", "prefixes": [ "RFC", "UPDATE", "4/9" ] }