Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95030/?format=api
{ "id": 95030, "url": "https://patches.dpdk.org/api/patches/95030/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210630064036.105151-3-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210630064036.105151-3-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210630064036.105151-3-feifei.wang2@arm.com", "date": "2021-06-30T06:40:36", "name": "[v3,2/2] net/i40e: improve performance for vector Tx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a086289bbea3a3d6013c90b10fa890d65d687ade", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210630064036.105151-3-feifei.wang2@arm.com/mbox/", "series": [ { "id": 17539, "url": "https://patches.dpdk.org/api/series/17539/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17539", "date": "2021-06-30T06:40:34", "name": "net/i40e: improve free mbuf for Tx", "version": 3, "mbox": "https://patches.dpdk.org/series/17539/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95030/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/95030/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 54AD3A0A0F;\n\tWed, 30 Jun 2021 08:40:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A0CE541230;\n\tWed, 30 Jun 2021 08:40:50 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 3A09A41230\n for <dev@dpdk.org>; Wed, 30 Jun 2021 08:40:49 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8E5FD6E;\n Tue, 29 Jun 2021 23:40:48 -0700 (PDT)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.141])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C34203F5A1;\n Tue, 29 Jun 2021 23:40:46 -0700 (PDT)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Beilei Xing <beilei.xing@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Wed, 30 Jun 2021 14:40:36 +0800", "Message-Id": "<20210630064036.105151-3-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210630064036.105151-1-feifei.wang2@arm.com>", "References": "<20210527081714.1367611-1-feifei.wang2@arm.com>\n <20210630064036.105151-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/2] net/i40e: improve performance for vector\n Tx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For i40e vector Tx path, if tx_offload is set as FAST_FREE_MBUF mode,\nno mbuf fast free operations are executed. To fix this, add mbuf fast\nfree mode for vector Tx path.\n\nFurthermore, for i40e vector Tx path, if implement FAST_FREE_MBUF mode,\nit means per-queue all mbufs come from the same mempool and have\nrefcnt = 1. Thus we can use bulk free of the buffers when mbuf fast free\nmode is enabled.\n\nFor vector path in arm platform:\nIn n1sdp, performance is improved by 18.4%;\nIn thunderx2, performance is improved by 23%.\n\nFor vector path in x86 platform:\nNo performance changes.\n\nSuggested-by: Ruifeng Wang <ruifeng.wang@arm.com>\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_common.h | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h\nindex 16fcf0aec6..f52ed98d62 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_common.h\n+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h\n@@ -99,6 +99,16 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n \t * tx_next_dd - (tx_rs_thresh-1)\n \t */\n \ttxep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];\n+\n+\tif (txq->offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE) {\n+\t\tfor (i = 0; i < n; i++) {\n+\t\t\tfree[i] = txep[i].mbuf;\n+\t\t\ttxep[i].mbuf = NULL;\n+\t\t}\n+\t\trte_mempool_put_bulk(free[0]->pool, (void **)free, n);\n+\t\tgoto done;\n+\t}\n+\n \tm = rte_pktmbuf_prefree_seg(txep[0].mbuf);\n \tif (likely(m != NULL)) {\n \t\tfree[0] = m;\n@@ -126,6 +136,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n \t\t}\n \t}\n \n+done:\n \t/* buffers were freed, update counters */\n \ttxq->nb_tx_free = (uint16_t)(txq->nb_tx_free + txq->tx_rs_thresh);\n \ttxq->tx_next_dd = (uint16_t)(txq->tx_next_dd + txq->tx_rs_thresh);\n", "prefixes": [ "v3", "2/2" ] }