Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94997/?format=api
{ "id": 94997, "url": "https://patches.dpdk.org/api/patches/94997/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210629170658.19452-1-mohsin.kazmi14@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210629170658.19452-1-mohsin.kazmi14@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210629170658.19452-1-mohsin.kazmi14@gmail.com", "date": "2021-06-29T17:06:58", "name": "net: prepare the outer ipv4 hdr for checksum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a730030a266cbe80b666c45f43f19340821ed9ab", "submitter": { "id": 2267, "url": "https://patches.dpdk.org/api/people/2267/?format=api", "name": "Mohsin Kazmi", "email": "mohsin.kazmi14@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210629170658.19452-1-mohsin.kazmi14@gmail.com/mbox/", "series": [ { "id": 17529, "url": "https://patches.dpdk.org/api/series/17529/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17529", "date": "2021-06-29T17:06:58", "name": "net: prepare the outer ipv4 hdr for checksum", "version": 1, "mbox": "https://patches.dpdk.org/series/17529/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94997/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94997/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82896A0A0C;\n\tTue, 29 Jun 2021 19:09:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3AB55411A5;\n\tTue, 29 Jun 2021 19:09:03 +0200 (CEST)", "from mail-ej1-f42.google.com (mail-ej1-f42.google.com\n [209.85.218.42])\n by mails.dpdk.org (Postfix) with ESMTP id 102A340E01;\n Tue, 29 Jun 2021 19:09:02 +0200 (CEST)", "by mail-ej1-f42.google.com with SMTP id v20so19014261eji.10;\n Tue, 29 Jun 2021 10:09:02 -0700 (PDT)", "from v6dc-3.cisco.com ([2001:420:44f1:10:225:b5ff:fe52:22])\n by smtp.gmail.com with ESMTPSA id s4sm11612162edu.49.2021.06.29.10.09.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 29 Jun 2021 10:09:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id;\n bh=6Hyt4Vb7iI1Anc+amJMzx5M5oNBolYZKkCuxFyMg2bE=;\n b=CKpuwq80JxLhnIfN7dw8AT+c5hRl01oOl2rZENr9TKsDzCl3p+TQSgwruhWjE1bcBw\n 2cO25NZTHOGRW58AKNOGGwo/KOugqDaBaSG9TO2LTeXO1udLqW4J0CSkKOeOiEJsDrYw\n glZ5BHoaBAVu+3iST5OtmjyVN+p/ACdZp/pmHun5uhkvjfYcL6wLjm6jT7bHRE31V9n4\n I3jrgz8scrb41+bM3zOjdM5sW8G8/vS75w4obozROvUjw8ombWBhlPFxdAUniQ4uYUTG\n zx9wozW9MH4l2HWFogw7fcRqhcI2+wzsvJgrh+3XQARMoJfjkBDHx9ncllie9LgILbjB\n fnBA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=6Hyt4Vb7iI1Anc+amJMzx5M5oNBolYZKkCuxFyMg2bE=;\n b=nYiF3a0/bO0DN9WCHVT7jUWlPUBcFuXjrBKrW+w/ViQcKniVEp+MNwVE83UhIuhkCE\n +pNOwvWoD+A/rVuDR5t+k5kHPtn3d8dkoOy3H9tN7UOJOtWSsuxXNPa3VJnIrmrUr61U\n 7iI6Gu6sWjvqMLchwmsxBtW695YIo3CFeCTFLqqkWmGCP02BhghslWYAMIJtUhGvHs6d\n M3CQPtXoUJ7YGZSsJyQqs/VtO4gZU6a172bkB9WhOoJhh7+zqXHndjeqGbYho8DWQOjb\n 225daScc1XbpmnyYyHeys7OZMskk4fT5CaNQtmsc9drg6ei2Q8wk1SsIMsFotHgbRXDB\n KWpA==", "X-Gm-Message-State": "AOAM530MJlU5uDFGX3gZ7fHiXlFg0ZS3qGN+8Og0s5j01uL4z9rSF41W\n AvnyfNsSYa3JC7WXrjvoJyJQq/e3eW4sNT6m", "X-Google-Smtp-Source": "\n ABdhPJyeBgslt9q9H18j2xKNBfmEZrUQRJXmo4s/+8LSww/XyiJMbYELbSmynTqgCt+PF2eyMjrypg==", "X-Received": "by 2002:a17:906:9bef:: with SMTP id\n de47mr30174982ejc.78.1624986541606;\n Tue, 29 Jun 2021 10:09:01 -0700 (PDT)", "From": "Mohsin Kazmi <mohsin.kazmi14@gmail.com>", "To": "dev@dpdk.org", "Cc": "ray.kinsella@intel.com, Mohsin Kazmi <mohsin.kazmi14@gmail.com>,\n stable@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Thomas Monjalon <thomas.monjalon@6wind.com>,\n Tomasz Kulasek <tomaszx.kulasek@intel.com>", "Date": "Tue, 29 Jun 2021 19:06:58 +0200", "Message-Id": "<20210629170658.19452-1-mohsin.kazmi14@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Preparation the headers for the hardware offload\nmisses the outer ipv4 checksum offload.\nIt results in bad checksum computed by hardware NIC.\n\nThis patch fixes the issue by setting the outer ipv4\nchecksum field to 0.\n\nFixes: 4fb7e803eb1a (\"ethdev: add Tx preparation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>\nAcked-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n lib/net/rte_net.h | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h\nindex 434435ffa2..e47365099e 100644\n--- a/lib/net/rte_net.h\n+++ b/lib/net/rte_net.h\n@@ -128,8 +128,18 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)\n \tif (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG)))\n \t\treturn 0;\n \n-\tif (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6))\n+\tif (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {\n \t\tinner_l3_offset += m->outer_l2_len + m->outer_l3_len;\n+\t\t/*\n+\t\t * prepare outer ipv4 header checksum by setting it to 0,\n+\t\t * in order to be computed by hardware NICs.\n+\t\t */\n+\t\tif (ol_flags & PKT_TX_OUTER_IP_CKSUM) {\n+\t\t\tipv4_hdr = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\tstruct rte_ipv4_hdr *, m->outer_l2_len);\n+\t\t\tipv4_hdr->hdr_checksum = 0;\n+\t\t}\n+\t}\n \n \t/*\n \t * Check if headers are fragmented.\n", "prefixes": [] }