Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94978/?format=api
{ "id": 94978, "url": "https://patches.dpdk.org/api/patches/94978/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210629151907.28734-1-kai.ji@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210629151907.28734-1-kai.ji@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210629151907.28734-1-kai.ji@intel.com", "date": "2021-06-29T15:19:07", "name": "[v2] crypto/aesni_gcm: fix performance issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "659fc0f7cf0a7f0f4674b61ff905ae16628a013c", "submitter": { "id": 2202, "url": "https://patches.dpdk.org/api/people/2202/?format=api", "name": "Ji, Kai", "email": "kai.ji@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210629151907.28734-1-kai.ji@intel.com/mbox/", "series": [ { "id": 17524, "url": "https://patches.dpdk.org/api/series/17524/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17524", "date": "2021-06-29T15:19:07", "name": "[v2] crypto/aesni_gcm: fix performance issue", "version": 2, "mbox": "https://patches.dpdk.org/series/17524/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94978/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1BA7AA0A0C;\n\tTue, 29 Jun 2021 17:19:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A0F4C4117E;\n\tTue, 29 Jun 2021 17:19:13 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 5F2E240E01\n for <dev@dpdk.org>; Tue, 29 Jun 2021 17:19:12 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Jun 2021 08:19:11 -0700", "from silpixa00400272.ir.intel.com (HELO\n silpixa00400272.ger.corp.intel.com) ([10.237.223.111])\n by orsmga007.jf.intel.com with ESMTP; 29 Jun 2021 08:19:09 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10030\"; a=\"208113592\"", "E=Sophos;i=\"5.83,309,1616482800\"; d=\"scan'208\";a=\"208113592\"", "E=Sophos;i=\"5.83,309,1616482800\"; d=\"scan'208\";a=\"447076269\"" ], "X-ExtLoop1": "1", "From": "Kai Ji <kai.ji@intel.com>", "To": "dev@dpdk.org", "Cc": "roy.fan.zhang@intel.com, Kai Ji <kai.ji@intel.com>,\n pablo.de.lara.guarch@intel.com", "Date": "Tue, 29 Jun 2021 16:19:07 +0100", "Message-Id": "<20210629151907.28734-1-kai.ji@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210629123602.27702-1-kai.ji@intel.com>", "References": "<20210629123602.27702-1-kai.ji@intel.com>", "Subject": "[dpdk-dev] [dpdk-dev v2] crypto/aesni_gcm: fix performance issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes the aesni_gcm performance issue on systems with AVX512\nCPU flag presented but with VAES CPU flag missing, such as Skylake.\n\nFixes: 81fe96a0cece (\"crypto/aesni_gcm: use architecture independent API\")\nCc: pablo.de.lara.guarch@intel.com\n\nSigned-off-by: Kai Ji <kai.ji@intel.com>\n---\nv2: Checkpatch fix\n\n drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\nindex bc87e44a9d..886e2a5aaa 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n@@ -842,8 +842,14 @@ aesni_gcm_create(const char *name,\n \t\tinit_mb_mgr_avx2(mb_mgr);\n \t\tbreak;\n \tcase RTE_AESNI_GCM_AVX512:\n-\t\tdev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;\n-\t\tinit_mb_mgr_avx512(mb_mgr);\n+\t\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_VAES)) {\n+\t\t\tdev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;\n+\t\t\tinit_mb_mgr_avx512(mb_mgr);\n+\t\t} else {\n+\t\t\tdev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX2;\n+\t\t\tinit_mb_mgr_avx2(mb_mgr);\n+\t\t\tvector_mode = RTE_AESNI_GCM_AVX2;\n+\t\t}\n \t\tbreak;\n \tdefault:\n \t\tAESNI_GCM_LOG(ERR, \"Unsupported vector mode %u\\n\", vector_mode);\n", "prefixes": [ "v2" ] }