Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94920/?format=api
{ "id": 94920, "url": "https://patches.dpdk.org/api/patches/94920/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210628163434.77741-14-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210628163434.77741-14-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210628163434.77741-14-arkadiuszx.kusztal@intel.com", "date": "2021-06-28T16:34:31", "name": "[v2,13/16] common/qat: add service discovery to qat gen4", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b39ed7beedba81940d5d73c46dbbaebea2f03b6c", "submitter": { "id": 452, "url": "https://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210628163434.77741-14-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 17505, "url": "https://patches.dpdk.org/api/series/17505/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17505", "date": "2021-06-28T16:34:18", "name": "Add support for fourth generation of Intel QuickAssist Technology devices", "version": 2, "mbox": "https://patches.dpdk.org/series/17505/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94920/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94920/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 540AAA0A0C;\n\tMon, 28 Jun 2021 18:36:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A2534119B;\n\tMon, 28 Jun 2021 18:35:03 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id E9B9B4117E\n for <dev@dpdk.org>; Mon, 28 Jun 2021 18:35:01 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jun 2021 09:35:01 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by fmsmga008.fm.intel.com with ESMTP; 28 Jun 2021 09:35:00 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10029\"; a=\"206165958\"", "E=Sophos;i=\"5.83,306,1616482800\"; d=\"scan'208\";a=\"206165958\"", "E=Sophos;i=\"5.83,306,1616482800\"; d=\"scan'208\";a=\"456395720\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, fiona.trahe@intel.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Mon, 28 Jun 2021 17:34:31 +0100", "Message-Id": "<20210628163434.77741-14-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20210628163434.77741-1-arkadiuszx.kusztal@intel.com>", "References": "<20210628163434.77741-1-arkadiuszx.kusztal@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 13/16] common/qat: add service discovery to\n qat gen4", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit adds service discovery to generation four\nof Intel QuickAssist Technology devices.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/common/qat/qat_common.h | 8 ++++++\n drivers/common/qat/qat_device.c | 20 ++++++++++++---\n drivers/common/qat/qat_device.h | 3 +++\n drivers/common/qat/qat_qp.c | 43 +++++++++++++++++++++++++--------\n drivers/common/qat/qat_qp.h | 3 +--\n 5 files changed, 62 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/common/qat/qat_common.h b/drivers/common/qat/qat_common.h\nindex 845c8d99ab..23715085f4 100644\n--- a/drivers/common/qat/qat_common.h\n+++ b/drivers/common/qat/qat_common.h\n@@ -29,6 +29,14 @@ enum qat_service_type {\n \tQAT_SERVICE_INVALID\n };\n \n+enum qat_svc_list {\n+\tQAT_SVC_UNUSED = 0,\n+\tQAT_SVC_CRYPTO = 1,\n+\tQAT_SVC_COMPRESSION = 2,\n+\tQAT_SVC_SYM = 3,\n+\tQAT_SVC_ASYM = 4,\n+};\n+\n #define QAT_MAX_SERVICES\t\t(QAT_SERVICE_INVALID)\n \n /**< Common struct for scatter-gather list operations */\ndiff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c\nindex e52d90fcd7..1b967cbcf7 100644\n--- a/drivers/common/qat/qat_device.c\n+++ b/drivers/common/qat/qat_device.c\n@@ -148,6 +148,22 @@ qat_gen4_reset_ring_pair(struct qat_pci_device *qat_pci_dev)\n \treturn 0;\n }\n \n+int qat_query_svc(struct qat_pci_device *qat_dev, uint8_t *val)\n+{\n+\tint ret = -(EINVAL);\n+\tstruct qat_pf2vf_msg pf2vf_msg;\n+\n+\tif (qat_dev->qat_dev_gen == QAT_GEN4) {\n+\t\tpf2vf_msg.msg_type = ADF_VF2PF_MSGTYPE_GET_SMALL_BLOCK_REQ;\n+\t\tpf2vf_msg.block_hdr = ADF_VF2PF_BLOCK_MSG_GET_RING_TO_SVC_REQ;\n+\t\tpf2vf_msg.msg_data = 2;\n+\t\tret = qat_pf2vf_exch_msg(qat_dev, pf2vf_msg, 2, val);\n+\t}\n+\n+\treturn ret;\n+}\n+\n+\n static void qat_dev_parse_cmd(const char *str, struct qat_dev_cmd_param\n \t\t*qat_dev_cmd_param)\n {\n@@ -296,9 +312,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,\n \t\tqat_dev_parse_cmd(devargs->drv_str, qat_dev_cmd_param);\n \n \tif (qat_dev->qat_dev_gen >= QAT_GEN4) {\n-\t\tint ret = qat_read_qp_config(qat_dev, qat_dev->qat_dev_gen);\n-\n-\t\tif (ret) {\n+\t\tif (qat_read_qp_config(qat_dev)) {\n \t\t\tQAT_LOG(ERR,\n \t\t\t\t\"Cannot acquire ring configuration for QAT_%d\",\n \t\t\t\tqat_dev_id);\ndiff --git a/drivers/common/qat/qat_device.h b/drivers/common/qat/qat_device.h\nindex 05e164baa7..228c057d1e 100644\n--- a/drivers/common/qat/qat_device.h\n+++ b/drivers/common/qat/qat_device.h\n@@ -159,4 +159,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused,\n int\n qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused);\n \n+int\n+qat_query_svc(struct qat_pci_device *qat_pci_dev, uint8_t *ret);\n+\n #endif /* _QAT_DEVICE_H_ */\ndiff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c\nindex 8be59779f9..026ea5ee01 100644\n--- a/drivers/common/qat/qat_qp.c\n+++ b/drivers/common/qat/qat_qp.c\n@@ -504,20 +504,43 @@ qat_select_valid_queue(struct qat_pci_device *qat_dev, int qp_id,\n }\n \n int\n-qat_read_qp_config(struct qat_pci_device *qat_dev,\n-\t\t\tenum qat_device_gen qat_dev_gen)\n+qat_read_qp_config(struct qat_pci_device *qat_dev)\n {\n+\tint i = 0;\n+\tenum qat_device_gen qat_dev_gen = qat_dev->qat_dev_gen;\n+\n \tif (qat_dev_gen == QAT_GEN4) {\n-\t\t/* Read default configuration,\n-\t\t * until some probe of it can be done\n-\t\t */\n-\t\tint i = 0;\n+\t\tuint16_t svc = 0;\n \n+\t\tif (qat_query_svc(qat_dev, (uint8_t *)&svc))\n+\t\t\treturn -(EFAULT);\n \t\tfor (; i < QAT_GEN4_BUNDLE_NUM; i++) {\n \t\t\tstruct qat_qp_hw_data *hw_data =\n \t\t\t\t&qat_dev->qp_gen4_data[i][0];\n-\t\t\tenum qat_service_type service_type =\n-\t\t\t\t(QAT_GEN4_QP_DEFCON >> (8 * i)) & 0xFF;\n+\t\t\tuint8_t svc1 = (svc >> (3 * i)) & 0x7;\n+\t\t\tenum qat_service_type service_type = QAT_SERVICE_INVALID;\n+\n+\t\t\tif (svc1 == QAT_SVC_SYM) {\n+\t\t\t\tservice_type = QAT_SERVICE_SYMMETRIC;\n+\t\t\t\tQAT_LOG(DEBUG,\n+\t\t\t\t\t\"Discovered SYMMETRIC service on bundle %d\",\n+\t\t\t\t\ti);\n+\t\t\t} else if (svc1 == QAT_SVC_COMPRESSION) {\n+\t\t\t\tservice_type = QAT_SERVICE_COMPRESSION;\n+\t\t\t\tQAT_LOG(DEBUG,\n+\t\t\t\t\t\"Discovered COPRESSION service on bundle %d\",\n+\t\t\t\t\ti);\n+\t\t\t} else if (svc1 == QAT_SVC_ASYM) {\n+\t\t\t\tservice_type = QAT_SERVICE_ASYMMETRIC;\n+\t\t\t\tQAT_LOG(DEBUG,\n+\t\t\t\t\t\"Discovered ASYMMETRIC service on bundle %d\",\n+\t\t\t\t\ti);\n+\t\t\t} else {\n+\t\t\t\tQAT_LOG(ERR,\n+\t\t\t\t\t\"Unrecognized service on bundle %d\",\n+\t\t\t\t\ti);\n+\t\t\t\treturn -(EFAULT);\n+\t\t\t}\n \n \t\t\tmemset(hw_data, 0, sizeof(*hw_data));\n \t\t\thw_data->service_type = service_type;\n@@ -534,9 +557,9 @@ qat_read_qp_config(struct qat_pci_device *qat_dev,\n \t\t\thw_data->rx_ring_num = 1;\n \t\t\thw_data->hw_bundle_num = i;\n \t\t}\n+\t\treturn 0;\n \t}\n-\t/* With default config will always return success */\n-\treturn 0;\n+\treturn -(EINVAL);\n }\n \n static int qat_qp_check_queue_alignment(uint64_t phys_addr,\ndiff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h\nindex 3d9a757349..e1627197fa 100644\n--- a/drivers/common/qat/qat_qp.h\n+++ b/drivers/common/qat/qat_qp.h\n@@ -134,7 +134,6 @@ qat_select_valid_queue(struct qat_pci_device *qat_dev, int qp_id,\n \t\t\tenum qat_service_type service_type);\n \n int\n-qat_read_qp_config(struct qat_pci_device *qat_dev,\n-\t\t\tenum qat_device_gen qat_dev_gen);\n+qat_read_qp_config(struct qat_pci_device *qat_dev);\n \n #endif /* _QAT_QP_H_ */\n", "prefixes": [ "v2", "13/16" ] }