Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94882/?format=api
https://patches.dpdk.org/api/patches/94882/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1624849071-56826-2-git-send-email-fengchengwen@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1624849071-56826-2-git-send-email-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1624849071-56826-2-git-send-email-fengchengwen@huawei.com", "date": "2021-06-28T02:57:50", "name": "[1/2] build: fix SVE compile error with gcc8.3", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8edcc40eaf9f77e345b96f82ed8046a53b3912cb", "submitter": { "id": 2146, "url": "https://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1624849071-56826-2-git-send-email-fengchengwen@huawei.com/mbox/", "series": [ { "id": 17496, "url": "https://patches.dpdk.org/api/series/17496/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17496", "date": "2021-06-28T02:57:51", "name": "bugfix for SVE compile", "version": 1, "mbox": "https://patches.dpdk.org/series/17496/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94882/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 51B59A0C40;\n\tMon, 28 Jun 2021 05:01:38 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 51B3D410EE;\n\tMon, 28 Jun 2021 05:01:31 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id D0AD4410E8\n for <dev@dpdk.org>; Mon, 28 Jun 2021 05:01:28 +0200 (CEST)", "from dggemv711-chm.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GCsk53XnlzZkgG;\n Mon, 28 Jun 2021 10:58:21 +0800 (CST)", "from dggpeml500024.china.huawei.com (7.185.36.10) by\n dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2176.2; Mon, 28 Jun 2021 11:01:19 +0800", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2176.2; Mon, 28 Jun 2021 11:01:17 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>, <ruifeng.wang@arm.com>", "CC": "<dev@dpdk.org>, <bruce.richardson@intel.com>,\n <vladimir.medvedkin@intel.com>, <viktorin@rehivetech.com>,\n <jerinj@marvell.com>, <Honnappa.Nagarahalli@arm.com>,\n <jerinjacobk@gmail.com>, <juraj.linkes@pantheon.tech>", "Date": "Mon, 28 Jun 2021 10:57:50 +0800", "Message-ID": "<1624849071-56826-2-git-send-email-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.8.1", "In-Reply-To": "<1624849071-56826-1-git-send-email-fengchengwen@huawei.com>", "References": "<1624849071-56826-1-git-send-email-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] build: fix SVE compile error with gcc8.3", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the target machine has SVE feature (e.g. \"-march=armv8.2-a+sve'),\nand the compiler are gcc8.3, it will compile error:\n\tIn file included from ../dpdk-next-net/lib/eal/common/\n\teal_common_options.c:38:\n\t../dpdk-next-net/lib/eal/arm/include/rte_vect.h:13:10: fatal\n\terror: arm_sve.h: No such file or directory\n\t#include <arm_sve.h>\n\t ^~~~~~~~~~~\n\tcompilation terminated.\n\nThe root cause is that gcc8.3 supports SVE (the macro\n__ARM_FEATURE_SVE was 1), but it doesn't support SVE ACLE [1].\n\nThe solution:\na) Detect compiler whether support SVE ACLE, if support then define\nRTE_HAS_SVE_ACLE macro.\nb) Use the RTE_HAS_SVE_ACLE macro to include SVE header file.\n\n[1] ACLE: Arm C Language Extensions, the SVE ACLE header file is\n<arm_sve.h>, user should include it when writing ACLE SVE code.\n\nFixes: 67b68824a82d (\"lpm/arm: support SVE\")\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nAcked-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n config/arm/meson.build | 6 ++++++\n lib/eal/arm/include/rte_vect.h | 2 +-\n lib/lpm/rte_lpm.h | 2 +-\n 3 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex e83a56e..7342626 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -488,3 +488,9 @@ if cc.get_define('__ARM_FEATURE_CRYPTO', args: machine_args) != ''\n compile_time_cpuflags += ['RTE_CPUFLAG_AES', 'RTE_CPUFLAG_PMULL',\n 'RTE_CPUFLAG_SHA1', 'RTE_CPUFLAG_SHA2']\n endif\n+\n+# Check whether SVE ACLE is supported and set the corresponding flag which will used with SVE ACLE code.\n+if (cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' and\n+ cc.check_header('arm_sve.h'))\n+ dpdk_conf.set('RTE_HAS_SVE_ACLE', 1)\n+endif\ndiff --git a/lib/eal/arm/include/rte_vect.h b/lib/eal/arm/include/rte_vect.h\nindex 093e912..4b705ba 100644\n--- a/lib/eal/arm/include/rte_vect.h\n+++ b/lib/eal/arm/include/rte_vect.h\n@@ -9,7 +9,7 @@\n #include \"generic/rte_vect.h\"\n #include \"rte_debug.h\"\n #include \"arm_neon.h\"\n-#ifdef __ARM_FEATURE_SVE\n+#ifdef RTE_HAS_SVE_ACLE\n #include <arm_sve.h>\n #endif\n \ndiff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h\nindex 28b5768..5eb14c1 100644\n--- a/lib/lpm/rte_lpm.h\n+++ b/lib/lpm/rte_lpm.h\n@@ -402,7 +402,7 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4],\n \tuint32_t defv);\n \n #if defined(RTE_ARCH_ARM)\n-#ifdef __ARM_FEATURE_SVE\n+#ifdef RTE_HAS_SVE_ACLE\n #include \"rte_lpm_sve.h\"\n #else\n #include \"rte_lpm_neon.h\"\n", "prefixes": [ "1/2" ] }{ "id": 94882, "url": "