Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94864/?format=api
{ "id": 94864, "url": "https://patches.dpdk.org/api/patches/94864/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20210625130753.18155-1-ohilyard@iol.unh.edu/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20210625130753.18155-1-ohilyard@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dts/20210625130753.18155-1-ohilyard@iol.unh.edu", "date": "2021-06-25T13:07:52", "name": "framework/config: fix issue with string values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "95254b60339be1d19a25018e4c46eec15625e0bf", "submitter": { "id": 1829, "url": "https://patches.dpdk.org/api/people/1829/?format=api", "name": "Owen Hilyard", "email": "ohilyard@iol.unh.edu" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20210625130753.18155-1-ohilyard@iol.unh.edu/mbox/", "series": [ { "id": 17489, "url": "https://patches.dpdk.org/api/series/17489/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=17489", "date": "2021-06-25T13:07:52", "name": "framework/config: fix issue with string values", "version": 1, "mbox": "https://patches.dpdk.org/series/17489/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94864/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/94864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2A31BA0547;\n\tFri, 25 Jun 2021 15:07:58 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E859040698;\n\tFri, 25 Jun 2021 15:07:57 +0200 (CEST)", "from mail-pl1-f228.google.com (mail-pl1-f228.google.com\n [209.85.214.228])\n by mails.dpdk.org (Postfix) with ESMTP id C78804068A\n for <dts@dpdk.org>; Fri, 25 Jun 2021 15:07:56 +0200 (CEST)", "by mail-pl1-f228.google.com with SMTP id d1so4053136plg.6\n for <dts@dpdk.org>; Fri, 25 Jun 2021 06:07:56 -0700 (PDT)", "from postal.iol.unh.edu (postal.iol.unh.edu.\n [2606:4100:3880:1234::84])\n by smtp-relay.gmail.com with ESMTPS id n7sm4113822pjv.17.2021.06.25.06.07.55\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 25 Jun 2021 06:07:55 -0700 (PDT)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1220:cb5d:c859:780f:37ce])\n by postal.iol.unh.edu (Postfix) with ESMTP id 071866052490;\n Fri, 25 Jun 2021 09:07:55 -0400 (EDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=xDvQNjS8ZqOQgLOrmaU0ucLrqy+6CnpA7WrkN5fPRPQ=;\n b=eZYjr+bYntagni4+l10i1xY/K6eQMq/MIGMnBoys2zzaUO47cAKjhQpq5eKyJyva9e\n 6kwxqrZV5IiqWUtfP7Q9F9q6PxaqcdRJtO2Qnm53OHu2csBl/IC++7oADGUKO9m6ssRG\n rWD4Mqt/+qXrlSrTHWi2CpN2APDXv9trR5Z6U=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=xDvQNjS8ZqOQgLOrmaU0ucLrqy+6CnpA7WrkN5fPRPQ=;\n b=JB2XZkwdnQMb2Xl8/OBgbelsX7Ws0nLi1DwdJTYaW0l1a1F2rspH7S+WZN1fbIhvY8\n NH5QifyiKEX69lrHlhwWalbniWn9SolM5HD4LKMyNLLNKNoTuv0Wo9vUkQF1U+YQkoXj\n wM15BabRQx38JyJ/juxr1AM7IBbJQoBO4KgrxI+LDrdfngPsybTQKN+oZxe7DKDknpbr\n g++vODbo4xDtb5k/dxHlAX5q57l044JVysaXysis0pJLTOut2eT5NdCiPcd16fBr+g5U\n /Sfn3yRRHImBL5XgsnX02s1zVV/Pp86S1TDrD+Dy2wFzpEfI5RNvtrOw1l0bj3IHL2rx\n G8eA==", "X-Gm-Message-State": "AOAM532T48IDmVTo+7D3rOrTWK1jNzp/lgxuTDxSLfcB19w7p4umBDJG\n p0TADxiqbnW5qCSSIttNJlV6FbedTrGaA700E1+unCil9hbH7xqbvfdH+jRqwUzQoxX2UqNguHh\n liw4rPPHYL4OUbw3rmg0NM8KhLhWR5m9AkODDZOwkOUoCMoECiQoV5dx0/wn5+k+wdvMHYW67Ye\n jq+oEt0UVLVsN1PQ==", "X-Google-Smtp-Source": "\n ABdhPJzDIOl1T3s1iODxeP6UdSVX77JRS3iNwsRwpSXfU7IkM0FjHH8eXJOD1KTQWY/0QNKZQXJIWLU2/R2z", "X-Received": "by 2002:a17:90a:fb95:: with SMTP id\n cp21mr11133065pjb.28.1624626475751;\n Fri, 25 Jun 2021 06:07:55 -0700 (PDT)", "X-Relaying-Domain": "iol.unh.edu", "From": "ohilyard@iol.unh.edu", "To": "lijuan.tu@intel.com", "Cc": "dts@dpdk.org,\n\tOwen Hilyard <ohilyard@iol.unh.edu>", "Date": "Fri, 25 Jun 2021 09:07:52 -0400", "Message-Id": "<20210625130753.18155-1-ohilyard@iol.unh.edu>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dts] [PATCH] framework/config: fix issue with string values", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "From: Owen Hilyard <ohilyard@iol.unh.edu>\n\nString values were ran through 'eval' like everything else as part of\nparsing config files. This will work the first time if there are quotes\naround the value, but if the --update-expected flag is passed, it will\nre-write the config file without quotes around the string value. This\nthen cause an error when the value is 'eval'ed again, since it will now\nbe evaluated as a variable.\n\nSigned-off-by: Owen Hilyard <ohilyard@iol.unh.edu>\n---\n framework/config.py | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/framework/config.py b/framework/config.py\nindex 30604773..88ae8ea5 100644\n--- a/framework/config.py\n+++ b/framework/config.py\n@@ -147,7 +147,10 @@ class SuiteConf(UserConf):\n \n conf = dict(case_confs)\n for key, data_string in list(conf.items()):\n- case_cfg[key] = eval(data_string)\n+ try:\n+ case_cfg[key] = eval(data_string)\n+ except NameError: # happens when data_string is actually a string, not an int, bool or dict\n+ case_cfg[key] = data_string\n \n return case_cfg\n \n", "prefixes": [] }