Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94772/?format=api
{ "id": 94772, "url": "https://patches.dpdk.org/api/patches/94772/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210623203154.72409-1-drc@linux.vnet.ibm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210623203154.72409-1-drc@linux.vnet.ibm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210623203154.72409-1-drc@linux.vnet.ibm.com", "date": "2021-06-23T20:31:54", "name": "net/memif: replace memcpy() with rte_memcpy() to improve perf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9ad2dc575b534b39fbcfd0809acf276379772af6", "submitter": { "id": 1256, "url": "https://patches.dpdk.org/api/people/1256/?format=api", "name": "David Christensen", "email": "drc@linux.vnet.ibm.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210623203154.72409-1-drc@linux.vnet.ibm.com/mbox/", "series": [ { "id": 17462, "url": "https://patches.dpdk.org/api/series/17462/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17462", "date": "2021-06-23T20:31:54", "name": "net/memif: replace memcpy() with rte_memcpy() to improve perf", "version": 1, "mbox": "https://patches.dpdk.org/series/17462/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94772/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1D9D9A0C41;\n\tWed, 23 Jun 2021 22:32:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D248C40141;\n\tWed, 23 Jun 2021 22:32:02 +0200 (CEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B59F4003C\n for <dev@dpdk.org>; Wed, 23 Jun 2021 22:32:01 +0200 (CEST)", "from pps.filterd (m0187473.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15NK414Q173684; Wed, 23 Jun 2021 16:31:59 -0400", "from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com\n [169.62.189.10])\n by mx0a-001b2d01.pphosted.com with ESMTP id 39c7ju0wwd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 23 Jun 2021 16:31:59 -0400", "from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1])\n by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15NKCiVm017134;\n Wed, 23 Jun 2021 20:31:58 GMT", "from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com\n [9.57.198.29]) by ppma02dal.us.ibm.com with ESMTP id 39987a41pw-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 23 Jun 2021 20:31:58 +0000", "from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com\n [9.57.199.108])\n by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 15NKVw4A29098278\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 23 Jun 2021 20:31:58 GMT", "from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0B0F3B2064;\n Wed, 23 Jun 2021 20:31:58 +0000 (GMT)", "from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id E77E3B2066;\n Wed, 23 Jun 2021 20:31:57 +0000 (GMT)", "from localhost.localdomain (unknown [9.114.224.51])\n by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP;\n Wed, 23 Jun 2021 20:31:57 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=pp1;\n bh=pNpS8iZHCtkA84RWedWpmcnSLQUIYjrEyQ83sZaMA3Y=;\n b=P5N/2G/uFiGQvfftBSX+iMUVO9thqb0Y7YnBLI83WbI5YlvJqk2gQHr3a5ZoLlQE0VVv\n F8Z81DApBhplAfMQKMWM4LDnfDrBjkj9MQxa1s90GfCNRyLCBtk+UWER7zMBD/VM+law\n RqasRFHIYWSAwIzMFJg/7Pv2Q6B+EVWZPyObzabQolU1jtZF01+UVpUfmX9o3Blp+Vxz\n PC+Hgx+hV0ESq9CsoawvPRG/uGUGPHbleUF/1uyjBEZQ/DGiqoY2gEbuPbm4aGQhJuYq\n JCuirmUDvwBLTzzmXxpdkLe2DZu5C56s9jjDYKxj0Jt6f/pHxDRUD8C1uihsxVVLFOnj Vg==", "From": "David Christensen <drc@linux.vnet.ibm.com>", "To": "dev@dpdk.org, jgrajcia@cisco.com", "Cc": "David Christensen <drc@linux.vnet.ibm.com>", "Date": "Wed, 23 Jun 2021 13:31:54 -0700", "Message-Id": "<20210623203154.72409-1-drc@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210623164935.59796-1-drc@linux.vnet.ibm.com>", "References": "<20210623164935.59796-1-drc@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-ORIG-GUID": "VevdZAom6hlMAaM_HM8kZAG8DswCn-RA", "X-Proofpoint-GUID": "VevdZAom6hlMAaM_HM8kZAG8DswCn-RA", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-23_12:2021-06-23,\n 2021-06-23 signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n mlxlogscore=959 bulkscore=0\n phishscore=0 mlxscore=0 clxscore=1015 malwarescore=0 suspectscore=0\n adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0\n impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2104190000 definitions=main-2106230117", "Subject": "[dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to\n improve perf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replacing memcpy() with rte_memcpy() improved 64 byte packet\nperformance by 33% on a POWER9 system and by 10% on an x86_64\nsystem.\n\nSigned-off-by: David Christensen <drc@linux.vnet.ibm.com>\n---\nv2: Fixed last patch which was bungled due to a bad local git squash\n\n drivers/net/memif/rte_eth_memif.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.27.0", "diff": "diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex da7195783f..d17222c612 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -383,7 +383,7 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tif (mbuf != mbuf_head)\n \t\t\t\trte_pktmbuf_pkt_len(mbuf_head) += cp_len;\n\n-\t\t\tmemcpy(rte_pktmbuf_mtod_offset(mbuf, void *, dst_off),\n+\t\t\trte_memcpy(rte_pktmbuf_mtod_offset(mbuf, void *, dst_off),\n \t\t\t (uint8_t *)memif_get_buffer(proc_private, d0) + src_off,\n \t\t\t cp_len);\n\n@@ -644,7 +644,7 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t}\n \t\t\tcp_len = RTE_MIN(dst_len, src_len);\n\n-\t\t\tmemcpy((uint8_t *)memif_get_buffer(proc_private, d0) + dst_off,\n+\t\t\trte_memcpy((uint8_t *)memif_get_buffer(proc_private, d0) + dst_off,\n \t\t\t rte_pktmbuf_mtod_offset(mbuf, void *, src_off),\n \t\t\t cp_len);\n\n", "prefixes": [] }