Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94769/?format=api
{ "id": 94769, "url": "https://patches.dpdk.org/api/patches/94769/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210623170708.43755-1-ohilyard@iol.unh.edu/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210623170708.43755-1-ohilyard@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20210623170708.43755-1-ohilyard@iol.unh.edu", "date": "2021-06-23T17:07:07", "name": "[v2] flow_classify: fix leaking rules on delete", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7921cc6ce6fcbd6902a3c10a0e6f3f73c347458", "submitter": { "id": 1829, "url": "https://patches.dpdk.org/api/people/1829/?format=api", "name": "Owen Hilyard", "email": "ohilyard@iol.unh.edu" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210623170708.43755-1-ohilyard@iol.unh.edu/mbox/", "series": [ { "id": 17459, "url": "https://patches.dpdk.org/api/series/17459/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17459", "date": "2021-06-23T17:07:07", "name": "[v2] flow_classify: fix leaking rules on delete", "version": 2, "mbox": "https://patches.dpdk.org/series/17459/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94769/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94769/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E912A0C42;\n\tWed, 23 Jun 2021 19:07:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CEC274003F;\n\tWed, 23 Jun 2021 19:07:11 +0200 (CEST)", "from mail-ua1-f97.google.com (mail-ua1-f97.google.com\n [209.85.222.97]) by mails.dpdk.org (Postfix) with ESMTP id C1ABE4003E\n for <dev@dpdk.org>; Wed, 23 Jun 2021 19:07:10 +0200 (CEST)", "by mail-ua1-f97.google.com with SMTP id c20so1125237uar.12\n for <dev@dpdk.org>; Wed, 23 Jun 2021 10:07:10 -0700 (PDT)", "from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84])\n by smtp-relay.gmail.com with ESMTPS id d66sm222274vkg.0.2021.06.23.10.07.10\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 23 Jun 2021 10:07:10 -0700 (PDT)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1220:47d3:d45d:6a1c:8da0])\n by postal.iol.unh.edu (Postfix) with ESMTP id C7A986052490;\n Wed, 23 Jun 2021 13:07:09 -0400 (EDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=qn+Js4qLLbSj7z8q4i0Xesf+H/4V7dBLkxlNEMFSJUU=;\n b=RfIAr/hj6BfmxPpc1dxRaIjLBUn3gZLxPSL1285frAi6XL2GD/DQ5Ha1MLqtP6rlCQ\n PXjk3G//jQNHqwnvdh/uL/djVO/NfmEjxUnpKA5MSTkGtnL/tVCr7xosJFL3BZJtuAqg\n yLOqHe4KB42qRdQquFkg2G9x7qWQBzZvmaTck=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=qn+Js4qLLbSj7z8q4i0Xesf+H/4V7dBLkxlNEMFSJUU=;\n b=Nyob/bX8ydq9nL4UVktr3y4wb3hMBoTQ47ldlizzckAEVK9P8YTR/8+zAsq6wh5AsR\n sZFnjIIDopIea7DBqq551b40gDiK5WuA5w0F2aPcffCrM1HzqfHMMFFjr8fgx6GJ5pek\n bupz0ZePXx57yOTMn/XgWgm0UzlcDjUnLUyOpwpsahCu63Ugzc+/PHLhnfgTefjYLess\n OCv6b811XD+bGj3kBKmLcJxbaJpO9buz0UD7x7v67mg9FWoKZ06rmU+uaKfatzNfLiRG\n THX7P7ejb+dLGWdC+cT9ZO0rTQTLdAMG2opGiZao/0XdoPH7I9IBe00937udTgM0vRCf\n pG5A==", "X-Gm-Message-State": "AOAM530hxO6MNyua3MgDMc1i9TjHU9raE5m5kY9eR8p4S1oiODdZ2u0w\n MbtLO6g69+d5tUELk4vuDeD+ZajfWzpVdDMtvKt0gTMRRTZP8Qmr9LKSXY6JxSrHkCadagNvZLs\n jFjd6np6jLeYFxUntYF/mamBsxK1dz3FQafQ92D6tRqsNZSu7Vu44/mpIpQ6FoMc8cD1dCoG6Zw\n ==", "X-Google-Smtp-Source": "\n ABdhPJz6j5p/0iDTq5I1rYe7lJf9bIs3pZTjWWsVQaF39py0N0oDonYK1uck9gAO/kgsTqtHJEwrSkYdgpN7", "X-Received": "by 2002:a9f:2c90:: with SMTP id w16mr1195746uaj.135.1624468030249;\n Wed, 23 Jun 2021 10:07:10 -0700 (PDT)", "X-Relaying-Domain": "iol.unh.edu", "From": "ohilyard@iol.unh.edu", "To": "bernard.iremonger@intel.com", "Cc": "dev@dpdk.org, david.marchand@redhat.com,\n Owen Hilyard <ohilyard@iol.unh.edu>", "Date": "Wed, 23 Jun 2021 13:07:07 -0400", "Message-Id": "<20210623170708.43755-1-ohilyard@iol.unh.edu>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210616195724.366103-1-ohilyard@iol.unh.edu>", "References": "<20210616195724.366103-1-ohilyard@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] flow_classify: fix leaking rules on delete", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Owen Hilyard <ohilyard@iol.unh.edu>\n\nRules in a classify table were not freed if the table\nhad a delete function.\n\nFixes: be41ac2a3 (\"flow_classify: introduce flow classify library\")\n\nSigned-off-by: Owen Hilyard <ohilyard@iol.unh.edu>\n---\n lib/flow_classify/rte_flow_classify.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/flow_classify/rte_flow_classify.c b/lib/flow_classify/rte_flow_classify.c\nindex f125267e8..d3ba2ed22 100644\n--- a/lib/flow_classify/rte_flow_classify.c\n+++ b/lib/flow_classify/rte_flow_classify.c\n@@ -579,12 +579,12 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,\n \t\t\t\t\t\t&rule->u.key.key_del,\n \t\t\t\t\t\t&rule->key_found,\n \t\t\t\t\t\t&rule->entry);\n-\n+\t\t\t\tif (ret == 0)\n+\t\t\t\t\tfree(rule);\n \t\t\t\treturn ret;\n \t\t\t}\n \t\t}\n \t}\n-\tfree(rule);\n \treturn ret;\n }\n \n", "prefixes": [ "v2" ] }