Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94768/?format=api
{ "id": 94768, "url": "https://patches.dpdk.org/api/patches/94768/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210623164935.59796-1-drc@linux.vnet.ibm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210623164935.59796-1-drc@linux.vnet.ibm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210623164935.59796-1-drc@linux.vnet.ibm.com", "date": "2021-06-23T16:49:35", "name": "net/memif: replace memcpy() with rte_memcpy() to improve perf", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "b89132471fa1b2061195d00b0db6a15f3bd798f3", "submitter": { "id": 1256, "url": "https://patches.dpdk.org/api/people/1256/?format=api", "name": "David Christensen", "email": "drc@linux.vnet.ibm.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210623164935.59796-1-drc@linux.vnet.ibm.com/mbox/", "series": [ { "id": 17458, "url": "https://patches.dpdk.org/api/series/17458/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17458", "date": "2021-06-23T16:49:35", "name": "net/memif: replace memcpy() with rte_memcpy() to improve perf", "version": 1, "mbox": "https://patches.dpdk.org/series/17458/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94768/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/94768/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CC0CCA0C42;\n\tWed, 23 Jun 2021 18:49:43 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 56C404003F;\n\tWed, 23 Jun 2021 18:49:43 +0200 (CEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A4B64003E\n for <dev@dpdk.org>; Wed, 23 Jun 2021 18:49:41 +0200 (CEST)", "from pps.filterd (m0098394.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15NGYPJk161243; Wed, 23 Jun 2021 12:49:39 -0400", "from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com\n [169.63.214.131])\n by mx0a-001b2d01.pphosted.com with ESMTP id 39c69p625c-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 23 Jun 2021 12:49:39 -0400", "from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1])\n by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15NGgiRh003218;\n Wed, 23 Jun 2021 16:49:38 GMT", "from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com\n [9.57.198.23]) by ppma01dal.us.ibm.com with ESMTP id 39987a29wc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 23 Jun 2021 16:49:38 +0000", "from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com\n [9.57.199.106])\n by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 15NGnb6a32571734\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 23 Jun 2021 16:49:37 GMT", "from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 9C1FE28065;\n Wed, 23 Jun 2021 16:49:37 +0000 (GMT)", "from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 836772805C;\n Wed, 23 Jun 2021 16:49:37 +0000 (GMT)", "from localhost.localdomain (unknown [9.114.224.51])\n by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP;\n Wed, 23 Jun 2021 16:49:37 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : mime-version : content-transfer-encoding; s=pp1;\n bh=HEccIgciAcmNHYs3//ThgZoFdE46znyQY/ELFVsIGkE=;\n b=YGCmrOKVO4DS84fH4IPn2RPTLxzjpViqtXSlnrnAjtsrqwsqfJx71XvW3UL++9lXMtnE\n q1cqQqupFZTJPB36tsUrU6tG9YwbxoRaD+xwcLo/ATRyNxGOJDd/foILxthZxFTVjyci\n lbfOx61ETMDTQtxMHER+fE2BoD+HRM2OHkvYCWc5ay3Ngk8Xvhm11sBVEbL25Oi8/Qgx\n Rs8BrwJDWi5TjrM9MFG1zB5lhzLfyutVnVV/W1fqQY4a4+KaXT+n89vjGXXgyq07Zqi7\n CCma9MgsQZIHh/UoCZv6xYpKzxdqwpRd3+A1LUhBhtkDzMvm0KZK9GNh8dYcjZ12U0ym nw==", "From": "David Christensen <drc@linux.vnet.ibm.com>", "To": "jgrajcia@cisco.com, dev@dpdk.org", "Cc": "David Christensen <drc@linux.vnet.ibm.com>", "Date": "Wed, 23 Jun 2021 09:49:35 -0700", "Message-Id": "<20210623164935.59796-1-drc@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "c5LZYgLDFcfguMQLy9Lm5wD9Xsk6Sa4l", "X-Proofpoint-ORIG-GUID": "c5LZYgLDFcfguMQLy9Lm5wD9Xsk6Sa4l", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-23_12:2021-06-23,\n 2021-06-23 signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n clxscore=1011\n priorityscore=1501 adultscore=0 phishscore=0 lowpriorityscore=0\n mlxlogscore=999 impostorscore=0 mlxscore=0 bulkscore=0 suspectscore=0\n spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2104190000 definitions=main-2106230096", "Subject": "[dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to\n improve perf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replacing memcpy() with rte_memcpy() improved 64 byte packet\nperformance by 33% on a POWER9 system and by 10% on an x86_64\nsystem.\n\nSigned-off-by: David Christensen <drc@linux.vnet.ibm.com>\n---\n drivers/net/memif/rte_eth_memif.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex d17222c612..330c9c2fd6 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -384,8 +384,8 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t\trte_pktmbuf_pkt_len(mbuf_head) += cp_len;\n \n \t\t\trte_memcpy(rte_pktmbuf_mtod_offset(mbuf, void *, dst_off),\n-\t\t\t (uint8_t *)memif_get_buffer(proc_private, d0) + src_off,\n-\t\t\t cp_len);\n+\t\t\t (uint8_t *)memif_get_buffer(proc_private, d0)\n+\t\t\t + src_off, cp_len);\n \n \t\t\tsrc_off += cp_len;\n \t\t\tdst_off += cp_len;\n@@ -644,7 +644,8 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t}\n \t\t\tcp_len = RTE_MIN(dst_len, src_len);\n \n-\t\t\trte_memcpy((uint8_t *)memif_get_buffer(proc_private, d0) + dst_off,\n+\t\t\trte_memcpy((uint8_t *)\n+\t\t\t memif_get_buffer(proc_private, d0) + dst_off,\n \t\t\t rte_pktmbuf_mtod_offset(mbuf, void *, src_off),\n \t\t\t cp_len);\n \n", "prefixes": [] }