Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94760/?format=api
{ "id": 94760, "url": "https://patches.dpdk.org/api/patches/94760/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210623084334.18158-1-joyce.kong@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210623084334.18158-1-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210623084334.18158-1-joyce.kong@arm.com", "date": "2021-06-23T08:43:34", "name": "[v2] net/i40e: add logic of processing continuous DD bits for Arm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b7837cff40087225737eb5da4300c1db61b7d62a", "submitter": { "id": 970, "url": "https://patches.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210623084334.18158-1-joyce.kong@arm.com/mbox/", "series": [ { "id": 17451, "url": "https://patches.dpdk.org/api/series/17451/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17451", "date": "2021-06-23T08:43:34", "name": "[v2] net/i40e: add logic of processing continuous DD bits for Arm", "version": 2, "mbox": "https://patches.dpdk.org/series/17451/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94760/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A5DBA0C41;\n\tWed, 23 Jun 2021 10:44:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 722654067A;\n\tWed, 23 Jun 2021 10:44:01 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id C489F4003E;\n Wed, 23 Jun 2021 10:43:58 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D6D931B;\n Wed, 23 Jun 2021 01:43:58 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4F3CB3F719;\n Wed, 23 Jun 2021 01:43:55 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "beilei.xing@intel.com, qi.z.zhang@intel.com, ruifeng.wang@arm.com,\n honnappa.nagarahalli@arm.com, bruce.richardson@intel.com,\n helin.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org,\n\tnd@arm.com", "Date": "Wed, 23 Jun 2021 03:43:34 -0500", "Message-Id": "<20210623084334.18158-1-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210604073405.14880-1-joyce.kong@arm.com>", "References": "<20210604073405.14880-1-joyce.kong@arm.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: add logic of processing continuous\n DD bits for Arm", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For Arm platforms, reading descs can get re-ordered, then the\nstatus of DD bits will be discontinuous, so add the logic to\nonly process continuous descs by checking DD bits.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++----\n 1 file changed, 15 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 6c58decec..86e2f083e 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -452,7 +452,7 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq)\n \tuint16_t pkt_len;\n \tuint64_t qword1;\n \tuint32_t rx_status;\n-\tint32_t s[I40E_LOOK_AHEAD], nb_dd;\n+\tint32_t s[I40E_LOOK_AHEAD], var, nb_dd;\n \tint32_t i, j, nb_rx = 0;\n \tuint64_t pkt_flags;\n \tuint32_t *ptype_tbl = rxq->vsi->adapter->ptype_tbl;\n@@ -482,11 +482,22 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq)\n \t\t\t\t\tI40E_RXD_QW1_STATUS_SHIFT;\n \t\t}\n \n-\t\trte_smp_rmb();\n+\t\t/* This barrier is to order loads of different words in the descriptor */\n+\t\trte_atomic_thread_fence(__ATOMIC_ACQUIRE);\n \n \t\t/* Compute how many status bits were set */\n-\t\tfor (j = 0, nb_dd = 0; j < I40E_LOOK_AHEAD; j++)\n-\t\t\tnb_dd += s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT);\n+\t\tfor (j = 0, nb_dd = 0; j < I40E_LOOK_AHEAD; j++) {\n+\t\t\tvar = s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT);\n+#ifdef RTE_ARCH_ARM\n+\t\t\t/* For Arm platforms, only compute continuous status bits */\n+\t\t\tif (var)\n+\t\t\t\tnb_dd += 1;\n+\t\t\telse\n+\t\t\t\tbreak;\n+#else\n+\t\t\tnb_dd += var;\n+#endif\n+\t\t}\n \n \t\tnb_rx += nb_dd;\n \n", "prefixes": [ "v2" ] }