Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94749/?format=api
{ "id": 94749, "url": "https://patches.dpdk.org/api/patches/94749/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210623044702.4240-54-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210623044702.4240-54-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210623044702.4240-54-ndabilpuram@marvell.com", "date": "2021-06-23T04:46:53", "name": "[v4,53/62] net/cnxk: support for RSS in rte flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8c43b059c7f826a06f3947beecfd1e995302d2a5", "submitter": { "id": 1202, "url": "https://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210623044702.4240-54-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 17449, "url": "https://patches.dpdk.org/api/series/17449/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17449", "date": "2021-06-23T04:46:00", "name": "Marvell CNXK Ethdev Driver", "version": 4, "mbox": "https://patches.dpdk.org/series/17449/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94749/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94749/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 141EAA0C41;\n\tWed, 23 Jun 2021 06:53:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C303041140;\n\tWed, 23 Jun 2021 06:50:17 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 23E1C411C2\n for <dev@dpdk.org>; Wed, 23 Jun 2021 06:50:16 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15N4k9p7025587 for <dev@dpdk.org>; Tue, 22 Jun 2021 21:50:15 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 39bptj1gvp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 22 Jun 2021 21:50:15 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 22 Jun 2021 21:50:13 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 22 Jun 2021 21:50:13 -0700", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id BEDBA5B697B;\n Tue, 22 Jun 2021 21:50:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=uaqaN9FvN8mACyPIwMLg9Rf2sT6mww4mRDpN4Kw008Q=;\n b=kj1l8l5QZBNu8QTfXK5emNVK42NZ9cHCit+fAEcKh8TxTRQw5Y0JAR5moafPXdoX5I8H\n ga+yoH/h6HxJnc+p9pIpMmpwRjNB+BmLwcjQWdOWoZ6sGvT6ctXpDG+1EPK9WYd9HZM2\n zKjzQcVplv1VEh0/khL0isc9amYLSKaBPoi0xLe4AzeMINAqHk00yj4FOJX9lMy6z9T7\n kexTXLfxNkr+GmXVbKbGBivzYl/0dB3+b0mnP80PRBxnCoEaKJhQIC8Be10IXBaxdA3s\n +bToe1W992Y5H/hbYT4Kmn7xdRlEdEbKQTdbSUAqqTHda3zmNtCV+P2zazyNNwuWL6CV eg==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<jerinj@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>,\n <pbhagavatula@marvell.com>, <kirankumark@marvell.com>,\n <psatheesh@marvell.com>, <asekhar@marvell.com>, <hkalra@marvell.com>", "Date": "Wed, 23 Jun 2021 10:16:53 +0530", "Message-ID": "<20210623044702.4240-54-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20210623044702.4240-1-ndabilpuram@marvell.com>", "References": "<20210306153404.10781-1-ndabilpuram@marvell.com>\n <20210623044702.4240-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "5m59pw3s8clPFXY6QwBoiL4G1L_ba1QE", "X-Proofpoint-GUID": "5m59pw3s8clPFXY6QwBoiL4G1L_ba1QE", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-23_01:2021-06-22,\n 2021-06-23 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 53/62] net/cnxk: support for RSS in rte flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Satheesh Paul <psatheesh@marvell.com>\n\nAdded support for RSS action in rte flow code based on ROC.\n\nSigned-off-by: Satheesh Paul <psatheesh@marvell.com>\n---\n doc/guides/nics/features/cnxk.ini | 1 +\n doc/guides/nics/features/cnxk_vec.ini | 1 +\n doc/guides/nics/features/cnxk_vf.ini | 1 +\n drivers/net/cnxk/cnxk_rte_flow.c | 74 +++++++++++++++++++++++++++++++----\n 4 files changed, 69 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini\nindex 246caf9..eba4107 100644\n--- a/doc/guides/nics/features/cnxk.ini\n+++ b/doc/guides/nics/features/cnxk.ini\n@@ -75,5 +75,6 @@ flag = Y\n pf = Y\n port_id = Y\n queue = Y\n+rss = Y\n security = Y\n vf = Y\ndiff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini\nindex 6c6aeb0..4871fac 100644\n--- a/doc/guides/nics/features/cnxk_vec.ini\n+++ b/doc/guides/nics/features/cnxk_vec.ini\n@@ -73,5 +73,6 @@ flag = Y\n pf = Y\n port_id = Y\n queue = Y\n+rss = Y\n security = Y\n vf = Y\ndiff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini\nindex 8ec326a..81ee7cc 100644\n--- a/doc/guides/nics/features/cnxk_vf.ini\n+++ b/doc/guides/nics/features/cnxk_vf.ini\n@@ -70,5 +70,6 @@ flag = Y\n pf = Y\n port_id = Y\n queue = Y\n+rss = Y\n security = Y\n vf = Y\ndiff --git a/drivers/net/cnxk/cnxk_rte_flow.c b/drivers/net/cnxk/cnxk_rte_flow.c\nindex 2dee19e..c61618a 100644\n--- a/drivers/net/cnxk/cnxk_rte_flow.c\n+++ b/drivers/net/cnxk/cnxk_rte_flow.c\n@@ -56,14 +56,64 @@ const struct cnxk_rte_flow_term_info term[] = {\n };\n \n static int\n-cnxk_map_actions(struct rte_eth_dev *eth_dev,\n+npc_rss_action_validate(struct rte_eth_dev *eth_dev,\n+\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\tconst struct rte_flow_action *act)\n+{\n+\tconst struct rte_flow_action_rss *rss;\n+\n+\trss = (const struct rte_flow_action_rss *)act->conf;\n+\n+\tif (attr->egress) {\n+\t\tplt_err(\"No support of RSS in egress\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {\n+\t\tplt_err(\"multi-queue mode is disabled\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (!rss || !rss->queue_num) {\n+\t\tplt_err(\"no valid queues\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT) {\n+\t\tplt_err(\"non-default RSS hash functions are not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (rss->key_len && rss->key_len > ROC_NIX_RSS_KEY_LEN) {\n+\t\tplt_err(\"RSS hash key too large\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+npc_rss_flowkey_get(struct cnxk_eth_dev *eth_dev,\n+\t\t const struct roc_npc_action *rss_action,\n+\t\t uint32_t *flowkey_cfg)\n+{\n+\tconst struct roc_npc_action_rss *rss;\n+\n+\trss = (const struct roc_npc_action_rss *)rss_action->conf;\n+\n+\t*flowkey_cfg = cnxk_rss_ethdev_to_nix(eth_dev, rss->types, rss->level);\n+}\n+\n+static int\n+cnxk_map_actions(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,\n \t\t const struct rte_flow_action actions[],\n-\t\t struct roc_npc_action in_actions[])\n+\t\t struct roc_npc_action in_actions[], uint32_t *flowkey_cfg)\n {\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \tconst struct rte_flow_action_count *act_count;\n \tconst struct rte_flow_action_queue *act_q;\n+\tint i = 0, rc = 0;\n \tint rq;\n-\tint i = 0;\n \n \tfor (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {\n \t\tswitch (actions->type) {\n@@ -117,7 +167,12 @@ cnxk_map_actions(struct rte_eth_dev *eth_dev,\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n+\t\t\trc = npc_rss_action_validate(eth_dev, attr, actions);\n+\t\t\tif (rc)\n+\t\t\t\tgoto err_exit;\n \t\t\tin_actions[i].type = ROC_NPC_ACTION_TYPE_RSS;\n+\t\t\tin_actions[i].conf = actions->conf;\n+\t\t\tnpc_rss_flowkey_get(dev, &in_actions[i], flowkey_cfg);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ACTION_TYPE_SECURITY:\n@@ -144,7 +199,7 @@ cnxk_map_flow_data(struct rte_eth_dev *eth_dev,\n \t\t const struct rte_flow_action actions[],\n \t\t struct roc_npc_attr *in_attr,\n \t\t struct roc_npc_item_info in_pattern[],\n-\t\t struct roc_npc_action in_actions[])\n+\t\t struct roc_npc_action in_actions[], uint32_t *flowkey_cfg)\n {\n \tint i = 0;\n \n@@ -163,7 +218,8 @@ cnxk_map_flow_data(struct rte_eth_dev *eth_dev,\n \t}\n \tin_pattern[i].type = ROC_NPC_ITEM_TYPE_END;\n \n-\treturn cnxk_map_actions(eth_dev, actions, in_actions);\n+\treturn cnxk_map_actions(eth_dev, attr, actions, in_actions,\n+\t\t\t\tflowkey_cfg);\n }\n \n static int\n@@ -179,12 +235,13 @@ cnxk_flow_validate(struct rte_eth_dev *eth_dev,\n \tstruct roc_npc *npc = &dev->npc;\n \tstruct roc_npc_attr in_attr;\n \tstruct roc_npc_flow flow;\n+\tuint32_t flowkey_cfg = 0;\n \tint rc;\n \n \tmemset(&flow, 0, sizeof(flow));\n \n \trc = cnxk_map_flow_data(eth_dev, attr, pattern, actions, &in_attr,\n-\t\t\t\tin_pattern, in_actions);\n+\t\t\t\tin_pattern, in_actions, &flowkey_cfg);\n \tif (rc) {\n \t\trte_flow_error_set(error, 0, RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n \t\t\t\t NULL, \"Failed to map flow data\");\n@@ -206,11 +263,12 @@ cnxk_flow_create(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,\n \tstruct roc_npc *npc = &dev->npc;\n \tstruct roc_npc_attr in_attr;\n \tstruct roc_npc_flow *flow;\n-\tint errcode;\n+\tint errcode = 0;\n \tint rc;\n \n \trc = cnxk_map_flow_data(eth_dev, attr, pattern, actions, &in_attr,\n-\t\t\t\tin_pattern, in_actions);\n+\t\t\t\tin_pattern, in_actions,\n+\t\t\t\t&npc->flowkey_cfg_state);\n \tif (rc) {\n \t\trte_flow_error_set(error, 0, RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n \t\t\t\t NULL, \"Failed to map flow data\");\n", "prefixes": [ "v4", "53/62" ] }