Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94731/?format=api
{ "id": 94731, "url": "https://patches.dpdk.org/api/patches/94731/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210623044702.4240-36-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210623044702.4240-36-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210623044702.4240-36-ndabilpuram@marvell.com", "date": "2021-06-23T04:46:35", "name": "[v4,35/62] net/cnxk: support DMAC filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c77b7f78bebc45461c5a7807b6519959646a43e1", "submitter": { "id": 1202, "url": "https://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210623044702.4240-36-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 17449, "url": "https://patches.dpdk.org/api/series/17449/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17449", "date": "2021-06-23T04:46:00", "name": "Marvell CNXK Ethdev Driver", "version": 4, "mbox": "https://patches.dpdk.org/series/17449/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94731/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94731/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CDF43A0C41;\n\tWed, 23 Jun 2021 06:51:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 48ED741143;\n\tWed, 23 Jun 2021 06:49:17 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 18CF541198\n for <dev@dpdk.org>; Wed, 23 Jun 2021 06:49:16 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15N4krfm026329 for <dev@dpdk.org>; Tue, 22 Jun 2021 21:49:15 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 39bptj1gr9-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 22 Jun 2021 21:49:15 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 22 Jun 2021 21:49:12 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 22 Jun 2021 21:49:12 -0700", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 4C2C75B6936;\n Tue, 22 Jun 2021 21:49:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=tK6SD7coeoDwPI74+u3WHIiZ8XEcdfJd4G5FTxQDFv8=;\n b=VlgcjBXZZH5A774473HpX8fbX4nOyUm73e0RdJ3itbvGME0yqpESwm48BV7NNDHHHm3P\n Qhi/MyNOq08MPHEHdrDJRLkNp6RnfQPEAql7y42tuFEoqPAzx/Em5nQtSL3yyfp1Xf0S\n VFabqocZvFemEA/1pSt/2iMv/vcT93EkiMU7RHuuY8AbyDYKFc1MtXe3qAblfVyIIQb6\n VZJZzh3tg7mCuG5x+9owHVvZXnIEVDPys6ff08AEPRHPQS+xrOmDOWapdMRncn/PNumq\n f9mdU/y1Wkv1Qrrx9Sih6gjzZbWfh/zljN0PB6FtzWkgpLiqpaWV9gCug1YjLMYQSuMq /w==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<jerinj@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>,\n <pbhagavatula@marvell.com>, <kirankumark@marvell.com>,\n <psatheesh@marvell.com>, <asekhar@marvell.com>, <hkalra@marvell.com>", "Date": "Wed, 23 Jun 2021 10:16:35 +0530", "Message-ID": "<20210623044702.4240-36-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20210623044702.4240-1-ndabilpuram@marvell.com>", "References": "<20210306153404.10781-1-ndabilpuram@marvell.com>\n <20210623044702.4240-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "1f5C1BZ2zrFmJqClW97pn-MQNOHkeWzR", "X-Proofpoint-GUID": "1f5C1BZ2zrFmJqClW97pn-MQNOHkeWzR", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-23_01:2021-06-22,\n 2021-06-23 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 35/62] net/cnxk: support DMAC filter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nDMAC filter support is added for cn9k and cn10k platforms.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n doc/guides/nics/cnxk.rst | 1 +\n doc/guides/nics/features/cnxk.ini | 1 +\n doc/guides/nics/features/cnxk_vec.ini | 1 +\n drivers/net/cnxk/cnxk_ethdev.c | 2 ++\n drivers/net/cnxk/cnxk_ethdev.h | 5 ++++\n drivers/net/cnxk/cnxk_ethdev_ops.c | 44 ++++++++++++++++++++++++++++++++---\n 6 files changed, 51 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst\nindex 87ceda5..af7141f 100644\n--- a/doc/guides/nics/cnxk.rst\n+++ b/doc/guides/nics/cnxk.rst\n@@ -23,6 +23,7 @@ Features of the CNXK Ethdev PMD are:\n - Lock-free Tx queue\n - Multiple queues for TX and RX\n - Receiver Side Scaling (RSS)\n+- MAC filtering\n - Inner and Outer Checksum offload\n - Link state information\n - MTU update\ndiff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini\nindex 9b2e163..20d4d12 100644\n--- a/doc/guides/nics/features/cnxk.ini\n+++ b/doc/guides/nics/features/cnxk.ini\n@@ -18,6 +18,7 @@ Queue start/stop = Y\n MTU update = Y\n TSO = Y\n Promiscuous mode = Y\n+Unicast MAC filter = Y\n RSS hash = Y\n Inner RSS = Y\n Jumbo frame = Y\ndiff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini\nindex 31471e0..e1de8ab 100644\n--- a/doc/guides/nics/features/cnxk_vec.ini\n+++ b/doc/guides/nics/features/cnxk_vec.ini\n@@ -17,6 +17,7 @@ Free Tx mbuf on demand = Y\n Queue start/stop = Y\n MTU update = Y\n Promiscuous mode = Y\n+Unicast MAC filter = Y\n RSS hash = Y\n Inner RSS = Y\n Jumbo frame = Y\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex e5590a0..7b9e37b 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -1097,6 +1097,8 @@ cnxk_nix_dev_start(struct rte_eth_dev *eth_dev)\n /* CNXK platform independent eth dev ops */\n struct eth_dev_ops cnxk_eth_dev_ops = {\n \t.mtu_set = cnxk_nix_mtu_set,\n+\t.mac_addr_add = cnxk_nix_mac_addr_add,\n+\t.mac_addr_remove = cnxk_nix_mac_addr_del,\n \t.mac_addr_set = cnxk_nix_mac_addr_set,\n \t.dev_infos_get = cnxk_nix_info_get,\n \t.link_update = cnxk_nix_link_update,\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h\nindex 2fce20e..ab94b99 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.h\n+++ b/drivers/net/cnxk/cnxk_ethdev.h\n@@ -139,6 +139,7 @@ struct cnxk_eth_dev {\n \n \t/* Max macfilter entries */\n \tuint8_t max_mac_entries;\n+\tbool dmac_filter_enable;\n \n \tuint16_t flags;\n \tuint8_t ptype_disable;\n@@ -221,6 +222,10 @@ int cnxk_nix_probe(struct rte_pci_driver *pci_drv,\n \t\t struct rte_pci_device *pci_dev);\n int cnxk_nix_remove(struct rte_pci_device *pci_dev);\n int cnxk_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu);\n+int cnxk_nix_mac_addr_add(struct rte_eth_dev *eth_dev,\n+\t\t\t struct rte_ether_addr *addr, uint32_t index,\n+\t\t\t uint32_t pool);\n+void cnxk_nix_mac_addr_del(struct rte_eth_dev *eth_dev, uint32_t index);\n int cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_ether_addr *addr);\n int cnxk_nix_promisc_enable(struct rte_eth_dev *eth_dev);\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c\nindex 6feb3a9..fc60576 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_ops.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_ops.c\n@@ -101,6 +101,43 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr)\n }\n \n int\n+cnxk_nix_mac_addr_add(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr,\n+\t\t uint32_t index, uint32_t pool)\n+{\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tstruct roc_nix *nix = &dev->nix;\n+\tint rc;\n+\n+\tPLT_SET_USED(index);\n+\tPLT_SET_USED(pool);\n+\n+\trc = roc_nix_mac_addr_add(nix, addr->addr_bytes);\n+\tif (rc < 0) {\n+\t\tplt_err(\"Failed to add mac address, rc=%d\", rc);\n+\t\treturn rc;\n+\t}\n+\n+\t/* Enable promiscuous mode at NIX level */\n+\troc_nix_npc_promisc_ena_dis(nix, true);\n+\tdev->dmac_filter_enable = true;\n+\teth_dev->data->promiscuous = false;\n+\n+\treturn 0;\n+}\n+\n+void\n+cnxk_nix_mac_addr_del(struct rte_eth_dev *eth_dev, uint32_t index)\n+{\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tstruct roc_nix *nix = &dev->nix;\n+\tint rc;\n+\n+\trc = roc_nix_mac_addr_del(nix, index);\n+\tif (rc)\n+\t\tplt_err(\"Failed to delete mac address, rc=%d\", rc);\n+}\n+\n+int\n cnxk_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n {\n \tuint32_t old_frame_size, frame_size = mtu + CNXK_NIX_L2_OVERHEAD;\n@@ -212,8 +249,8 @@ cnxk_nix_promisc_disable(struct rte_eth_dev *eth_dev)\n \tif (roc_nix_is_vf_or_sdp(nix))\n \t\treturn rc;\n \n-\trc = roc_nix_npc_promisc_ena_dis(nix, false);\n-\tif (rc < 0) {\n+\trc = roc_nix_npc_promisc_ena_dis(nix, dev->dmac_filter_enable);\n+\tif (rc) {\n \t\tplt_err(\"Failed to setup promisc mode in npc, rc=%d(%s)\", rc,\n \t\t\troc_error_msg_get(rc));\n \t\treturn rc;\n@@ -223,9 +260,10 @@ cnxk_nix_promisc_disable(struct rte_eth_dev *eth_dev)\n \tif (rc) {\n \t\tplt_err(\"Failed to setup promisc mode in mac, rc=%d(%s)\", rc,\n \t\t\troc_error_msg_get(rc));\n-\t\troc_nix_npc_promisc_ena_dis(nix, true);\n+\t\troc_nix_npc_promisc_ena_dis(nix, !dev->dmac_filter_enable);\n \t\treturn rc;\n \t}\n \n+\tdev->dmac_filter_enable = false;\n \treturn 0;\n }\n", "prefixes": [ "v4", "35/62" ] }