Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94671/?format=api
{ "id": 94671, "url": "https://patches.dpdk.org/api/patches/94671/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210622122956.3130231-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210622122956.3130231-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210622122956.3130231-1-ferruh.yigit@intel.com", "date": "2021-06-22T12:29:56", "name": "kni: fix crash on userspace VA for segmented packets", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b470b8145da2b7a8db0942ba4ce9ff13cc929680", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210622122956.3130231-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 17436, "url": "https://patches.dpdk.org/api/series/17436/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17436", "date": "2021-06-22T12:29:56", "name": "kni: fix crash on userspace VA for segmented packets", "version": 1, "mbox": "https://patches.dpdk.org/series/17436/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94671/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94671/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 158A6A0548;\n\tTue, 22 Jun 2021 14:39:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 884494003F;\n\tTue, 22 Jun 2021 14:39:34 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id E1BD04003C;\n Tue, 22 Jun 2021 14:39:32 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jun 2021 05:39:28 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by fmsmga001.fm.intel.com with ESMTP; 22 Jun 2021 05:29:58 -0700" ], "IronPort-SDR": [ "\n zimeZVhcwmfSNG10mPUGW4Nyhy9m+kSWgXZ57bjITf1v0790njbAGfXsPRqnTEp5uhnBRH33o7\n 9p/nifO5M6OQ==", "\n 3U7EZIupPzLSPQvx+kVSvBogz4vEGVclYV44hHOkZMR/3GBH1IN+eqxk8fY5+Zpj2+fZA8gt89\n MV6FAKPsqpeQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10022\"; a=\"292672774\"", "E=Sophos;i=\"5.83,291,1616482800\"; d=\"scan'208\";a=\"292672774\"", "E=Sophos;i=\"5.83,291,1616482800\"; d=\"scan'208\";a=\"556602447\"" ], "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>,\n Vamsi Attunuru <vattunuru@marvell.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tdev@dpdk.org,\n\tstable@dpdk.org", "Date": "Tue, 22 Jun 2021 13:29:56 +0100", "Message-Id": "<20210622122956.3130231-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] kni: fix crash on userspace VA for segmented\n packets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When IOVA=VA, address translation for segmented packets is wrong, it\nassumes the address in the mbuf->next is physical address, not VA\naddress.\n\nFixing the address translation to work both PA & VA mode.\n\nFixes: e73831dc6c26 (\"kni: support userspace VA\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: vattunuru@marvell.com\n---\n kernel/linux/kni/kni_net.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c\nindex f259327954b2..611719b5ee27 100644\n--- a/kernel/linux/kni/kni_net.c\n+++ b/kernel/linux/kni/kni_net.c\n@@ -245,7 +245,7 @@ kni_fifo_trans_pa2va(struct kni_dev *kni,\n \t\t\t\t\tbreak;\n \n \t\t\t\tprev_kva = kva;\n-\t\t\t\tkva = pa2kva(kva->next);\n+\t\t\t\tkva = get_kva(kni, kva->next);\n \t\t\t\t/* Convert physical address to virtual address */\n \t\t\t\tprev_kva->next = pa2va(prev_kva->next, kva);\n \t\t\t}\n@@ -422,7 +422,7 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\t\t\t\tbreak;\n \n \t\t\t\tprev_kva = kva;\n-\t\t\t\tkva = pa2kva(kva->next);\n+\t\t\t\tkva = get_kva(kni, kva->next);\n \t\t\t\tdata_kva = kva2data_kva(kva);\n \t\t\t\t/* Convert physical address to virtual address */\n \t\t\t\tprev_kva->next = pa2va(prev_kva->next, kva);\n@@ -501,7 +501,7 @@ kni_net_rx_lo_fifo(struct kni_dev *kni)\n \t\t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n \t\t\twhile (kva->next) {\n-\t\t\t\tnext_kva = pa2kva(kva->next);\n+\t\t\t\tnext_kva = get_kva(kni, kva->next);\n \t\t\t\t/* Convert physical address to virtual address */\n \t\t\t\tkva->next = pa2va(kva->next, next_kva);\n \t\t\t\tkva = next_kva;\n", "prefixes": [] }