Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94667/?format=api
{ "id": 94667, "url": "https://patches.dpdk.org/api/patches/94667/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210622092531.73112-4-xhavli56@stud.fit.vutbr.cz/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210622092531.73112-4-xhavli56@stud.fit.vutbr.cz>", "list_archive_url": "https://inbox.dpdk.org/dev/20210622092531.73112-4-xhavli56@stud.fit.vutbr.cz", "date": "2021-06-22T09:25:30", "name": "[3/3] net/bonding: start ethdev prior to setting 8023ad flow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "19a965546472e366b17524b30e0cbff7bb6dc84e", "submitter": { "id": 2265, "url": "https://patches.dpdk.org/api/people/2265/?format=api", "name": "Havlík Martin", "email": "xhavli56@stud.fit.vutbr.cz" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210622092531.73112-4-xhavli56@stud.fit.vutbr.cz/mbox/", "series": [ { "id": 17432, "url": "https://patches.dpdk.org/api/series/17432/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17432", "date": "2021-06-22T09:25:27", "name": "net/bonding: make dedicated queues work with mlx5", "version": 1, "mbox": "https://patches.dpdk.org/series/17432/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94667/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94667/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89387A0C41;\n\tTue, 22 Jun 2021 11:26:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4549E410E9;\n\tTue, 22 Jun 2021 11:26:21 +0200 (CEST)", "from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])\n by mails.dpdk.org (Postfix) with ESMTP id 9608C410E8\n for <dev@dpdk.org>; Tue, 22 Jun 2021 11:26:20 +0200 (CEST)", "from dpdk-test7.liberouter.org\n ([IPv6:2001:718:800:ff00:d97f:a151:83a2:7c4f]) (authenticated bits=0)\n by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 15M9Ps4k054017\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);\n Tue, 22 Jun 2021 11:26:18 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz;\n s=studfit; t=1624353978;\n bh=ma5HQNoj3dA5aDshTkpqG+72Wd+fz7DGFtsVRsq31D0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=Ru6usjFhqJ+6OUFHuZg8Ucz7eUTFud1kzJcYTda760TXO2d4g+6nSAp61kPajKUbR\n v1JK55X7k/HqWMJ8zvvw2ZbXiBL13eg5YU4nWG2Z2GBVBVpsh/6RHI9kPGtNvufOm8\n sOBqUb4pb0Eazli5cFNlghAntcVvPVsk4asVE9lY=", "From": "Martin Havlik <xhavli56@stud.fit.vutbr.cz>", "To": "xhavli56@stud.fit.vutbr.cz, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>", "Cc": "dev@dpdk.org, Jan Viktorin <viktorin@cesnet.cz>", "Date": "Tue, 22 Jun 2021 11:25:30 +0200", "Message-Id": "<20210622092531.73112-4-xhavli56@stud.fit.vutbr.cz>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz>", "References": "<20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting\n 8023ad flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When dedicated queues are enabled, mlx5 PMD fails to install RTE Flows\nif the underlying ethdev is not started:\nbond_ethdev_8023ad_flow_set(267) - bond_ethdev_8023ad_flow_set: port not started (slave_port=0 queue_id=1)\n\nSigned-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>\nCc: Jan Viktorin <viktorin@cesnet.cz>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 26 ++++++++++++++++++--------\n 1 file changed, 18 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex a6755661c..fea3bc537 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1818,25 +1818,35 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t\t\trte_flow_destroy(slave_eth_dev->data->port_id,\n \t\t\t\t\tinternals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id],\n \t\t\t\t\t&flow_error);\n+\t}\n \n+\t/* Start device */\n+\terrval = rte_eth_dev_start(slave_eth_dev->data->port_id);\n+\tif (errval != 0) {\n+\t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_start: port=%u, err (%d)\",\n+\t\t\t\tslave_eth_dev->data->port_id, errval);\n+\t\treturn -1;\n+\t}\n+\n+\tif (internals->mode == BONDING_MODE_8023AD &&\n+\t\t\tinternals->mode4.dedicated_queues.enabled == 1) {\n \t\terrval = bond_ethdev_8023ad_flow_set(bonded_eth_dev,\n \t\t\t\tslave_eth_dev->data->port_id);\n \t\tif (errval != 0) {\n \t\t\tRTE_BOND_LOG(ERR,\n \t\t\t\t\"bond_ethdev_8023ad_flow_set: port=%d, err (%d)\",\n \t\t\t\tslave_eth_dev->data->port_id, errval);\n+\n+\t\t\terrval = rte_eth_dev_stop(slave_eth_dev->data->port_id);\n+\t\t\tif (errval < 0) {\n+\t\t\t\tRTE_BOND_LOG(ERR,\n+\t\t\t\t\t\"rte_eth_dev_stop: port=%d, err (%d)\",\n+\t\t\t\t\tslave_eth_dev->data->port_id, errval);\n+\t\t\t}\n \t\t\treturn errval;\n \t\t}\n \t}\n \n-\t/* Start device */\n-\terrval = rte_eth_dev_start(slave_eth_dev->data->port_id);\n-\tif (errval != 0) {\n-\t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_start: port=%u, err (%d)\",\n-\t\t\t\tslave_eth_dev->data->port_id, errval);\n-\t\treturn -1;\n-\t}\n-\n \t/* If RSS is enabled for bonding, synchronize RETA */\n \tif (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS) {\n \t\tint i;\n", "prefixes": [ "3/3" ] }