Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94665/?format=api
{ "id": 94665, "url": "https://patches.dpdk.org/api/patches/94665/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz>", "list_archive_url": "https://inbox.dpdk.org/dev/20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz", "date": "2021-06-22T09:25:28", "name": "[1/3] net/bonding: fix proper return value check and correct log message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b4de5df7dd1f430ad01f1e61efb25022440b79a6", "submitter": { "id": 2265, "url": "https://patches.dpdk.org/api/people/2265/?format=api", "name": "Havlík Martin", "email": "xhavli56@stud.fit.vutbr.cz" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz/mbox/", "series": [ { "id": 17432, "url": "https://patches.dpdk.org/api/series/17432/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17432", "date": "2021-06-22T09:25:27", "name": "net/bonding: make dedicated queues work with mlx5", "version": 1, "mbox": "https://patches.dpdk.org/series/17432/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94665/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/94665/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 01867A0C41;\n\tTue, 22 Jun 2021 11:26:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DF67F40DF7;\n\tTue, 22 Jun 2021 11:26:10 +0200 (CEST)", "from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])\n by mails.dpdk.org (Postfix) with ESMTP id 45EBE40DF5\n for <dev@dpdk.org>; Tue, 22 Jun 2021 11:26:09 +0200 (CEST)", "from dpdk-test7.liberouter.org\n ([IPv6:2001:718:800:ff00:d97f:a151:83a2:7c4f]) (authenticated bits=0)\n by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 15M9Ps4i054017\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);\n Tue, 22 Jun 2021 11:26:09 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz;\n s=studfit; t=1624353969;\n bh=doMoMOHm4RZrpkcCH/bdW98Xylm//PBu/qY9WWyfCUg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=N6WehzMcIdccC/GdxyliIMdL6EVClvg8KemQzq8SzYsV+wZP+9hxQ2ogCLYKwILc4\n iEdAuZoM146liHLMM1d7FbC7FymLW0wzNOyiWyUwmqxUemvCwjTJBOkndhcDVj2xcM\n MAmq53gESE2fTtgH0FuN1nkh2UplJ8UFNjoYRACY=", "From": "Martin Havlik <xhavli56@stud.fit.vutbr.cz>", "To": "xhavli56@stud.fit.vutbr.cz, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Tomasz Kulasek <tomaszx.kulasek@intel.com>,\n Declan Doherty <declan.doherty@intel.com>", "Cc": "dev@dpdk.org, Jan Viktorin <viktorin@cesnet.cz>", "Date": "Tue, 22 Jun 2021 11:25:28 +0200", "Message-Id": "<20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz>", "References": "<20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check\n and correct log message", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Return value is now saved to errval and log message on error\nreports correct function name, doesn't use q_id which was out of context,\nand uses up-to-date errval.\n\nFixes: 112891cd27e5 (\"net/bonding: add dedicated HW queues for LACP control\")\nCc: tomaszx.kulasek@intel.com\n\nSigned-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>\nCc: Jan Viktorin <viktorin@cesnet.cz>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex b01ef003e..4c43bf916 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1805,12 +1805,13 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t\t\t\t!= 0)\n \t\t\treturn errval;\n \n-\t\tif (bond_ethdev_8023ad_flow_verify(bonded_eth_dev,\n-\t\t\t\tslave_eth_dev->data->port_id) != 0) {\n+\t\terrval = bond_ethdev_8023ad_flow_verify(bonded_eth_dev,\n+\t\t\t\tslave_eth_dev->data->port_id);\n+\t\tif (errval != 0) {\n \t\t\tRTE_BOND_LOG(ERR,\n-\t\t\t\t\"rte_eth_tx_queue_setup: port=%d queue_id %d, err (%d)\",\n-\t\t\t\tslave_eth_dev->data->port_id, q_id, errval);\n-\t\t\treturn -1;\n+\t\t\t\t\"bond_ethdev_8023ad_flow_verify: port=%d, err (%d)\",\n+\t\t\t\tslave_eth_dev->data->port_id, errval);\n+\t\t\treturn errval;\n \t\t}\n \n \t\tif (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL)\n", "prefixes": [ "1/3" ] }