Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94657/?format=api
{ "id": 94657, "url": "https://patches.dpdk.org/api/patches/94657/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621150449.19070-33-tduszynski@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621150449.19070-33-tduszynski@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621150449.19070-33-tduszynski@marvell.com", "date": "2021-06-21T15:04:49", "name": "[v3,32/32] raw/cnxk_bphy: support for bphy selftest", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "527685157fffae39bbc9fb9dc1aa5f090ef8dc67", "submitter": { "id": 2215, "url": "https://patches.dpdk.org/api/people/2215/?format=api", "name": "Tomasz Duszynski", "email": "tduszynski@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621150449.19070-33-tduszynski@marvell.com/mbox/", "series": [ { "id": 17426, "url": "https://patches.dpdk.org/api/series/17426/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17426", "date": "2021-06-21T15:04:17", "name": "add support for baseband phy", "version": 3, "mbox": "https://patches.dpdk.org/series/17426/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94657/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2A905A0547;\n\tMon, 21 Jun 2021 17:08:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7B22841237;\n\tMon, 21 Jun 2021 17:06:24 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4B4A7411F5\n for <dev@dpdk.org>; Mon, 21 Jun 2021 17:06:23 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15LEuiQP003906; Mon, 21 Jun 2021 08:06:22 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 39ap171gmb-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 21 Jun 2021 08:06:22 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 21 Jun 2021 08:06:20 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 21 Jun 2021 08:06:20 -0700", "from EH-LT0048.marvell.com (unknown [10.193.32.52])\n by maili.marvell.com (Postfix) with ESMTP id E201D3F705B;\n Mon, 21 Jun 2021 08:06:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=VdeBd0N6aJfhl/nOJQkT/au5CqoizwOLJ+IJkfe851c=;\n b=SWbsdoFXzFzF0VKrdc7PmtQXagFmDx21IsDWnYtcrtjwqGk+H1Wif29hUeEmc8pZOcsq\n a4Zk+3/7rZzq/bQ3+G7eGVuamcDrfdenSU1QSPGt+FdwPH51leZSAzbuAmYxE+emGUlG\n C0+GTgZkaKalIIHQgbPZtmk/c2p/IPUIheIUnSd1rabcWof+fdrlAtjw92bT+vX00OX9\n kQ+E2m+1dE8b4C9x72p1lmEli+HQwElQ2zmUWQtdZzVRadIJoudZkyMCj0KjJWEzHfD7\n AAHuHkWsuj5+DUfD+yOGoPEpJeKYg8qWk5tGr4YEuMwVe1SCWw/L0Eh6jNpuwUwO4Wjz CA==", "From": "Tomasz Duszynski <tduszynski@marvell.com>", "To": "Jakub Palider <jpalider@marvell.com>, Tomasz Duszynski\n <tduszynski@marvell.com>", "CC": "<thomas@monjalon.net>, <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>", "Date": "Mon, 21 Jun 2021 17:04:49 +0200", "Message-ID": "<20210621150449.19070-33-tduszynski@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210621150449.19070-1-tduszynski@marvell.com>", "References": "<20210531214142.30167-1-tduszynski@marvell.com>\n <20210621150449.19070-1-tduszynski@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "cbOcUA681_jm6KMMDinRShkFSqqaihYK", "X-Proofpoint-ORIG-GUID": "cbOcUA681_jm6KMMDinRShkFSqqaihYK", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-21_06:2021-06-21,\n 2021-06-21 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 32/32] raw/cnxk_bphy: support for bphy selftest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for performing selftest.\n\nSigned-off-by: Jakub Palider <jpalider@marvell.com>\nSigned-off-by: Tomasz Duszynski <tduszynski@marvell.com>\nReviewed-by: Jerin Jacob <jerinj@marvell.com>\n---\n doc/guides/rawdevs/cnxk_bphy.rst | 7 +-\n drivers/raw/cnxk_bphy/cnxk_bphy.c | 124 ++++++++++++++++++++++++++++++\n 2 files changed, 127 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst\nindex 1e17d6071..bf7c00e6b 100644\n--- a/doc/guides/rawdevs/cnxk_bphy.rst\n+++ b/doc/guides/rawdevs/cnxk_bphy.rst\n@@ -141,15 +141,14 @@ Message must have type set to ``CNXK_BPHY_IRQ_MSG_TYPE_MEM_GET``. There's a conv\n Self test\n ---------\n \n-On EAL initialization, BPHY CGX/RPM devices will be probed and populated into\n+On EAL initialization BPHY and BPHY CGX/RPM devices will be probed and populated into\n the raw devices. The rawdev ID of the device can be obtained using invocation\n of ``rte_rawdev_get_dev_id(\"NAME:x\")`` from the test application, where:\n \n-- NAME is the desired subsystem: use \"BPHY_CGX\" for\n+- NAME is the desired subsystem: use \"BPHY\" for regular, and \"BPHY_CGX\" for\n RFOE module,\n - x is the device's bus id specified in \"bus:device.func\" (BDF) format.\n \n Use this identifier for further rawdev function calls.\n \n-The driver's selftest rawdev API can be used to verify the BPHY CGX/RPM\n-functionality.\n+Selftest rawdev API can be used to verify the BPHY and BPHY CGX/RPM functionality.\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c\nindex 2a516ae73..9cb3f8d33 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c\n@@ -11,6 +11,7 @@\n #include <rte_rawdev_pmd.h>\n \n #include <roc_api.h>\n+#include <roc_bphy_irq.h>\n \n #include \"cnxk_bphy_irq.h\"\n #include \"rte_pmd_bphy.h\"\n@@ -22,6 +23,128 @@ static const struct rte_pci_id pci_bphy_map[] = {\n \t},\n };\n \n+struct bphy_test {\n+\tint irq_num;\n+\tcnxk_bphy_intr_handler_t handler;\n+\tvoid *data;\n+\tint cpu;\n+\tbool handled_intr;\n+\tint handled_data;\n+\tint test_data;\n+};\n+\n+static struct bphy_test *test;\n+\n+static void\n+bphy_test_handler_fn(int irq_num, void *isr_data)\n+{\n+\ttest[irq_num].handled_intr = true;\n+\ttest[irq_num].handled_data = *((int *)isr_data);\n+}\n+\n+static int\n+bphy_rawdev_selftest(uint16_t dev_id)\n+{\n+\tunsigned int i, queues, descs;\n+\tuint64_t max_irq;\n+\tint ret;\n+\n+\tqueues = rte_rawdev_queue_count(dev_id);\n+\tif (queues == 0)\n+\t\treturn -ENODEV;\n+\n+\tret = rte_rawdev_start(dev_id);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = rte_rawdev_queue_conf_get(dev_id, CNXK_BPHY_DEF_QUEUE, &descs,\n+\t\t\t\t\tsizeof(descs));\n+\tif (ret)\n+\t\tgoto err_desc;\n+\tif (descs != 1) {\n+\t\tret = -ENODEV;\n+\t\tplt_err(\"Wrong number of descs reported\\n\");\n+\t\tgoto err_desc;\n+\t}\n+\n+\tret = rte_pmd_bphy_intr_init(dev_id);\n+\tif (ret) {\n+\t\tplt_err(\"intr init failed\");\n+\t\treturn ret;\n+\t}\n+\n+\tmax_irq = cnxk_bphy_irq_max_get(dev_id);\n+\n+\ttest = rte_zmalloc(\"BPHY\", max_irq * sizeof(*test), 0);\n+\tif (test == NULL) {\n+\t\tplt_err(\"intr alloc failed\");\n+\t\tgoto err_alloc;\n+\t}\n+\n+\tfor (i = 0; i < max_irq; i++) {\n+\t\ttest[i].test_data = i;\n+\t\ttest[i].irq_num = i;\n+\t\ttest[i].handler = bphy_test_handler_fn;\n+\t\ttest[i].data = &test[i].test_data;\n+\t}\n+\n+\tfor (i = 0; i < max_irq; i++) {\n+\t\tret = rte_pmd_bphy_intr_register(dev_id, test[i].irq_num,\n+\t\t\t\t\t\t test[i].handler, test[i].data,\n+\t\t\t\t\t\t 0);\n+\t\tif (ret == -ENOTSUP) {\n+\t\t\t/* In the test we iterate over all irq numbers\n+\t\t\t * so if some of them are not supported by given\n+\t\t\t * platform we treat respective results as valid\n+\t\t\t * ones. This way they have no impact on overall\n+\t\t\t * test results.\n+\t\t\t */\n+\t\t\ttest[i].handled_intr = true;\n+\t\t\ttest[i].handled_data = test[i].test_data;\n+\t\t\tret = 0;\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tif (ret) {\n+\t\t\tplt_err(\"intr register failed at irq %d\", i);\n+\t\t\tgoto err_register;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < max_irq; i++)\n+\t\troc_bphy_intr_handler(i);\n+\n+\tfor (i = 0; i < max_irq; i++) {\n+\t\tif (!test[i].handled_intr) {\n+\t\t\tplt_err(\"intr %u not handled\", i);\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\t\tif (test[i].handled_data != test[i].test_data) {\n+\t\t\tplt_err(\"intr %u has wrong handler\", i);\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+err_register:\n+\t/*\n+\t * In case of registration failure the loop goes over all\n+\t * interrupts which is safe due to internal guards in\n+\t * rte_pmd_bphy_intr_unregister().\n+\t */\n+\tfor (i = 0; i < max_irq; i++)\n+\t\trte_pmd_bphy_intr_unregister(dev_id, i);\n+\n+\trte_free(test);\n+err_alloc:\n+\trte_pmd_bphy_intr_fini(dev_id);\n+err_desc:\n+\trte_rawdev_stop(dev_id);\n+\n+\treturn ret;\n+}\n+\n static void\n bphy_rawdev_get_name(char *name, struct rte_pci_device *pci_dev)\n {\n@@ -122,6 +245,7 @@ static const struct rte_rawdev_ops bphy_rawdev_ops = {\n \t.enqueue_bufs = cnxk_bphy_irq_enqueue_bufs,\n \t.dequeue_bufs = cnxk_bphy_irq_dequeue_bufs,\n \t.queue_count = cnxk_bphy_irq_queue_count,\n+\t.dev_selftest = bphy_rawdev_selftest,\n };\n \n static int\n", "prefixes": [ "v3", "32/32" ] }