Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94656/?format=api
{ "id": 94656, "url": "https://patches.dpdk.org/api/patches/94656/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621150449.19070-32-tduszynski@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621150449.19070-32-tduszynski@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621150449.19070-32-tduszynski@marvell.com", "date": "2021-06-21T15:04:48", "name": "[v3,31/32] raw/cnxk_bphy: support for registering bphy irq handlers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b6cfa4985579925ee2339f46906bb75b044815ee", "submitter": { "id": 2215, "url": "https://patches.dpdk.org/api/people/2215/?format=api", "name": "Tomasz Duszynski", "email": "tduszynski@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621150449.19070-32-tduszynski@marvell.com/mbox/", "series": [ { "id": 17426, "url": "https://patches.dpdk.org/api/series/17426/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17426", "date": "2021-06-21T15:04:17", "name": "add support for baseband phy", "version": 3, "mbox": "https://patches.dpdk.org/series/17426/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94656/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2EA46A0547;\n\tMon, 21 Jun 2021 17:08:38 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 684184125A;\n\tMon, 21 Jun 2021 17:06:22 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 10859411FC\n for <dev@dpdk.org>; Mon, 21 Jun 2021 17:06:20 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15LEuihT003884; Mon, 21 Jun 2021 08:06:20 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 39ap171gky-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 21 Jun 2021 08:06:20 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 21 Jun 2021 08:06:18 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 21 Jun 2021 08:06:18 -0700", "from EH-LT0048.marvell.com (unknown [10.193.32.52])\n by maili.marvell.com (Postfix) with ESMTP id 189403F705E;\n Mon, 21 Jun 2021 08:06:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=nh27cr6h8+k0sCV3PzcqIv6xO1X/LvlK7bgckowybqY=;\n b=cBLk71jdPpwHdAXFK1SDBbTuAOOdeH7yoF7q8/Y+bTyf/FRvu9QIT8imTuFfadZ74TL0\n qvoJAyb7qzgppXtj9fL6FHnnm5NjtqvHckX6hCVvIz02i2gbjXbw4WzJBLbSItPYp0u4\n Uc7KGZ9H6iI5ZUUehOsLn/GUxuBy3glhvvGzgGkPTJZJ/Z/LIPFFgonJDPySmgCfIBbq\n 73YL3IYgZ5I7gvmDAIRe88DOffTjYuFhMeCFOxSGv7Nl6ElnvmSrETsMAf8HyAat45wz\n Ixf2NOSuYHyxWxeO7aeKdWhGjGv2gsjmZ7gXBw7yPD4pRproUtepSU39yOoIFTTpg+fD bA==", "From": "Tomasz Duszynski <tduszynski@marvell.com>", "To": "Jakub Palider <jpalider@marvell.com>, Tomasz Duszynski\n <tduszynski@marvell.com>", "CC": "<thomas@monjalon.net>, <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>", "Date": "Mon, 21 Jun 2021 17:04:48 +0200", "Message-ID": "<20210621150449.19070-32-tduszynski@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210621150449.19070-1-tduszynski@marvell.com>", "References": "<20210531214142.30167-1-tduszynski@marvell.com>\n <20210621150449.19070-1-tduszynski@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "IyNfyfLFGejfFI-VOVi4XDU5uHJdplwV", "X-Proofpoint-ORIG-GUID": "IyNfyfLFGejfFI-VOVi4XDU5uHJdplwV", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-21_06:2021-06-21,\n 2021-06-21 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 31/32] raw/cnxk_bphy: support for registering\n bphy irq handlers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Custom irq handlers may be registered/removed on demand.\nSince registration and removal are related they are in the\nsame patch.\n\nSigned-off-by: Jakub Palider <jpalider@marvell.com>\nSigned-off-by: Tomasz Duszynski <tduszynski@marvell.com>\nReviewed-by: Jerin Jacob <jerinj@marvell.com>\n---\n doc/guides/rawdevs/cnxk_bphy.rst | 13 ++++++++\n drivers/raw/cnxk_bphy/cnxk_bphy.c | 11 +++++++\n drivers/raw/cnxk_bphy/cnxk_bphy_irq.c | 33 ++++++++++++++++++++\n drivers/raw/cnxk_bphy/cnxk_bphy_irq.h | 4 +++\n drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 45 +++++++++++++++++++++++++++\n 5 files changed, 106 insertions(+)", "diff": "diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst\nindex 16195d2ee..1e17d6071 100644\n--- a/doc/guides/rawdevs/cnxk_bphy.rst\n+++ b/doc/guides/rawdevs/cnxk_bphy.rst\n@@ -18,6 +18,7 @@ The BPHY CGX/RPM implements following features in the rawdev API:\n \n - Access to BPHY CGX/RPM via a set of predefined messages\n - Access to BPHY memory\n+- Custom interrupt handlers\n \n Device Setup\n ------------\n@@ -117,6 +118,18 @@ are also two convenience functions namely ``rte_pmd_bphy_intr_init()`` and\n ``rte_pmd_bphy_intr_fini()`` that take care of all details.\n \n \n+Register or remove interrupt handler\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Message is used setup custom interrupt handler.\n+\n+Message must have type set to ``CNXK_BPHY_IRQ_MSG_TYPE_REGISTER`` or\n+``CNXK_BPHY_IRQ_MSG_TYPE_UNREGISTER``. The former will register an interrupt handler while the\n+latter will remove it. Prior sending actual message payload i.e ``struct cnxk_bphy_irq_info`` needs\n+to be filled with relevant information. There are also two convenience functions namely\n+``rte_pmd_bphy_intr_register()`` and ``rte_pmd_bphy_intr_unregister()`` that take care of all\n+details.\n+\n Get device memory\n ~~~~~~~~~~~~~~~~~\n \ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c\nindex 278e26af0..2a516ae73 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c\n@@ -38,6 +38,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,\n \tstruct bphy_device *bphy_dev = (struct bphy_device *)dev->dev_private;\n \tstruct cnxk_bphy_irq_msg *msg = buffers[0]->buf_addr;\n \tunsigned int queue = (size_t)context;\n+\tstruct cnxk_bphy_irq_info *info;\n \tint ret = 0;\n \n \tif (queue >= RTE_DIM(bphy_dev->queues))\n@@ -53,6 +54,16 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,\n \tcase CNXK_BPHY_IRQ_MSG_TYPE_FINI:\n \t\tcnxk_bphy_intr_fini(dev->dev_id);\n \t\tbreak;\n+\tcase CNXK_BPHY_IRQ_MSG_TYPE_REGISTER:\n+\t\tinfo = (struct cnxk_bphy_irq_info *)msg->data;\n+\t\tret = cnxk_bphy_intr_register(dev->dev_id, info->irq_num,\n+\t\t\t\t\t info->handler, info->data,\n+\t\t\t\t\t info->cpu);\n+\t\tbreak;\n+\tcase CNXK_BPHY_IRQ_MSG_TYPE_UNREGISTER:\n+\t\tinfo = (struct cnxk_bphy_irq_info *)msg->data;\n+\t\tcnxk_bphy_intr_unregister(dev->dev_id, info->irq_num);\n+\t\tbreak;\n \tcase CNXK_BPHY_IRQ_MSG_TYPE_MEM_GET:\n \t\tbphy_dev->queues[queue].rsp = &bphy_dev->mem;\n \t\tbreak;\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c\nindex 13a0d8ad1..bbcc285a7 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c\n@@ -58,6 +58,39 @@ cnxk_bphy_intr_fini(uint16_t dev_id)\n \tbphy_dev->irq_chip = NULL;\n }\n \n+int\n+cnxk_bphy_intr_register(uint16_t dev_id, int irq_num,\n+\t\t\tcnxk_bphy_intr_handler_t handler, void *data, int cpu)\n+{\n+\tstruct roc_bphy_intr intr = {\n+\t\t.irq_num = irq_num,\n+\t\t.intr_handler = handler,\n+\t\t.isr_data = data,\n+\t\t.cpu = cpu\n+\t};\n+\n+\tstruct bphy_device *bphy_dev = cnxk_bphy_get_bphy_dev_by_dev_id(dev_id);\n+\tstruct roc_bphy_irq_chip *irq_chip = bphy_dev->irq_chip;\n+\n+\tif (!irq_chip)\n+\t\treturn -ENODEV;\n+\tif (!handler || !data)\n+\t\treturn -EINVAL;\n+\n+\treturn roc_bphy_intr_register(irq_chip, &intr);\n+}\n+\n+void\n+cnxk_bphy_intr_unregister(uint16_t dev_id, int irq_num)\n+{\n+\tstruct bphy_device *bphy_dev = cnxk_bphy_get_bphy_dev_by_dev_id(dev_id);\n+\n+\tif (bphy_dev->irq_chip)\n+\t\troc_bphy_handler_clear(bphy_dev->irq_chip, irq_num);\n+\telse\n+\t\tplt_err(\"Missing irq chip\");\n+}\n+\n struct bphy_mem *\n cnxk_bphy_mem_get(uint16_t dev_id)\n {\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h\nindex 5f87143a0..b55147b93 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h\n@@ -32,6 +32,10 @@ struct bphy_device {\n int cnxk_bphy_intr_init(uint16_t dev_id);\n void cnxk_bphy_intr_fini(uint16_t dev_id);\n struct bphy_mem *cnxk_bphy_mem_get(uint16_t dev_id);\n+int cnxk_bphy_intr_register(uint16_t dev_id, int irq_num,\n+\t\t\t cnxk_bphy_intr_handler_t handler,\n+\t\t\t void *isr_data, int cpu);\n+void cnxk_bphy_intr_unregister(uint16_t dev_id, int irq_num);\n uint64_t cnxk_bphy_irq_max_get(uint16_t dev_id);\n \n #endif /* _CNXK_BPHY_IRQ_ */\ndiff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\nindex d08b14b57..f3387f38e 100644\n--- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\n+++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\n@@ -118,6 +118,8 @@ struct cnxk_bphy_irq_msg {\n \tenum cnxk_bphy_irq_msg_type type;\n \t/*\n \t * The data field, depending on message type, may point to\n+\t * - (enq) full struct cnxk_bphy_irq_info for registration request\n+\t * - (enq) struct cnxk_bphy_irq_info with irq_num set for unregistration\n \t * - (deq) struct cnxk_bphy_mem for memory range request response\n \t * - (xxx) NULL\n \t */\n@@ -161,6 +163,49 @@ rte_pmd_bphy_intr_fini(uint16_t dev_id)\n \trte_rawdev_enqueue_buffers(dev_id, bufs, 1, CNXK_BPHY_DEF_QUEUE);\n }\n \n+static __rte_always_inline int\n+rte_pmd_bphy_intr_register(uint16_t dev_id, int irq_num,\n+\t\t\t cnxk_bphy_intr_handler_t handler, void *data,\n+\t\t\t int cpu)\n+{\n+\tstruct cnxk_bphy_irq_info info = {\n+\t\t.irq_num = irq_num,\n+\t\t.handler = handler,\n+\t\t.data = data,\n+\t\t.cpu = cpu,\n+\t};\n+\tstruct cnxk_bphy_irq_msg msg = {\n+\t\t.type = CNXK_BPHY_IRQ_MSG_TYPE_REGISTER,\n+\t\t.data = &info\n+\t};\n+\tstruct rte_rawdev_buf *bufs[1];\n+\tstruct rte_rawdev_buf buf;\n+\n+\tbuf.buf_addr = &msg;\n+\tbufs[0] = &buf;\n+\n+\treturn rte_rawdev_enqueue_buffers(dev_id, bufs, 1, CNXK_BPHY_DEF_QUEUE);\n+}\n+\n+static __rte_always_inline void\n+rte_pmd_bphy_intr_unregister(uint16_t dev_id, int irq_num)\n+{\n+\tstruct cnxk_bphy_irq_info info = {\n+\t\t.irq_num = irq_num,\n+\t};\n+\tstruct cnxk_bphy_irq_msg msg = {\n+\t\t.type = CNXK_BPHY_IRQ_MSG_TYPE_UNREGISTER,\n+\t\t.data = &info\n+\t};\n+\tstruct rte_rawdev_buf *bufs[1];\n+\tstruct rte_rawdev_buf buf;\n+\n+\tbuf.buf_addr = &msg;\n+\tbufs[0] = &buf;\n+\n+\trte_rawdev_enqueue_buffers(dev_id, bufs, 1, 0);\n+}\n+\n static __rte_always_inline struct cnxk_bphy_mem *\n rte_pmd_bphy_intr_mem_get(uint16_t dev_id)\n {\n", "prefixes": [ "v3", "31/32" ] }