Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94618/?format=api
{ "id": 94618, "url": "https://patches.dpdk.org/api/patches/94618/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621085923.1286701-1-wenjun1.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621085923.1286701-1-wenjun1.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621085923.1286701-1-wenjun1.wu@intel.com", "date": "2021-06-21T08:59:23", "name": "[v1] net/ice/base: fix wrong first mask value setting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "06b32a5d15df14fdfa69ebf930c3bd8fe820469c", "submitter": { "id": 2083, "url": "https://patches.dpdk.org/api/people/2083/?format=api", "name": "Wenjun Wu", "email": "wenjun1.wu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621085923.1286701-1-wenjun1.wu@intel.com/mbox/", "series": [ { "id": 17423, "url": "https://patches.dpdk.org/api/series/17423/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17423", "date": "2021-06-21T08:59:23", "name": "[v1] net/ice/base: fix wrong first mask value setting", "version": 1, "mbox": "https://patches.dpdk.org/series/17423/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94618/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CA305A0547;\n\tMon, 21 Jun 2021 11:17:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5033141158;\n\tMon, 21 Jun 2021 11:17:08 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id B9C2040040;\n Mon, 21 Jun 2021 11:17:05 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 02:17:04 -0700", "from wuwenjun.sh.intel.com ([10.67.110.207])\n by fmsmga002.fm.intel.com with ESMTP; 21 Jun 2021 02:17:02 -0700" ], "IronPort-SDR": [ "\n O/scTFxqUk9cN/gUy9Ia+vF/NekWq2bEFwcZ/qWUzqHxKi4+Kt/YzkPE70ssijjeL4wJWIEocE\n 16hE7LATEurQ==", "\n O5wkaGN67yVOT2wc2IrjXe0jCkQDk9GeqW6MjcFWca4z5F+8MMwIoaWDmFfddRHE048nubWTg8\n p/F/mx2MGrZQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10021\"; a=\"193942812\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"193942812\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"489813288\"" ], "X-ExtLoop1": "1", "From": "Wenjun Wu <wenjun1.wu@intel.com>", "To": "dev@dpdk.org,\n\tqiming.yang@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "Wenjun Wu <wenjun1.wu@intel.com>,\n\tstable@dpdk.org", "Date": "Mon, 21 Jun 2021 16:59:23 +0800", "Message-Id": "<20210621085923.1286701-1-wenjun1.wu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ice/base: fix wrong first mask value\n setting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since each pf does not share the same structure space, the first\nmask value should start at 0 instead of hw->pf_id * per_pf to avoid\naddress overflow. Otherwise, address space will overlap when\nmasks.first + masks.count > ICE_PROF_MASK_COUNT, and it may lead to\nunexpected variable assignment, which causes segmentation fault.\n\nFixes: 9467486f179f (\"net/ice/base: enable masking for RSS and FD field vectors\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wenjun Wu <wenjun1.wu@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex fabff039ec..aa42177833 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -3435,7 +3435,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)\n \tper_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;\n \n \thw->blk[blk].masks.count = per_pf;\n-\thw->blk[blk].masks.first = hw->pf_id * per_pf;\n+\thw->blk[blk].masks.first = 0;\n \n \tice_memset(hw->blk[blk].masks.masks, 0,\n \t\t sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);\n", "prefixes": [ "v1" ] }