Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94616/?format=api
{ "id": 94616, "url": "https://patches.dpdk.org/api/patches/94616/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621080342.184889-1-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621080342.184889-1-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621080342.184889-1-stevex.yang@intel.com", "date": "2021-06-21T08:03:42", "name": "[v3] net/i40e: fix set rss hash function invalid", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "db285bc64e8496d1ae495fc0c627d1cacaf2ac48", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621080342.184889-1-stevex.yang@intel.com/mbox/", "series": [ { "id": 17421, "url": "https://patches.dpdk.org/api/series/17421/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17421", "date": "2021-06-21T08:03:42", "name": "[v3] net/i40e: fix set rss hash function invalid", "version": 3, "mbox": "https://patches.dpdk.org/series/17421/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94616/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94616/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31AFEA0547;\n\tMon, 21 Jun 2021 10:05:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 219504116E;\n\tMon, 21 Jun 2021 10:05:53 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 1D6B840040;\n Mon, 21 Jun 2021 10:05:50 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 01:05:49 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.194])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 01:05:47 -0700" ], "IronPort-SDR": [ "\n jf9DRkj7HUV7RN2IpYh2aP+HMnQAV9v5IBgC4b1E7KjiWkDZSTmvz0VR2OYBkg6wGb+M6P3prh\n I7aykrML6YKQ==", "\n jAVprk4SjrPLZ4H38gcpcXKqtughq9gTdlQXPEya79Brb9Q9XG9lrZ3BBnjf0VOQ7PRKPOYzZ3\n 64C7IpOOUDNA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10021\"; a=\"206839660\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"206839660\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"486400793\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, Steve Yang <stevex.yang@intel.com>, stable@dpdk.org", "Date": "Mon, 21 Jun 2021 08:03:42 +0000", "Message-Id": "<20210621080342.184889-1-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210611065457.988344-1-stevex.yang@intel.com>", "References": "<20210611065457.988344-1-stevex.yang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "i40e can support following rss hash function types: default/toeplitz,\nsymmetric toeplitz, and simple_xor. However, when filter engine parses\npattern action, it only supports symmetric toeplitz & default.\n\nAdd simple_xor and toeplitz hash functions support when parsing pattern\naction.\n\nFixes: ef4c16fd9148 (\"net/i40e: refactor RSS flow\")\nCc: stable@dpdk.org\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\nv3:\n - add Cc stable line.\nv2:\n - add the fix line.\n - support simple_xor and toeplitz hash functions explicitly.\n\n drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------\n 1 file changed, 14 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c\nindex b1cb24f437..0cef21c88f 100644\n--- a/drivers/net/i40e/i40e_hash.c\n+++ b/drivers/net/i40e/i40e_hash.c\n@@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev,\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"RSS Queues not supported when pattern specified\");\n \n-\tif (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)\n+\tswitch (rss_act->func) {\n+\tcase RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:\n \t\trss_conf->symmetric_enable = true;\n-\telse if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)\n-\t\treturn rte_flow_error_set(error, -EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n-\t\t\t\t\t NULL,\n-\t\t\t\t\t \"Only symmetric TOEPLITZ supported when pattern specified\");\n+\t\tbreak;\n+\tcase RTE_ETH_HASH_FUNCTION_DEFAULT:\n+\tcase RTE_ETH_HASH_FUNCTION_TOEPLITZ:\n+\tcase RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:\n+\t\tbreak;\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION_CONF,\n+\t\t\t\tNULL,\n+\t\t\t\t\"RSS hash function not supported \"\n+\t\t\t\t\"when pattern specified\");\n+\t}\n \n \tif (!i40e_hash_validate_rss_types(rss_act->types))\n \t\treturn rte_flow_error_set(error, EINVAL,\n", "prefixes": [ "v3" ] }