Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94614/?format=api
{ "id": 94614, "url": "https://patches.dpdk.org/api/patches/94614/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621075206.4020456-15-robinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621075206.4020456-15-robinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621075206.4020456-15-robinx.zhang@intel.com", "date": "2021-06-21T07:52:05", "name": "[v3,14/15] net/i40e/base: fix checksum is used before return value is checked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2dfa9e018b8eb3f2498dc77dcf2188bcacd7a30", "submitter": { "id": 2004, "url": "https://patches.dpdk.org/api/people/2004/?format=api", "name": "Robin Zhang", "email": "robinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621075206.4020456-15-robinx.zhang@intel.com/mbox/", "series": [ { "id": 17420, "url": "https://patches.dpdk.org/api/series/17420/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17420", "date": "2021-06-21T07:51:52", "name": "i40e base code update", "version": 3, "mbox": "https://patches.dpdk.org/series/17420/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94614/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94614/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C185A0547;\n\tMon, 21 Jun 2021 10:04:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 65930411AA;\n\tMon, 21 Jun 2021 10:03:16 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id DD24D4117E;\n Mon, 21 Jun 2021 10:03:13 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 01:03:13 -0700", "from unknown (HELO intel-npg-odc-srv03.cd.intel.com)\n ([10.240.178.145])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 01:03:11 -0700" ], "IronPort-SDR": [ "\n AU0khS9/ZKqjfFgmTishdFxNq7FOgW5cW+bQV03g8J/6Q7c5N2vLDmTY33bBoNJWdR7BqVIuav\n e7g0w5juWT3Q==", "\n EmYaM/Bv0fObtx5mgFFoLYmDacQUmrMq6J1XHji/B3ZEB6QkaHxUQlX9jQkZJlhTTjpclOC+Xh\n 7o7WZ/tozxYQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10021\"; a=\"270643286\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"270643286\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"452102092\"" ], "From": "Robin Zhang <robinx.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, junfeng.guo@intel.com, stevex.yang@intel.com,\n Robin Zhang <robinx.zhang@intel.com>, stable@dpdk.org,\n Christopher Pau <christopher.pau@intel.com>", "Date": "Mon, 21 Jun 2021 07:52:05 +0000", "Message-Id": "<20210621075206.4020456-15-robinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210621075206.4020456-1-robinx.zhang@intel.com>", "References": "<20210618063851.3694702-1-robinx.zhang@intel.com>\n <20210621075206.4020456-1-robinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 14/15] net/i40e/base: fix checksum is used\n before return value is checked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The variable checksum from i40e_calc_nvm_checksum is used before return\nvalue is checked. Fix this logic.\n\nFixes: 8db9e2a1b232 (\"i40e: base driver\")\nFixes: 3ed6c3246f43 (\"i40e/base: handle AQ timeout when releasing NVM\")\nCc: stable@dpdk.org\n\nSigned-off-by: Christopher Pau <christopher.pau@intel.com>\nSigned-off-by: Robin Zhang <robinx.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_nvm.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c\nindex 67e58cc195..f385042601 100644\n--- a/drivers/net/i40e/base/i40e_nvm.c\n+++ b/drivers/net/i40e/base/i40e_nvm.c\n@@ -755,10 +755,11 @@ enum i40e_status_code i40e_update_nvm_checksum(struct i40e_hw *hw)\n \tDEBUGFUNC(\"i40e_update_nvm_checksum\");\n \n \tret_code = i40e_calc_nvm_checksum(hw, &checksum);\n-\tle_sum = CPU_TO_LE16(checksum);\n-\tif (ret_code == I40E_SUCCESS)\n+\tif (ret_code == I40E_SUCCESS) {\n+\t\tle_sum = CPU_TO_LE16(checksum);\n \t\tret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,\n \t\t\t\t\t 1, &le_sum, true);\n+\t}\n \n \treturn ret_code;\n }\n", "prefixes": [ "v3", "14/15" ] }