Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94613/?format=api
{ "id": 94613, "url": "https://patches.dpdk.org/api/patches/94613/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621075206.4020456-14-robinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621075206.4020456-14-robinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621075206.4020456-14-robinx.zhang@intel.com", "date": "2021-06-21T07:52:04", "name": "[v3,13/15] net/i40e/base: fix potentially uninitialized variables in NVM code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1dc325d76dc0c6cfaf05d0b556c3f5878f7b9e1b", "submitter": { "id": 2004, "url": "https://patches.dpdk.org/api/people/2004/?format=api", "name": "Robin Zhang", "email": "robinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621075206.4020456-14-robinx.zhang@intel.com/mbox/", "series": [ { "id": 17420, "url": "https://patches.dpdk.org/api/series/17420/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17420", "date": "2021-06-21T07:51:52", "name": "i40e base code update", "version": 3, "mbox": "https://patches.dpdk.org/series/17420/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94613/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B2B4A0547;\n\tMon, 21 Jun 2021 10:04:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0AE104118D;\n\tMon, 21 Jun 2021 10:03:13 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id E7D2B411D0;\n Mon, 21 Jun 2021 10:03:10 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 01:03:10 -0700", "from unknown (HELO intel-npg-odc-srv03.cd.intel.com)\n ([10.240.178.145])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jun 2021 01:03:07 -0700" ], "IronPort-SDR": [ "\n u53+I3W2nbIrHIz5m+6LKTBcbGxAAkf/FKf623og96LF4A5auV7PFpKf0dk05dFInfoKXVsbe+\n 9MF6eyG+v5BQ==", "\n OobHYa2lMclsJGtZb7dJooqEIY1qqdVsSC/pXYqGob9oDhKYgNoVVxMzF4BS9QqrX+tNL5FV7x\n Nn2q79gp1bzQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10021\"; a=\"270643276\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"270643276\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"452102072\"" ], "From": "Robin Zhang <robinx.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, junfeng.guo@intel.com, stevex.yang@intel.com,\n Robin Zhang <robinx.zhang@intel.com>, stable@dpdk.org,\n Christopher Pau <christopher.pau@intel.com>", "Date": "Mon, 21 Jun 2021 07:52:04 +0000", "Message-Id": "<20210621075206.4020456-14-robinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210621075206.4020456-1-robinx.zhang@intel.com>", "References": "<20210618063851.3694702-1-robinx.zhang@intel.com>\n <20210621075206.4020456-1-robinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 13/15] net/i40e/base: fix potentially\n uninitialized variables in NVM code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The status of i40e_read_nvm_word is not checked, so variables set\nfrom this function could be used uninitialized. In this case, preserve\nthe existing flow that does not block initialization by initializing\nthese values from the start.\n\nFixes: 8d6c51fcd24b (\"i40e/base: get OEM version\")\nFixes: 2db70574247b (\"net/i40e/base: limit PF/VF specific code to that driver only\")\nCc: stable@dpdk.org\n\nSigned-off-by: Christopher Pau <christopher.pau@intel.com>\nSigned-off-by: Robin Zhang <robinx.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c\nindex eafacbdbec..d27ccde29a 100644\n--- a/drivers/net/i40e/base/i40e_adminq.c\n+++ b/drivers/net/i40e/base/i40e_adminq.c\n@@ -648,8 +648,10 @@ enum i40e_status_code i40e_init_adminq(struct i40e_hw *hw)\n {\n \tstruct i40e_adminq_info *aq = &hw->aq;\n \tenum i40e_status_code ret_code;\n-\tu16 cfg_ptr, oem_hi, oem_lo;\n-\tu16 eetrack_lo, eetrack_hi;\n+\tu16 oem_hi = 0, oem_lo = 0;\n+\tu16 eetrack_hi = 0;\n+\tu16 eetrack_lo = 0;\n+\tu16 cfg_ptr = 0;\n \tint retry = 0;\n \n \t/* verify input for valid configuration */\n", "prefixes": [ "v3", "13/15" ] }