Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94555/?format=api
{ "id": 94555, "url": "https://patches.dpdk.org/api/patches/94555/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210619135628.1626-1-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210619135628.1626-1-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210619135628.1626-1-viacheslavo@nvidia.com", "date": "2021-06-19T13:56:28", "name": "common/mlx5: fix Netlink port name attribute padding", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f6b1faed1c49f032333c3c392912e1d74088c6ca", "submitter": { "id": 1926, "url": "https://patches.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210619135628.1626-1-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 17407, "url": "https://patches.dpdk.org/api/series/17407/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17407", "date": "2021-06-19T13:56:28", "name": "common/mlx5: fix Netlink port name attribute padding", "version": 1, "mbox": "https://patches.dpdk.org/series/17407/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94555/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AA43A0A0C;\n\tSat, 19 Jun 2021 15:56:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D0E6B40E64;\n\tSat, 19 Jun 2021 15:56:51 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2063.outbound.protection.outlook.com [40.107.244.63])\n by mails.dpdk.org (Postfix) with ESMTP id 648C540E32;\n Sat, 19 Jun 2021 15:56:50 +0200 (CEST)", "from BN9PR03CA0554.namprd03.prod.outlook.com (2603:10b6:408:138::19)\n by MW2PR12MB2524.namprd12.prod.outlook.com (2603:10b6:907:9::27) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Sat, 19 Jun\n 2021 13:56:47 +0000", "from BN8NAM11FT028.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:138:cafe::14) by BN9PR03CA0554.outlook.office365.com\n (2603:10b6:408:138::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19 via Frontend\n Transport; Sat, 19 Jun 2021 13:56:47 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT028.mail.protection.outlook.com (10.13.176.225) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4242.16 via Frontend Transport; Sat, 19 Jun 2021 13:56:47 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 19 Jun\n 2021 13:56:45 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jTyDyKTy1I57i0Gz2Z5uP8Nr32ZPE8iWeWQBeatvt/fHnj1ZSaZEzedtb6OAv8aOXSH4rtwnlVoV6rbYQeyzW+BqsoIQNWlSe5UOP+NiIQgeXwsHpjkiGgSt5Hqstcs7jMone+r7j1y2m3uBW8zlUULHpdMnq/p03K5YDKZsThrOOZTiKjEP7edo2lXrXuAlXwWrRrcNV50DOQ8lwtD7Ug0L4pHj7zV0K2rrKzds6UYLtPGQT3l4ApZtiyTeeiwRlCffz93fIMuQ/bDazDquwgxre4ypP7GE49L5qJ5AIkIRrejb3q6jIkb635WNt99uiXb0IJ/6IWS5ztOKAonxxQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XvVxKrc7kgvKJ+LeX44b1uDTzNYO3yIZhdgFbOTMajE=;\n b=eQrJcMjPhv6Su0RfjpvOeK3SxVWknaXADfml16nXcFWEEn5ccydoEGCj3BMe5oQ0e3EqFSzuGsblJsSJhhsWR3JoJ1V79ajlyWwOiw1viqzbrw5sPqPKzGSEeZSkWaxMV8r0znMm3/FJvPFnWUfHMBnbXetZRvDZ6/HTWqo/Ht+TlM88lWMgXehaZ4iuAOxAt7EMIHB9QddtiMhB6LcyN85k6/amELqAH48iyFgM25OjwxXjZZhDkDwgaTZ0im/A+AP0eqc7iKuSfD6r+0HYErHR5tGLcWyS8qNoXm6V9okWZJkPUckfeBp7yaYD4yC6Xn8QQ3YV9yGp7SC5zuI00A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XvVxKrc7kgvKJ+LeX44b1uDTzNYO3yIZhdgFbOTMajE=;\n b=Rf4Y1/urWKHi69h952O4OHCw2n56bKnCmjMEt6vCMfstQZtWsZNkrbC1j8ACnXz2gLhp3mKe4pzrmL/Fu3A8l7b1slBpMF36wO9J3QxPIC4m4Xao9Ag/ZipML+Rbug0YkEfIkZmGFFnBWgWQZIQUhb6Qn0SZahIPPUNrIvdHCQZXivyRRdFowcBxcuPoWd5+litrx07hVSuI7SySYWSjKmRZWrvIEgxJv3Ule3N+CAxjx5SbBD4NWBSrGrRc/30asMaBQLonn/PMoKRr/7swXP2/WGS//bqSMaf7zUcpdNGp9Z2uOG1R4bwGjLaUhH/f0qtBKLp0QRG5iTaBfIHTXQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<rasland@nvidia.com>, <matan@nvidia.com>, <stable@dpdk.org>", "Date": "Sat, 19 Jun 2021 16:56:28 +0300", "Message-ID": "<20210619135628.1626-1-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "0bd12ca0-ecec-4dfe-009b-08d9332a148d", "X-MS-TrafficTypeDiagnostic": "MW2PR12MB2524:", "X-Microsoft-Antispam-PRVS": "\n <MW2PR12MB2524581CD7ECDC72862776D8DF0C9@MW2PR12MB2524.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7219;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n j8tPD6PlC7atp7/Zz9BHINvdY1P0BZ66bAI4PcbyDiYI7O5BJeonKqjFMo7M5ypbIub93VJui5df2jWFFox+GTONHf2JHEjw0wIyOtC0pX/HwXZQbwBdEnQmo/yMRvcOy5pPh0E7fgU3fXVM1nzgSNwexo0IFRE0O3ZpaVv3uWmNRHhOlaJ4P8xWLZ9H+PeL1zhWn5XU74WmF0zSeqf9pE5Z8MNvc7COjgnGVJnh8fyXgovl65Ak0A/5a+P0u0MgaRl5B2IBPNcNS3FcznPKsnsVzelGOkbjL2KUZwdBJKNUkbFXVlVNpgYMHJ6yfvrnZ6EUWTqLMm22YTSCAlzLWMTH4KN6yd8xVPStLb5VuTx/jwyUNDJnyPm1YHNjmJCmPdNQpgARcbqJkdOqID+yFObItZKFb9DhiV2DgVYYNk8yTM7jAD1p4RLpSIRgGk+BmWHAZd4+aQLfsGLsfUE5gjk6rCN6f9RFgBfoLnwEhTLTH5x29ittgPoJtoVavjNpfc0LAUmNxN5txmHd/io0RRsFTBcQ2zuFQBbhOES+LPATnXsoutXD5w+kwkcUPw5NJ9g4+XNy9nlMMCQkOfN0O4uQQdKfF8DA3AEG9DvcHUvz3AIe7XtpkQMjbQXFriX8oTHu519V4tP6n3aSuXNC5gtSvrtBPIGAxlnYFyh79fc=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(136003)(346002)(376002)(39860400002)(396003)(36840700001)(46966006)(54906003)(316002)(83380400001)(426003)(478600001)(36906005)(336012)(186003)(36860700001)(26005)(6286002)(2616005)(16526019)(7696005)(356005)(4326008)(47076005)(6666004)(7636003)(450100002)(2906002)(82310400003)(5660300002)(82740400003)(8936002)(86362001)(55016002)(8676002)(6916009)(36756003)(1076003)(70586007)(70206006);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Jun 2021 13:56:47.4244 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0bd12ca0-ecec-4dfe-009b-08d9332a148d", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT028.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW2PR12MB2524", "Subject": "[dpdk-dev] [PATCH] common/mlx5: fix Netlink port name attribute\n padding", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On some kernels the string attributes within Netlink\nreply messages might be not padded with zeroes (in cases\nwhen string length is aligned with 4-byte boundary).\nThis caused wrong physical port names recognition and\nmlx5 PMD load failures.\n\nFixes: 30a86157f6d5 (\"net/mlx5: support PF representor\")\nCc: stable@dpdk.org\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/common/mlx5/linux/mlx5_nl.c | 22 +++++++++++++++++++++-\n 1 file changed, 21 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c\nindex f0d04f9473..3f1912d078 100644\n--- a/drivers/common/mlx5/linux/mlx5_nl.c\n+++ b/drivers/common/mlx5/linux/mlx5_nl.c\n@@ -33,6 +33,8 @@\n #define MLX5_SEND_BUF_SIZE 32768\n /* Receive buffer size for the Netlink socket */\n #define MLX5_RECV_BUF_SIZE 32768\n+/* Maximal physical port name length. */\n+#define MLX5_PHYS_PORT_NAME_MAX 128\n \n /** Parameters of VLAN devices created by driver. */\n #define MLX5_VMWA_VLAN_DEVICE_PFX \"evmlx\"\n@@ -1191,6 +1193,7 @@ mlx5_nl_switch_info_cb(struct nlmsghdr *nh, void *arg)\n \tsize_t off = NLMSG_LENGTH(sizeof(struct ifinfomsg));\n \tbool switch_id_set = false;\n \tbool num_vf_set = false;\n+\tint len;\n \n \tif (nh->nlmsg_type != RTM_NEWLINK)\n \t\tgoto error;\n@@ -1206,7 +1209,24 @@ mlx5_nl_switch_info_cb(struct nlmsghdr *nh, void *arg)\n \t\t\tnum_vf_set = true;\n \t\t\tbreak;\n \t\tcase IFLA_PHYS_PORT_NAME:\n-\t\t\tmlx5_translate_port_name((char *)payload, &info);\n+\t\t\tlen = RTA_PAYLOAD(ra);\n+\t\t\t/* Some kernels do not pad attributes with zero. */\n+\t\t\tif (len > 0 && len < MLX5_PHYS_PORT_NAME_MAX) {\n+\t\t\t\tchar name[MLX5_PHYS_PORT_NAME_MAX];\n+\n+\t\t\t\t/*\n+\t\t\t\t * We can't just patch the message with padding\n+\t\t\t\t * zero - it might corrupt the following items\n+\t\t\t\t * in the message, we have to copy the string\n+\t\t\t\t * by attribute length and pad the copied one.\n+\t\t\t\t */\n+\t\t\t\tmemcpy(name, payload, len);\n+\t\t\t\tname[len] = 0;\n+\t\t\t\tmlx5_translate_port_name(name, &info);\n+\t\t\t} else {\n+\t\t\t\tinfo.name_type =\n+\t\t\t\t\tMLX5_PHYS_PORT_NAME_TYPE_UNKNOWN;\n+\t\t\t}\n \t\t\tbreak;\n \t\tcase IFLA_PHYS_SWITCH_ID:\n \t\t\tinfo.switch_id = 0;\n", "prefixes": [] }