Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94510/?format=api
{ "id": 94510, "url": "https://patches.dpdk.org/api/patches/94510/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210618140357.255995-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210618140357.255995-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210618140357.255995-4-maxime.coquelin@redhat.com", "date": "2021-06-18T14:03:53", "name": "[v6,3/7] vhost: fix missing cache logging NUMA realloc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "42e9946c0cd400442ea10d04b6640b0ebb5401ce", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210618140357.255995-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 17399, "url": "https://patches.dpdk.org/api/series/17399/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17399", "date": "2021-06-18T14:03:50", "name": "vhost: Fix and improve NUMA reallocation", "version": 6, "mbox": "https://patches.dpdk.org/series/17399/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94510/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23481A0C46;\n\tFri, 18 Jun 2021 16:04:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 47E0241104;\n\tFri, 18 Jun 2021 16:04:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 2C80540142\n for <dev@dpdk.org>; Fri, 18 Jun 2021 16:04:14 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-592-rPFOcrUiNbeFTa-vWVavJw-1; Fri, 18 Jun 2021 10:04:12 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEC25800C60;\n Fri, 18 Jun 2021 14:04:11 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.21])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CE4B22C016;\n Fri, 18 Jun 2021 14:04:10 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1624025053;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4nA/YdQzawgs4cnJ0LJABUiVp395zGgXIjBbifv+O5A=;\n b=VjKEldILm8uldifBvCrhbjVWzW1r2XCvVVtjGiGieu8noiCJT8skP8jlFZxbN7l/gdtgQH\n x1us6psE3KkkVqagFnHbxAMXA9Mpw0w9jlTqkj8YttP8XlcLURKAE1lDE5jX6Ab8pf9dvG\n HDzf8UlG+muT6s5s5pvbm9xQhBhROJI=", "X-MC-Unique": "rPFOcrUiNbeFTa-vWVavJw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 18 Jun 2021 16:03:53 +0200", "Message-Id": "<20210618140357.255995-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210618140357.255995-1-maxime.coquelin@redhat.com>", "References": "<20210618140357.255995-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v6 3/7] vhost: fix missing cache logging NUMA\n realloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the guest allocates virtqueues on a different NUMA node\nthan the one the Vhost metadata are allocated, both the Vhost\ndevice struct and the virtqueues struct are reallocated.\n\nHowever, reallocating the log cache on the new NUMA node was\nnot done. This patch fixes this by reallocating it if it has\nbeen allocated already, which means a live-migration is\non-going.\n\nFixes: 1818a63147fb (\"vhost: move dirty logging cache out of virtqueue\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost_user.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 5fb055ea2e..82adf80fe5 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -545,6 +545,16 @@ numa_realloc(struct virtio_net *dev, int index)\n \t\t\tvq->batch_copy_elems = new_batch_copy_elems;\n \t\t}\n \n+\t\tif (vq->log_cache) {\n+\t\t\tstruct log_cache_entry *log_cache;\n+\n+\t\t\tlog_cache = rte_realloc_socket(vq->log_cache,\n+\t\t\t\t\tsizeof(struct log_cache_entry) * VHOST_LOG_CACHE_NR,\n+\t\t\t\t\t0, newnode);\n+\t\t\tif (log_cache)\n+\t\t\t\tvq->log_cache = log_cache;\n+\t\t}\n+\n \t\trte_free(old_vq);\n \t}\n \n", "prefixes": [ "v6", "3/7" ] }