Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94503/?format=api
{ "id": 94503, "url": "https://patches.dpdk.org/api/patches/94503/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210618135735.253770-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210618135735.253770-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210618135735.253770-2-maxime.coquelin@redhat.com", "date": "2021-06-18T13:57:32", "name": "[v5,1/4] vhost: fix missing memory table NUMA realloc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a751596be8b5b8f464746af2c811ae5ce0bf3580", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210618135735.253770-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 17398, "url": "https://patches.dpdk.org/api/series/17398/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17398", "date": "2021-06-18T13:57:31", "name": "vhost: Fix and improve NUMA reallocation", "version": 5, "mbox": "https://patches.dpdk.org/series/17398/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94503/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94503/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2285EA0C46;\n\tFri, 18 Jun 2021 15:57:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A9D5410F3;\n\tFri, 18 Jun 2021 15:57:54 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 3922740142\n for <dev@dpdk.org>; Fri, 18 Jun 2021 15:57:52 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-290-LioqU7UxOg6SZK6249eMZQ-1; Fri, 18 Jun 2021 09:57:47 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7ED4C8030D6;\n Fri, 18 Jun 2021 13:57:46 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.21])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3CA1D60BE5;\n Fri, 18 Jun 2021 13:57:45 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1624024671;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=p5ifyoguWwTJ4/PHtxZC50++jvmsTMeiRvv64l3peaQ=;\n b=XHc839l/xz6pbKgSuTjhxgO3ottakERhxZwkiJQiUSEW4zl/kbw1HwBLIk4i6KVrPySI2x\n eoNp5A3BoitRn7qBvrreyAA+WeyjUu51qV+ZueQQaZIp/WZGKHgwZupdhFfmHTYT5KzBod\n kONKjlqid2d0eqf8iLcQSnJPqWgP4rY=", "X-MC-Unique": "LioqU7UxOg6SZK6249eMZQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Date": "Fri, 18 Jun 2021 15:57:32 +0200", "Message-Id": "<20210618135735.253770-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210618135735.253770-1-maxime.coquelin@redhat.com>", "References": "<20210618135735.253770-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v5 1/4] vhost: fix missing memory table NUMA\n realloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the guest allocates virtqueues on a different NUMA node\nthan the one the Vhost metadata are allocated, both the Vhost\ndevice struct and the virtqueues struct are reallocated.\n\nHowever, reallocating the Vhost memory table was missing, which\nlikely causes at least one cross-NUMA accesses for every burst\nof packets.\n\nThis patch reallocates this table on the same NUMA node as the\nother metadata.\n\nFixes: 552e8fd3d2b4 (\"vhost: simplify memory regions handling\")\nCc: stable@dpdk.org\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost_user.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 8f0eba6412..b5a84f3dcd 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -473,8 +473,8 @@ vhost_user_set_vring_num(struct virtio_net **pdev,\n }\n \n /*\n- * Reallocate virtio_dev and vhost_virtqueue data structure to make them on the\n- * same numa node as the memory of vring descriptor.\n+ * Reallocate virtio_dev, vhost_virtqueue and related data structures to\n+ * make them on the same numa node as the memory of vring descriptor.\n */\n #ifdef RTE_LIBRTE_VHOST_NUMA\n static struct virtio_net*\n@@ -557,6 +557,9 @@ numa_realloc(struct virtio_net *dev, int index)\n \t\tgoto out;\n \t}\n \tif (oldnode != newnode) {\n+\t\tstruct rte_vhost_memory *old_mem;\n+\t\tssize_t mem_size;\n+\n \t\tVHOST_LOG_CONFIG(INFO,\n \t\t\t\"reallocate dev from %d to %d node\\n\",\n \t\t\toldnode, newnode);\n@@ -568,6 +571,18 @@ numa_realloc(struct virtio_net *dev, int index)\n \n \t\tmemcpy(dev, old_dev, sizeof(*dev));\n \t\trte_free(old_dev);\n+\n+\t\tmem_size = sizeof(struct rte_vhost_memory) +\n+\t\t\tsizeof(struct rte_vhost_mem_region) * dev->mem->nregions;\n+\t\told_mem = dev->mem;\n+\t\tdev->mem = rte_malloc_socket(NULL, mem_size, 0, newnode);\n+\t\tif (!dev->mem) {\n+\t\t\tdev->mem = old_mem;\n+\t\t\tgoto out;\n+\t\t}\n+\n+\t\tmemcpy(dev->mem, old_mem, mem_size);\n+\t\trte_free(old_mem);\n \t}\n \n out:\n", "prefixes": [ "v5", "1/4" ] }