Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94346/?format=api
{ "id": 94346, "url": "https://patches.dpdk.org/api/patches/94346/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210617105845.125472-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210617105845.125472-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210617105845.125472-3-maxime.coquelin@redhat.com", "date": "2021-06-17T10:58:40", "name": "[2/7] vhost: fix missing guest pages table NUMA realloc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e839813027a18c90e171fb9eb250b63c1747e9df", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210617105845.125472-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 17373, "url": "https://patches.dpdk.org/api/series/17373/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17373", "date": "2021-06-17T10:58:38", "name": "vhost: Fix and improve NUMA reallocation", "version": 1, "mbox": "https://patches.dpdk.org/series/17373/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94346/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 80B7CA0C4D;\n\tThu, 17 Jun 2021 13:00:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AC34341181;\n\tThu, 17 Jun 2021 12:59:00 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 7A4344111B\n for <dev@dpdk.org>; Thu, 17 Jun 2021 12:58:58 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-125-C3eNWzqdM7S4WJ5-s7jdFg-1; Thu, 17 Jun 2021 06:58:56 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 513F156AA7;\n Thu, 17 Jun 2021 10:58:54 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.45])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 1816E519D0;\n Thu, 17 Jun 2021 10:58:52 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1623927537;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eGzY5Z7Uhq4x+kamaF7STpZ+s1TxFHVRuU61XxkXeik=;\n b=flRBLLDSYzrqlkpC0t5jfv1n2Gy5a0Dk/OoyIop2MSsAl6dEZhwo6jVVzbeW9ds3W75Bo+\n sOvW/Ge/Bu19YFd7j0xUTjz6FmGcmEC2gfPeTUO753pZGqaXjaroCcyc2eS1eNYkGIbSev\n woSTIARBtDp3cD9xHS/UUT952+r8IJY=", "X-MC-Unique": "C3eNWzqdM7S4WJ5-s7jdFg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Date": "Thu, 17 Jun 2021 12:58:40 +0200", "Message-Id": "<20210617105845.125472-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210617105845.125472-1-maxime.coquelin@redhat.com>", "References": "<20210617105845.125472-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 2/7] vhost: fix missing guest pages table NUMA\n realloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the guest allocates virtqueues on a different NUMA node\nthan the one the Vhost metadata are allocated, both the Vhost\ndevice struct and the virtqueues struct are reallocated.\n\nHowever, reallocating the guest pages table was missing, which\nlikely causes at least one cross-NUMA accesses for every burst\nof packets.\n\nThis patch reallocates this table on the same NUMA node as the\nother metadata.\n\nFixes: e246896178e6 (\"vhost: get guest/host physical address mappings\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost_user.c | 14 +++++++++++++-\n 1 file changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 031e3bfa2f..cbfdf1b4d8 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -558,7 +558,8 @@ numa_realloc(struct virtio_net *dev, int index)\n \t}\n \tif (oldnode != newnode) {\n \t\tstruct rte_vhost_memory *old_mem;\n-\t\tssize_t mem_size;\n+\t\tstruct guest_page *old_gp;\n+\t\tssize_t mem_size, gp_size;\n \n \t\tVHOST_LOG_CONFIG(INFO,\n \t\t\t\"reallocate dev from %d to %d node\\n\",\n@@ -583,6 +584,17 @@ numa_realloc(struct virtio_net *dev, int index)\n \n \t\tmemcpy(dev->mem, old_mem, mem_size);\n \t\trte_free(old_mem);\n+\n+\t\tgp_size = dev->max_guest_pages * sizeof(*dev->guest_pages);\n+\t\told_gp = dev->guest_pages;\n+\t\tdev->guest_pages = rte_malloc_socket(NULL, gp_size, RTE_CACHE_LINE_SIZE, newnode);\n+\t\tif (!dev->guest_pages) {\n+\t\t\tdev->guest_pages = old_gp;\n+\t\t\tgoto out;\n+\t\t}\n+\n+\t\tmemcpy(dev->guest_pages, old_gp, gp_size);\n+\t\trte_free(old_gp);\n \t}\n \n out:\n", "prefixes": [ "2/7" ] }